Commit af0e017
authored
fix: remove non-existent round prop from IconButton (#35537)
## **Description**
This PR fixes a React warning by removing the non-existent `round` prop
from IconButton components in the CoinButtons component. The `round`
prop was being passed with a boolean value `false` to IconButton
components that don't support this attribute, causing console warnings.
The changes remove the `round={!displayNewIconButtons}` prop from all
IconButton instances in the coin-buttons.tsx file.
## **Changelog**
CHANGELOG entry: null
## **Related issues**
Fixes console warnings for non-boolean attribute `round` in coin
buttons.
## **Manual testing steps**
1. Open the MetaMask extension
2. Navigate to the wallet overview page where coin buttons are displayed
3. Open browser dev tools and check console
4. Verify no warnings about non-existent `round` prop are displayed
5. Verify coin buttons still function correctly (Buy, Swap, Bridge,
Send, Receive)
## **Screenshots/Recordings**
N/A - This is a console warning fix with no visual changes.
### Before
<img width="1504" height="865" alt="Screenshot 2025-08-29 at 1 43 07 PM"
src="https://github.com/user-attachments/assets/2f145263-9115-47c2-b13c-e75f637096fd"
/>
### After
<img width="1510" height="863" alt="Screenshot 2025-08-29 at 1 47 28 PM"
src="https://github.com/user-attachments/assets/d251b559-63eb-429a-9d90-eb1bdef3c237"
/>
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
🤖 Generated with [Claude Code](https://claude.ai/code)1 parent 07b3e53 commit af0e017
2 files changed
Lines changed: 0 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
439 | 439 | | |
440 | 440 | | |
441 | 441 | | |
442 | | - | |
443 | 442 | | |
444 | 443 | | |
445 | 444 | | |
| |||
471 | 470 | | |
472 | 471 | | |
473 | 472 | | |
474 | | - | |
475 | 473 | | |
476 | 474 | | |
477 | 475 | | |
| |||
507 | 505 | | |
508 | 506 | | |
509 | 507 | | |
510 | | - | |
511 | 508 | | |
512 | 509 | | |
513 | 510 | | |
| |||
535 | 532 | | |
536 | 533 | | |
537 | 534 | | |
538 | | - | |
539 | 535 | | |
540 | 536 | | |
541 | 537 | | |
| |||
566 | 562 | | |
567 | 563 | | |
568 | 564 | | |
569 | | - | |
570 | 565 | | |
571 | 566 | | |
572 | 567 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
| |||
0 commit comments