Merge branch 'main' into chore/bump-analytics-controller-1.1.1

Author: gauthierpetetin

.eslintrc.js

@@ -779,5 +779,160 @@ module.exports = {
         ],
       },
     },
+    /**
+     * E2E page objects
+     *
+     * Page objects should declare selectors (fields) alphabetically at the
+     * top, followed by the constructor, then methods in alphabetical order.
+     *
+     * The files listed in `excludedFiles` don't yet comply. They are
+     * temporarily exempt and should be removed from this list as each one is
+     * reordered. Do NOT add new files here — new page objects must comply.
+     *
+     * TODO: Reorder the excluded files and delete them from this list.
+     */
+    {
+      files: ['test/e2e/page-objects/**/*.ts'],
+      excludedFiles: [
+        'test/e2e/page-objects/pages/account-list-page.ts',
+        'test/e2e/page-objects/pages/asset-picker.ts',
+        'test/e2e/page-objects/pages/basic-functionality-off-page.ts',
+        'test/e2e/page-objects/pages/bridge/quote-page.ts',
+        'test/e2e/page-objects/pages/confirmations/accountDetailsModal.ts',
+        'test/e2e/page-objects/pages/confirmations/add-network-confirmations.ts',
+        'test/e2e/page-objects/pages/confirmations/add-token-confirmations.ts',
+        'test/e2e/page-objects/pages/confirmations/advanced-permissions-introduction.ts',
+        'test/e2e/page-objects/pages/confirmations/alert-modal.ts',
+        'test/e2e/page-objects/pages/confirmations/batch-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/connect-account-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/decrypt-message-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/deploy-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/gas-fee-modal.ts',
+        'test/e2e/page-objects/pages/confirmations/gas-fee-token-modal.ts',
+        'test/e2e/page-objects/pages/confirmations/get-encryption-key-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/permit-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/perps-withdraw-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/personal-sign-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/review-permissions-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/set-approval-for-all-transaction-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/sign-typed-data-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/snap-sign-in-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/snap-sign-message-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/snap-sign-transaction-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/snap-transaction-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/speed-up-and-cancel-modal.ts',
+        'test/e2e/page-objects/pages/confirmations/switch-network-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/token-transfer-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/transaction-confirmation.ts',
+        'test/e2e/page-objects/pages/confirmations/update-network-confirmation.ts',
+        'test/e2e/page-objects/pages/critical-error-page.ts',
+        'test/e2e/page-objects/pages/debug-page.ts',
+        'test/e2e/page-objects/pages/deep-link-page.ts',
+        'test/e2e/page-objects/pages/defi-details-page.ts',
+        'test/e2e/page-objects/pages/defi-tab.ts',
+        'test/e2e/page-objects/pages/dialog/account-details-modal.ts',
+        'test/e2e/page-objects/pages/dialog/add-edit-network.ts',
+        'test/e2e/page-objects/pages/dialog/add-network-rpc-url.ts',
+        'test/e2e/page-objects/pages/dialog/add-rpc-provider.ts',
+        'test/e2e/page-objects/pages/dialog/add-tokens.ts',
+        'test/e2e/page-objects/pages/dialog/confirm-alert.ts',
+        'test/e2e/page-objects/pages/dialog/create-contract.ts',
+        'test/e2e/page-objects/pages/dialog/dapp-bar-network-selector-popover.ts',
+        'test/e2e/page-objects/pages/dialog/dapp-connections-network-modal.ts',
+        'test/e2e/page-objects/pages/dialog/edit-connected-accounts-modal.ts',
+        'test/e2e/page-objects/pages/dialog/network-permission-select-modal.ts',
+        'test/e2e/page-objects/pages/dialog/network-switch-modal-confirmation.ts',
+        'test/e2e/page-objects/pages/dialog/select-network.ts',
+        'test/e2e/page-objects/pages/dialog/snap-install-warning.ts',
+        'test/e2e/page-objects/pages/dialog/snap-install.ts',
+        'test/e2e/page-objects/pages/dialog/snap-interactive-dialog.ts',
+        'test/e2e/page-objects/pages/dialog/snap-txinsight.ts',
+        'test/e2e/page-objects/pages/dialog/terms-of-use-update-modal.ts',
+        'test/e2e/page-objects/pages/dialog/update-modal.ts',
+        'test/e2e/page-objects/pages/error-page.ts',
+        'test/e2e/page-objects/pages/hardware-wallet/connect-hardware-wallet-page.ts',
+        'test/e2e/page-objects/pages/hardware-wallet/select-hardware-wallet-account-page.ts',
+        'test/e2e/page-objects/pages/header-navbar.ts',
+        'test/e2e/page-objects/pages/home/activity-list.ts',
+        'test/e2e/page-objects/pages/home/asset-list.ts',
+        'test/e2e/page-objects/pages/home/homepage.ts',
+        'test/e2e/page-objects/pages/home/nft-list.ts',
+        'test/e2e/page-objects/pages/home/transaction-details.ts',
+        'test/e2e/page-objects/pages/login-page.ts',
+        'test/e2e/page-objects/pages/multichain/account-address-modal.ts',
+        'test/e2e/page-objects/pages/multichain/address-list-modal.ts',
+        'test/e2e/page-objects/pages/multichain/multichain-account-details-page.ts',
+        'test/e2e/page-objects/pages/multichain/private-key-modal.ts',
+        'test/e2e/page-objects/pages/network-manager.ts',
+        'test/e2e/page-objects/pages/nft-details-page.ts',
+        'test/e2e/page-objects/pages/notification-details-page.ts',
+        'test/e2e/page-objects/pages/notifications-list-page.ts',
+        'test/e2e/page-objects/pages/onboarding/onboarding-complete-page.ts',
+        'test/e2e/page-objects/pages/onboarding/onboarding-metrics-page.ts',
+        'test/e2e/page-objects/pages/onboarding/onboarding-password-page.ts',
+        'test/e2e/page-objects/pages/onboarding/onboarding-privacy-settings-page.ts',
+        'test/e2e/page-objects/pages/onboarding/onboarding-srp-page.ts',
+        'test/e2e/page-objects/pages/onboarding/secure-wallet-page.ts',
+        'test/e2e/page-objects/pages/onboarding/setup-passkey-page.ts',
+        'test/e2e/page-objects/pages/onboarding/start-onboarding-page.ts',
+        'test/e2e/page-objects/pages/permission/gator-permissions-page.ts',
+        'test/e2e/page-objects/pages/permission/permission-list-page.ts',
+        'test/e2e/page-objects/pages/permission/site-permission-page.ts',
+        'test/e2e/page-objects/pages/perps/perps-activity-page.ts',
+        'test/e2e/page-objects/pages/perps/perps-home-page.ts',
+        'test/e2e/page-objects/pages/perps/perps-market-detail-page.ts',
+        'test/e2e/page-objects/pages/perps/perps-market-list-page.ts',
+        'test/e2e/page-objects/pages/perps/perps-order-entry-page.ts',
+        'test/e2e/page-objects/pages/perps/perps-withdraw-page.ts',
+        'test/e2e/page-objects/pages/phishing-warning-page.ts',
+        'test/e2e/page-objects/pages/reset-password-page.ts',
+        'test/e2e/page-objects/pages/send/bitcoin-review-tx-page.ts',
+        'test/e2e/page-objects/pages/send/send-page.ts',
+        'test/e2e/page-objects/pages/send/solana-confirm-tx-page.ts',
+        'test/e2e/page-objects/pages/send/solana-send-page.ts',
+        'test/e2e/page-objects/pages/send/solana-tx-result-page.ts',
+        'test/e2e/page-objects/pages/settings/about-page.ts',
+        'test/e2e/page-objects/pages/settings/advanced-settings.ts',
+        'test/e2e/page-objects/pages/settings/backup-and-sync-settings.ts',
+        'test/e2e/page-objects/pages/settings/contacts-settings.ts',
+        'test/e2e/page-objects/pages/settings/experimental-settings.ts',
+        'test/e2e/page-objects/pages/settings/notifications-settings-page.ts',
+        'test/e2e/page-objects/pages/settings/preferences-and-display-settings.ts',
+        'test/e2e/page-objects/pages/settings/preinstalled-example-settings.ts',
+        'test/e2e/page-objects/pages/settings/privacy-settings.ts',
+        'test/e2e/page-objects/pages/settings/settings-page.ts',
+        'test/e2e/page-objects/pages/settings/shield/shield-claim-page.ts',
+        'test/e2e/page-objects/pages/settings/shield/shield-claims-list-page.ts',
+        'test/e2e/page-objects/pages/settings/shield/shield-detail-page.ts',
+        'test/e2e/page-objects/pages/settings/shield/shield-plan-page.ts',
+        'test/e2e/page-objects/pages/settings/shield/shield-subscription-approve-page.ts',
+        'test/e2e/page-objects/pages/settings/transactions-settings.ts',
+        'test/e2e/page-objects/pages/snap-list-page.ts',
+        'test/e2e/page-objects/pages/snap-simple-keyring-page.ts',
+        'test/e2e/page-objects/pages/swap/swap-page.ts',
+        'test/e2e/page-objects/pages/test-dapp-mm-connect.ts',
+        'test/e2e/page-objects/pages/test-dapp-multichain.ts',
+        'test/e2e/page-objects/pages/test-dapp-send-eth-with-private-key.ts',
+        'test/e2e/page-objects/pages/test-dapp-solana.ts',
+        'test/e2e/page-objects/pages/test-dapp-tron.ts',
+        'test/e2e/page-objects/pages/test-dapp.ts',
+        'test/e2e/page-objects/pages/test-snaps.ts',
+        'test/e2e/page-objects/pages/token-overview-page.ts',
+        'test/e2e/page-objects/pages/vault-decryptor-page.ts',
+        'test/e2e/page-objects/pages/wallet-details-page.ts',
+      ],
+      rules: {
+        '@typescript-eslint/member-ordering': [
+          'error',
+          {
+            classes: {
+              memberTypes: ['field', 'constructor', 'method'],
+              order: 'alphabetically',
+            },
+          },
+        ],
+      },
+    },
   ],
 };

.github/scripts/benchmark-stats-commit.sh

@@ -122,15 +122,21 @@ assemble_performance_data() {
 
     # Merge the startup group into presets (only if any startup files were found).
     if [[ "${page_load_json}" != "{}" ]]; then
-        presets_json=$(echo "${presets_json}" | jq --argjson pl "${page_load_json}" '. + {"pageLoad": $pl}')
+        # Keep large JSON off argv (ARG_MAX): presets_json via stdin, page_load_json
+        # via a temp file read with --slurpfile.
+        pl_file="$(mktemp)"
+        printf '%s' "${page_load_json}" >"${pl_file}"
+        presets_json=$(printf '%s' "${presets_json}" | jq --slurpfile pl "${pl_file}" '. + {"pageLoad": $pl[0]}')
+        rm -f "${pl_file}"
     fi
 
     echo "Collected ${file_count} preset(s)" >&2
 
-    jq -n \
+    # presets_json can exceed ARG_MAX; pass it via stdin instead of as a jq argument
+    # (a too-large argv makes the kernel fail to exec jq with "Argument list too long").
+    printf '%s' "${presets_json}" | jq \
         --argjson timestamp "$(date +%s000)" \
-        --argjson presets "${presets_json}" \
-        '{ timestamp: $timestamp, presets: $presets }'
+        '{ timestamp: $timestamp, presets: . }'
 }
 
 # Resolve stats file and assemble data
@@ -191,8 +197,14 @@ fi
 
 TEMP_FILE="${STATS_FILE}.tmp"
 
-jq --arg sha "${HEAD_COMMIT_HASH}" --argjson data "${COMMIT_DATA}" \
-    '. + {($sha): $data}' "${STATS_FILE}" > "${TEMP_FILE}"
+# COMMIT_DATA wraps presets_json and is strictly larger, so it can exceed
+# ARG_MAX too. Read it via --slurpfile from a temp file rather than passing
+# the blob on argv.
+data_file="$(mktemp)"
+printf '%s' "${COMMIT_DATA}" >"${data_file}"
+jq --arg sha "${HEAD_COMMIT_HASH}" --slurpfile data "${data_file}" \
+    '. + {($sha): $data[0]}' "${STATS_FILE}" > "${TEMP_FILE}"
+rm -f "${data_file}"
 mv "${TEMP_FILE}" "${STATS_FILE}"
 
 git add "${STATS_FILE}"

.github/workflows/ai-pr-risk-analysis.yml

@@ -24,6 +24,7 @@ jobs:
     permissions:
       contents: read
       pull-requests: write
+      checks: write
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
@@ -39,8 +40,6 @@ jobs:
 
       - name: Run AI PR Analysis
         uses: ./.ai-analyzer-action
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           mode: pr-risk-analysis
           add-comment: false

CHANGELOG.md

@@ -7,6 +7,57 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [13.34.1]
+
+### Changed
+
+- Bumped `@lavamoat/webpack` from 2.2.0 to 2.2.3 (#43333)
+
+### Fixed
+
+- Fixed handling of scientific notation in `parseBalanceWithDecimals` to prevent BigInt crash (#43314)
+
+## [13.34.0]
+
+### Added
+
+- Added section to manage networks (#42944)
+- Added the client version to the transaction metadata (#43022)
+- Added address poisoning warnings when sending to suspiciously similar addresses (#42893)
+- Add new UI and error handling for QR scanning (#42905)
+- Added a volume value label on the Perps chart y-axis that appears when hovering a volume bar. (#42882)
+- Hardened the SRP Reveal malicious-site warning into a full-page block with no proceed-anyway path (#42737)
+- Add Telegram login to Social Login option (#42103)
+- Added low value tokens section (#42681)
+- Fix onboarding's backup & sync toggle being stuck when enabled (#42904)
+- Added a biometrics setup step after restoring a wallet (in forgot password flow) so users can enable passkey unlock before (#42865)
+  returning home.
+- Added new UI for hardware wallet onboarding process (#42720)
+- Fixed a bug that stopped Solana tokens from being imported (#42854)
+  Fixed a bug that stopped Tron assets for showing on
+  first import
+- Add new user traits in metametrics, `account_type`. (#42855)
+- Adds new ERC-7715 permission type `token-approval-revocation` that can be granted via (#42841)
+  `wallet_requestExecutionPermissions`
+- Add support for `token-approval-revocation` permission via `wallet_requestExecutionPermissions` RPC (#42954)
+- Show hidden tokens in Send Flow (#42934)
+- Add Sentry distributed tracing instrumentation for Background RPC calls and inter-controller messenger calls. (#39891)
+
+  ### Fixed
+
+- perf(6634): extract gas estimate side-effects, strip unused withRouter props (#42687)
+- Fixed the VIP tier label to display "VIP" instead of "VIP Fox" (#42856)
+- perf(6633): strip unused `withRouterHooks` props in lock and unlock-page containers (#42688)
+- Updated Activity tab empty states to show context-specific messaging and actions when users have no transaction (#42786)
+  history
+- Removed outdated translations from community-contributed ga, pt_BR, and zh_TW locales. (#40974)
+
+### Changed
+
+- Bump the `@metamask/tron-wallet-snap` to `^1.25.6` (#42701)
+- Bumped bitcoin snap v1.11.0 (#42993)
+- chore: Replace `await-semaphore` with `async-mutex` (#42818)
+
 ## [13.33.0]
 
 ### Added
@@ -21,6 +72,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Added stop loss, take profit, liquidation, and auto-deleveraging badges to perps activity rows (#42645)
 - Added VIP tier badge and fee discount display for Perps trading and Bridge transactions (#42782)
 - Show VIP badge in swap page (#42771)
+- Update toggle (#42714)
+- Show enforced-simulations protection state ("Cancelled" status + info banner) in transaction details and Activity v2; rename (#42368)
+  `FORCE_ENABLE_SIMULATIONS` dev flag.
 
 ### Changed
 
@@ -30,27 +84,39 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
-- Fixed a bug that stopped Solana and Tron tokens from being imported (#42854)
-- Fixed merging RPC and token list metadata on custom import (#42840)
-- Removed the number of promises waiting for unlock from the badge (#42825)
-- Fixed sponsored hardware wallet send max native (#42494)
-- Fixed a perps bug where market orders submitted with TP/SL left the Auto-close section empty and surfaced the TP/SL orders in the Orders section of the market detail page (#42661)
-- Fixed a bug that made only the Recent activity arrow tappable in Perps (#42676)
-- Fixed Perps withdraw validation and activity details (#42751)
+- Fixed carousel links so supported deep links open directly in MetaMask instead of going through an extra browser tab. (#42634)
+- Fixed an issue where EIP-7702 authorization signatures with leading zero bytes in `r` or `s` could be rejected by relays and (#42970)
+  public RPCs.
+- Add guard to asset-util to prevent infinite recursion (#42966)
+- Fix the inpage provider not being available via `window.ethereum` and EIP-6963 on websites with certain (#42338)
+  Content-Security-Policy settings configured.
+- Fixed a bug that could default transactions to gas station before the native balance finished loading, and corrected (#42857)
+  gasless native-balance metrics for nested and L1-fee transactions.
+- Merge RPC and token list metadata on custom import (#42840)
+- Remove the number of promises waiting for unlock from the badge (#42825)
+- Added current position size display on the increase exposure screen for perpetual trades (#42673)
+- Sponsored hardware wallet send max native (#42494)
+- Fixed a perps bug where market orders submitted with TP/SL left the Auto-close section empty and surfaced the TP/SL orders in (#42661)
+  the Orders section of the market detail page.
+- Fixed a bug that made only the Recent activity arrow tappable in Perps. (#42676)
+- Fixed Perps withdraw validation and activity details. (#42751)
+- N/A (#42770)
 - Fixed Perps market token logos that were difficult to see in dark mode (#42689)
 - Fixed open order price display to use correct number of decimals matching market price precision (#42405)
-- Fixed BTC swap when BTC network fees not retrieved (#42632)
+- Prevented BTC swap when BTC network fees not retrieved (#42632)
+- Null (#42698)
+- Fixed a bug that stopped Solana and Tron tokens from being imported (#42854)
 - Fixed Monad swap activity in asset details (#42669)
 
 ## [13.32.1]
 
 ### Changed
 
-- Bumped `qs` to 6.15.2, `tmp` to 0.2.6, updated uuid audit ignore ([#42999](https://github.com/MetaMask/metamask-extension/pull/42999))
+- Bumped `qs` to 6.15.2, `tmp` to 0.2.6, updated uuid audit ignore (#42999)
 
 ### Fixed
 
-- Disabled unified assets controller to fix background calls issue ([#42992](https://github.com/MetaMask/metamask-extension/pull/42992))
+- Disabled unified assets controller to fix background calls issue (#42992)
 
 ## [13.32.0]
 
@@ -2396,7 +2462,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - This changelog was split off with 12.22.0
 - All older changes can be found in [docs/CHANGELOG_older.md](https://github.com/MetaMask/metamask-extension/blob/main/docs/CHANGELOG_older.md)
 
-[Unreleased]: https://github.com/MetaMask/metamask-extension/compare/v13.33.0...HEAD
+[Unreleased]: https://github.com/MetaMask/metamask-extension/compare/v13.34.1...HEAD
+[13.34.1]: https://github.com/MetaMask/metamask-extension/compare/v13.34.0...v13.34.1
+[13.34.0]: https://github.com/MetaMask/metamask-extension/compare/v13.33.0...v13.34.0
 [13.33.0]: https://github.com/MetaMask/metamask-extension/compare/v13.32.1...v13.33.0
 [13.32.1]: https://github.com/MetaMask/metamask-extension/compare/v13.32.0...v13.32.1
 [13.32.0]: https://github.com/MetaMask/metamask-extension/compare/v13.31.0...v13.32.0