Skip to content

Commit fd3ac16

Browse files
authored
feat: enable account syncing in production (#28596)
## **Description** This PR enables account syncing in production [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28596?quickstart=1) ## **Related issues** Fixes: #28438 ## **Manual testing steps** 1. Onboard with your SRP 2. Add accounts, rename accounts 3. Uninstall the extension 4. Reinstall and onboard with the previous SRP 5. Verify that your added & renamed accounts are there ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent ad20b71 commit fd3ac16

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

app/scripts/metamask-controller.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ import {
157157
NotificationServicesPushController,
158158
NotificationServicesController,
159159
} from '@metamask/notification-services-controller';
160-
import { isProduction } from '../../shared/modules/environment';
161160
import {
162161
methodsRequiringNetworkSwitch,
163162
methodsThatCanSwitchNetworkWithoutApproval,
@@ -1609,7 +1608,7 @@ export default class MetamaskController extends EventEmitter {
16091608
},
16101609
},
16111610
env: {
1612-
isAccountSyncingEnabled: !isProduction() && isManifestV3,
1611+
isAccountSyncingEnabled: isManifestV3,
16131612
},
16141613
messenger: this.controllerMessenger.getRestricted({
16151614
name: 'UserStorageController',

0 commit comments

Comments
 (0)