Skip to content

Fix browser-specific manifest generation #12532

Open
@MakMuftic

Description

@MakMuftic

Describe the bug
Code for merging _base.json manifest and some browser-specific manifest like chrome.json is not working properly when there is property which value is array defined in both manifests.

Steps to reproduce (REQUIRED)

  1. Define one additional permission in the browser-specific manifest, let's say in chrome.json
  2. Run yarn dist
  3. Check generated manifest for chrome, permission in chrome.json override first permissions from _base.json

Expected behavior
For upper example, generated manifest for chrome should have all permissions from _base.json and additionally permission defined in chrome.json.

In a broader sense, if the same property (array value) is defined in base and the browser-specific manifest resulting manifest should hold all array elements from both _base.json and browser-specific manifest (also should check for duplicates).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions