[Bug]: Network changed events fired with a delay

[SpasiboKojima]

Describe the bug

I hope I'm at the right place because it doesn't seem much of a bug, but maybe something can be done about it.
I'm connecting Metamask to my app, and right after user grants access I check the chainId, if it's not the one I expect I do wallet_switchEthereumChain, and if right after that I do login process again where this time it passes chainId check and subscriptions happen, and after going this far MM emits events disconnect or/and accountsChanged. Alternatively, without auto-login after chain switch if you click fast enough on login button again after network switch you'll catch this events.
BUT it doesn't happen if the target chain is mainnet, in my case it's Binance Smart Chain and it's Testnet that I'm testing.
Again, events related to network switch fire much later after it actually happened

Steps to reproduce

1. Try to login into app with wrong network
2. Have a wallet_switchEthereumChain request asking you to change network to the right one
3. Click on login button again within 1.5 seconds or automatically try to connect through web3
4. Have chainId check passed but still get an event related to changing networks much later

Error messages or log output

No response

Version

10.8.1

Build type

No response

Browser

Chrome, Firefox

Operating system

Linux

Hardware wallet

No response

Additional context

No response

[mloit]

I believe I'm seeing a related issue. Metamask (injected provider) disconnects whenever the chain is changed to the Binance Test Network. I can freely switch from it to any network, or between any other networks I've tried, but as soon as I switch back into the binance testnet instead of getting a chainChanged event, I get a disconnect event.

main.js:450 onChainChanged: 0x38
main.js:450 onChainChanged: 0x3
main.js:450 onChainChanged: 0x4
main.js:468 onDisconnect: Error: MetaMask: Disconnected from chain. Attempting to connect.
    at l._handleDisconnect (inpage.js:1:39598)
    at l._handleDisconnect (inpage.js:1:43404)
    at l._handleChainChanged (inpage.js:1:40205)
    at l._handleChainChanged (inpage.js:1:45320)
    at o.<anonymous> (inpage.js:1:37771)
    at i (inpage.js:1:54958)
    at o.emit (inpage.js:1:55498)
    at inpage.js:1:54022
    at f.write [as _write] (inpage.js:1:54045)
    at w (inpage.js:17:29414)

If I reload the page, I am connected just fine. It only breaks when I switch into the testnet from metamask.

[ErnoW]

I can confirm that this is an issue with some Binance Smartchain Testnet RPCs.

When switching from any chain to Binance Smartchain Testnet, for some RPCs a disconnect event is fired. (and results in a delay)

This RPC results in the above error MetaMask: Disconnected from chain. Attempting to connect, but succeeds after the retry:

https://data-seed-prebsc-1-s1.binance.org:8545

This one seems to work without issues:

https://data-seed-prebsc-2-s3.binance.org:8545

Both are from the binance docs

[tmm]

Can confirm this happens for other chains and is affecting wagmi library users.

To reproduce:

1. Open CodeSandbox (https://vwngww.csb.app) and connect wallet
2. Switch to any non MM default chain (Arbitrum One, Polygon Mainnet, etc.)

Using MM 10.9.3. cc @kevinghim

[vm06007]

same issue observed, any solution?

[tmm]

@kevinghim here's a very simple reproduction (using MetaMask 10.11.3) that you can run in the browser console. Let me know if you need any more info.

1. Add event listener for disconnect event

window.ethereum.on('disconnect', () => alert('disconnect'));

2. Connect account

await window.ethereum.request({ method: 'eth_requestAccounts' });

3. Using a custom chain (i.e. Optimism), switch:

await window.ethereum.request({
  method: 'wallet_switchEthereumChain',
  params: [{ chainId: '0xa' }],
})

Or add and switch:

await window.ethereum.request({
  method: 'wallet_addEthereumChain',
  params: [
    {
      chainId: '0xa',
      chainName: 'Optimism',
      nativeCurrency: {name: 'Ether', symbol: 'ETH', decimals: 18},
      rpcUrls: ['https://mainnet.optimism.io'],
      blockExplorerUrls: ['https://optimistic.etherscan.io'],
    },
  ],
});

4. After a successfully switching to the custom chain, disconnect event fires and browser alert is created.

[vm06007]

is this still an issue or has been fixed?

[mqklin]

I have the same problem. Switching to custom network sometimes fires disconnect event.