Open
Description
What is this about?
With this commit in v11.10.0 native value was moved from under token name to under fiat value without respecting the logic for overall account balance.
Currently, with Native (ETH) primary currency selected, overall account balance is first displayed in native (ETH) and then fiat (USD), while token balance is reversed, to USD and then ETH below.
Hence, switching primary currency to Fiat (USD) will change overall account balance to USD and ETH below, and token balance to ETH and USD below.
This logic was appropriately implemented in older versions such as 10.29.0.
Scenario
A.
- GIVEN a user chooses Native as Primary currency
- WHEN the user goes to the main screen
- AND the user checks the overall account balance and the token balance in Tokens list
- THEN the user should see Native option first (ETH) and fiat option below (USD) in both overall account balance and tokens list
B.
- GIVEN a user chooses Fiat as Primary currency
- WHEN the user goes to the main screen
- AND the user checks the overall account balance and the token balance in Tokens list
- THEN the user should see Fiat option first (USD) and Native option below (ETH) in both overall account balance and tokens list
Design
While on native:
While on fiat:
Logic followed appropriately in version 10.29.0 as example:
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
- Engineering (needed in most cases)
- Design
- Product
- QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- Security
- Legal
- Marketing
- Management (please specify)
- Other (please specify)
References
No response