Description
Our usage of getAddressAccountType
utility doesn't throw invalid address and passed messageData.from
property is already validated in multiple places in signature requests. That said we are sure of usage in useSignatureMetrics
passing expected address even though the given error context is missing due to scrubbing rule.
There are multiple signs that this function is not working properly on other places too
Example 1
Example 2
Example 3
All related issues
This task naturally assigned us because the most encountered error case was in signatures. But I believe this should be investigated by wallet platform team (assuming they have the responsibility of KeyringController
) to understand root cause of not matching given address with any keyring accounts.
Originally posted by @OGPoyraz at MetaMask/metamask-mobile#13764 (comment)