test: MMQA 1570 - migrate ppom-toggle-settings.spec.js to POM

[LeVinhGithub]

Description

Refactors the PPOM Settings E2E tests to align with the project's Page Object Model (POM) and TypeScript standards.

1. TypeScript migration: Replaces ppom-toggle-settings.spec.js with a TypeScript version (.ts) and uses ES module imports instead of require.
2. POM refactor: Replaces hardcoded selectors with page object methods:
   • TestDapp: Adds maliciousPermitButton locator and clickMaliciousPermitButton() for the malicious permit button.
   • Confirmation: Adds securityProviderBannerAlert locator and checkSecurityProviderBannerAlertIsPresent() for the Blockaid alert banner.
   • Reuses existing methods for settings navigation: HeaderNavbar.openSettingsPage(), SettingsPage.goToPrivacySettings(), and PrivacySettings.toggleBlockaidAlerts().
3. Test logic: Keeps both scenarios unchanged: (1) PPOM warning hidden when toggle is off, (2) PPOM warning shown when toggle is on (default).

Changelog

CHANGELOG entry: null

Related issues

Fixes: MMQA-1570

Manual testing steps

1. Build the test bundle: yarn build:test
2. Run the PPOM Settings tests: yarn test:e2e:single test/e2e/tests/ppom/ppom-toggle-settings.spec.ts --browser=chrome
3. Tests are currently skipped (it.skip); for manual verification, remove the skip and run the above command.

Screenshots/Recordings

Before

N/A — test refactor only; no UI changes.

After

N/A — test refactor only; no UI changes.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbotv2]

✨ Files requiring CODEOWNER review ✨

🧪 @MetaMask/qa (2 files, +15 -0)

• 📁 test/
  • 📁 e2e/
    • 📁 page-objects/
      • 📁 pages/
        • 📁 confirmations/
          • 📄 confirmation.ts +7 -0
          • 📄 test-dapp.ts +8 -0

[metamaskbotv2]

Builds ready [80d110b]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• interaction-benchmark: Interaction Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
  • content-script: 0
  • offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks

Benchmark	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P75 (ms)	P95 (ms)
Load New Account	load_new_account	369	268	494	98	479	494
	total	369	268	494	98	479	494
Confirm Tx	confirm_tx	6031	6002	6064	21	6041	6064
	total	6031	6002	6064	21	6041	6064
Bridge User Actions	bridge_load_page	273	228	345	46	308	345
	bridge_load_asset_picker	228	161	262	38	258	262
	bridge_search_token	751	738	772	14	762	772
	total	1251	1227	1264	14	1262	1264

🔌 Startup Benchmarks

Benchmark	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P75 (ms)	P95 (ms)
Standard Home	uiStartup	1432	1215	1835	109	1473	1623
	load	1189	999	1556	98	1235	1364
	domContentLoaded	1182	992	1550	96	1229	1358
	domInteractive	29	17	123	20	26	85
	firstPaint	161	69	1376	143	209	287
	backgroundConnect	211	196	270	13	212	241
	firstReactRender	20	12	45	7	21	36
	initialActions	1	0	5	1	1	4
	loadScripts	988	803	1343	95	1031	1164
	setupStore	13	6	31	5	16	21
	numNetworkReqs	39	31	86	16	40	79
Power User Home	uiStartup	5737	2277	18504	2896	6654	9590
	load	1365	1156	2155	148	1402	1672
	domContentLoaded	1344	1149	2137	144	1382	1660
	domInteractive	44	21	298	46	36	163
	firstPaint	205	96	565	102	282	359
	backgroundConnect	2075	310	14982	2613	2893	5146
	firstReactRender	26	17	47	6	27	39
	initialActions	1	0	8	1	1	3
	loadScripts	1111	938	1852	133	1157	1392
	setupStore	17	7	71	9	18	32
	numNetworkReqs	229	89	398	64	264	345

🧭 User Journey Benchmarks

Benchmark	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P75 (ms)	P95 (ms)
Onboarding Import Wallet	importWalletToSocialScreen	221	217	225	3	222	225
	srpButtonToSrpForm	98	96	101	2	98	101
	confirmSrpToPwForm	22	22	23	0	23	23
	pwFormToMetricsScreen	16	16	16	0	16	16
	metricsToWalletReadyScreen	17	17	18	1	17	18
	doneButtonToHomeScreen	646	625	670	18	664	670
	openAccountMenuToAccountListLoaded	2925	2900	2950	17	2925	2950
	total	3949	3937	3977	16	3945	3977
Onboarding New Wallet	createWalletToSocialScreen	220	219	222	1	221	222
	srpButtonToPwForm	110	108	112	1	110	112
	createPwToRecoveryScreen	9	8	9	0	9	9
	skipBackupToMetricsScreen	40	38	42	1	40	42
	agreeButtonToOnboardingSuccess	16	15	17	1	17	17
	doneButtonToAssetList	502	484	511	13	511	511
	total	898	878	912	15	912	912
Asset Details	assetClickToPriceChart	56	53	63	4	55	63
	total	56	53	63	4	55	63
Solana Asset Details	assetClickToPriceChart	100	81	123	17	111	123
	total	100	81	123	17	111	123
Import Srp Home	loginToHomeScreen	2247	2217	2269	21	2266	2269
	openAccountMenuAfterLogin	59	48	66	7	64	66
	homeAfterImportWithNewWallet	2407	2368	2428	24	2425	2428
	total	4711	4660	4758	40	4742	4758
Send Transactions	openSendPageFromHome	47	23	79	23	72	79
	selectTokenToSendFormLoaded	29	26	32	2	28	32
	reviewTransactionToConfirmationPage	1053	696	1418	259	1268	1418
	total	1139	751	1478	262	1375	1478
Swap	openSwapPageFromHome	121	76	152	28	150	152
	fetchAndDisplaySwapQuotes	2692	2690	2693	1	2692	2693
	total	2814	2770	2844	27	2841	2844

🌐 Dapp Page Load Benchmarks

Current Commit: 80d110b | Date: 3/16/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.03s (±41ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
• domContentLoaded-> current mean value: 721ms (±38ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 87ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	41ms	973ms	1.32s	1.05s	1.32s
domContentLoaded	721ms	38ms	676ms	996ms	739ms	996ms
firstPaint	79ms	11ms	64ms	176ms	88ms	176ms
firstContentfulPaint	79ms	11ms	64ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

• background: 58 Bytes (0%)
• ui: 5 Bytes (0%)
• common: 20 Bytes (0%)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[metamaskbotv2]

Builds ready [ab64778]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• interaction-benchmark: Interaction Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
  • content-script: 0
  • offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks

Benchmark	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P75 (ms)	P95 (ms)
Load New Account	load_new_account	296	285	318	12	302	318
	total	296	285	318	12	302	318
Confirm Tx	confirm_tx	6066	6033	6118	34	6072	6118
	total	6066	6033	6118	34	6072	6118
Bridge User Actions	bridge_load_page	239	203	275	24	246	275
	bridge_load_asset_picker	244	224	265	14	252	265
	bridge_search_token	770	761	778	6	771	778
	total	1250	1248	1252	2	1252	1252

🔌 Startup Benchmarks

Benchmark	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P75 (ms)	P95 (ms)
Standard Home	uiStartup	1549	1273	2186	121	1599	1738
	load	1282	1030	1786	112	1337	1466
	domContentLoaded	1273	1019	1773	111	1330	1459
	domInteractive	32	19	117	22	27	94
	firstPaint	218	73	1391	235	228	417
	backgroundConnect	219	200	273	16	223	256
	firstReactRender	20	12	55	7	21	34
	initialActions	1	0	7	1	1	5
	loadScripts	1074	827	1539	109	1127	1255
	setupStore	14	8	52	7	16	25
	numNetworkReqs	39	31	91	17	31	83
Power User Home	uiStartup	5283	2399	13861	2274	6364	8518
	load	1311	1077	1921	134	1371	1586
	domContentLoaded	1288	1067	1888	128	1347	1527
	domInteractive	36	19	196	33	32	114
	firstPaint	189	86	510	94	269	334
	backgroundConnect	1525	280	10568	1920	1294	4793
	firstReactRender	24	17	51	5	26	32
	initialActions	1	0	6	1	1	3
	loadScripts	1066	859	1648	122	1098	1285
	setupStore	16	7	169	17	16	26
	numNetworkReqs	259	120	355	60	306	337

🧭 User Journey Benchmarks

Benchmark	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P75 (ms)	P95 (ms)
Onboarding Import Wallet	importWalletToSocialScreen	220	219	222	1	220	222
	srpButtonToSrpForm	96	95	97	1	97	97
	confirmSrpToPwForm	22	22	23	0	22	23
	pwFormToMetricsScreen	16	15	16	0	16	16
	metricsToWalletReadyScreen	16	16	16	0	16	16
	doneButtonToHomeScreen	610	603	620	7	620	620
	openAccountMenuToAccountListLoaded	2916	2906	2926	9	2924	2926
	total	3900	3897	3905	4	3905	3905
Onboarding New Wallet	createWalletToSocialScreen	219	218	221	1	220	221
	srpButtonToPwForm	110	108	113	2	112	113
	createPwToRecoveryScreen	8	8	9	0	9	9
	skipBackupToMetricsScreen	39	38	39	1	39	39
	agreeButtonToOnboardingSuccess	16	16	17	0	16	17
	doneButtonToAssetList	453	304	581	111	548	581
	total	846	696	974	112	942	974
Asset Details	assetClickToPriceChart	71	51	91	17	86	91
	total	71	51	91	17	86	91
Solana Asset Details	assetClickToPriceChart	112	45	173	45	143	173
	total	112	45	173	45	143	173
Import Srp Home	loginToHomeScreen	2288	2241	2360	47	2301	2360
	openAccountMenuAfterLogin	52	33	64	12	64	64
	homeAfterImportWithNewWallet	2375	2231	2577	136	2423	2577
	total	4658	4621	4729	50	4729	4729
Send Transactions	openSendPageFromHome	36	29	44	5	35	44
	selectTokenToSendFormLoaded	29	25	35	4	30	35
	reviewTransactionToConfirmationPage	1216	980	1400	179	1380	1400
	total	1281	1050	1469	172	1439	1469
Swap	openSwapPageFromHome	134	97	178	29	138	178
	fetchAndDisplaySwapQuotes	2691	2686	2698	4	2693	2698
	total	2826	2786	2875	32	2823	2875

🌐 Dapp Page Load Benchmarks

Current Commit: ab64778 | Date: 3/17/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.05s (±115ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
• domContentLoaded-> current mean value: 745ms (±129ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
• firstContentfulPaint-> current mean value: 99ms (±198ms) 🟢 | historical mean value: 90ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	115ms	1.02s	2.14s	1.07s	2.14s
domContentLoaded	745ms	129ms	714ms	1.99s	754ms	1.99s
firstPaint	99ms	198ms	64ms	2.07s	96ms	2.07s
firstContentfulPaint	99ms	198ms	64ms	2.07s	96ms	2.07s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

• background: 58 Bytes (0%)
• ui: 5 Bytes (0%)
• common: 20 Bytes (0%)