chore(6635): validate TokenBalancesPoller isolation and AssetPollingContext memoization#42707
Open
Copilot wants to merge 3 commits into
Open
chore(6635): validate TokenBalancesPoller isolation and AssetPollingContext memoization#42707Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
…Context memoization Agent-Logs-Url: https://github.com/MetaMask/metamask-extension/sessions/c94cdb5a-1d8d-41e0-b2cc-4060a80f5f24 Co-authored-by: DDDDDanica <12678455+DDDDDanica@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Extract assets side-effect functionality
test: validate TokenBalancesPoller isolation and AssetPollingContext memoization
May 14, 2026
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +46 -4)
👨🔧 @MetaMask/core-extension-ux (1 files, +46 -4)
|
|
Contributor
Builds ready [12a458a]
⚡ Performance Benchmarks (Total: 🟢 14 pass · 🟡 11 warn · 🔴 0 fail)
Bundle size diffs
|
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Builds ready [b5b13e8] [reused from bfe479c]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 9 warn · 🔴 3 fail)
Bundle size diffs
|
DDDDDanica
added
team-extension-platform
DDDDDanica
changed the title
DDDDDanica
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two render-performance optimizations for the assets UI lacked test coverage:
useTokenBalancesisolation viaTokenBalancesPollerandAssetPollingContextvalue memoization.Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6635
CHANGELOG entry: null
Changes
ui/contexts/assetPolling.test.tsxAssetPollingContextandAssetPollingContextValue(previously unused in tests)toBe), confirming theuseMemoguard prevents context consumers from re-rendering on everyAssetPollingProviderrenderui/components/multichain/account-overview/account-overview-tabs.test.tsxuseTokenBalancesat the module level — previously the hook ran against the real store, relying oncompletedOnboardingbeing falsy to silently skip pollingTokenBalancesPollerdescribe block verifying thatuseTokenBalancesis called with the enabled EVM chain IDs from Redux state:Note
Low Risk
Test-only changes with no production logic modified.
Overview
Adds test-only coverage for two existing assets UI render-performance behaviors.
In
account-overview-tabs.test.tsx,useTokenBalancesis mocked module-wide with a sharedbeforeEachdefault return, and a newTokenBalancesPollercase asserts that renderingAccountOverviewTabswith enabled EVM networks in Redux triggersuseTokenBalanceswithchainIdsincluding mainnet and polygon.In
assetPolling.test.tsx, a context value memoization test re-rendersAssetPollingProviderand checks theAssetPollingContextvalue keeps the same object reference across renders, guarding theuseMemostability behavior.Reviewed by Cursor Bugbot for commit b5b13e8. Bugbot is set up for automated code reviews on this repo. Configure here.