Support CoolWalletS hardware wallet.

[antoncoding]

What problem are you trying to solve?
Support CoolWalletS hardware wallet.
I have been putting some efforts on the integration and want to see if the integration seems okay to the team. Please let us know what you think, how can we improve or any other feedbacks are welcomed.

Describe the solution you'd like
We plan to release a CoolWalletS Bridge webpage like TrezorConnect, and use it as a bridge to establish Bluetooth connection and to communicate with the hardware wallet. If the wallet is empty or the user has not registered the web app to the card before, this page will help the user setup/register/reset.

Additional context
What we have so far:

• A eth-coolwallets-keyring
• A fork of MetaMask wrapping the keying.
• continuous development on CoolWalletS Bridge

Some screenshots from what we already have:

Connect to CoolWalletS

Signing Tx

Our wallet also supports signing message and typedData, the screenshots look similar so I'll skip it.

Please let us know if you think this integration is feasible. Thanks a lot

[grossetti]

Hi @jennypollack,

could you guys have a look at this please, in wake of recent Ledger security issues it would be nice to have another choice, especially since they already wrote the code and it "just" requires a review on your side and "ok" it.

I understand it takes time to review but MetaMask is in need of supporting other HW wallets, especially since MeW has a similar solution now and it supports many HW wallets. I love your project but it really does need more choice in HW wallets. I have even had ppl tell me that you are being paid by Ledger and Trezor to not support other wallets so it channels sales to them but I think this is a load of BS and you are neutral.

Thanks!

[dpazdan]

Hi @antoncoding can you provide an email for us to reach out to you? Thanks!

[antoncoding]

Hi @antoncoding can you provide an email for us to reach out to you? Thanks!

Hi @dpazdan, I no longer works for @CoolBitX-Technology. You should reach out to somebody on the team, cc @noraliucode 😄

[noraliucode]

Hi @dpazdan, thank you for commenting on this issue. As I also developed part of this integration and currently work for CoolBitX, please email me here for further discussion. Thank you! 👍

[benjamin3011]

any progress on this?

[jacobc-eth]

Hi there,

We are currently unable to add more hardware wallets to MetaMask at this time because of the serious maintenance burden that they add on the team. This PR, for example, doesn't currently support EIP-1559 and many other features inside the wallet. We may revisit this policy in the future, but for now we cannot merge new hardware wallets that we cannot commit to suppoting long-term.

We do however now have an open QR-code based standard that any third party hardware wallets can connect with. You can read about it here: https://twitter.com/MetaMask/status/1469351219290382341

[yhcbx]

Hi @jacobc-eth Jacob,

Thank you for your advice. We will definitely look into the new hardware wallet connect feature and see how we could better incorporate it with our CoolWallet.
Thanks again!

[yhcbx]

Hi there,

We are currently unable to add more hardware wallets to MetaMask at this time because of the serious maintenance burden that they add on the team. This PR, for example, doesn't currently support EIP-1559 and many other features inside the wallet. We may revisit this policy in the future, but for now we cannot merge new hardware wallets that we cannot commit to suppoting long-term.

We do however now have an open QR-code based standard that any third party hardware wallets can connect with. You can read about it here: https://twitter.com/MetaMask/status/1469351219290382341

Hi @jacobc-eth Jacob,
We have evaluated the transparent QR-code function and would like to apply it to our CoolWallet.
Would you be able to share the link to the technical documents regarding the specs of the transparent QR function?(sorry, we have looked online and couldn't seem to find it in Metamask support, community or docs) It will be very helpful for our development :)
Please feel free to contact me at yuhan.cheng@coolbitx.com
Thank you!

[phinolex]

Glad to read that the coolwallet team is working on this ! Looking forward to being able to use coolwallet with metamask !