Skip to content

Support CoolWalletS hardware wallet #8196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

antoncoding
Copy link

Hi Team, we have implemented the CoolWalletS integration. Please let us know if this is feasible, or how can we improve to push this to production.

Before Merge:

eth-coolwallet-keyring

UI

  • Replace the current link to coolwallet.io with an affiliate link.

Fix #7569

@whymarrh
Copy link
Contributor

Hi Team, we have implemented the CoolWalletS integration. Please let us know if this is feasible, or how can we improve to push this to production.

Thanks for opening this—is there an open issue for this?

@antoncoding
Copy link
Author

Thanks for opening this—is there an open issue for this?

We opened this issue months back. #7569

@whymarrh
Copy link
Contributor

I appreciate you opening that first. I'll say here the same thing I said to the TrustVault team: there is a good bit of code here that we'll have to review & maintain going forward (in eth-cws-keyring) and we're already working on getting a large major version out the door (v7.7.8...develop). With that, this is unfortunately a lower priority for us right now—we'll be sure to update you here when this is on our radar.

@antoncoding
Copy link
Author

With that, this is unfortunately a lower priority for us right now—we'll be sure to update you here when this is on our radar.

Of course! Totally get it. Please let us know when you guys have extra bandwidth on this.

@antoncoding antoncoding requested a review from a team as a code owner August 23, 2020 22:19
@darkwing
Copy link
Contributor

Thank you for the contribution @antoncoding ! At this time we prefer not to accept more USB-based hardware wallet solutions. If that changes, we'll be sure to let you know. Thank you!

@darkwing darkwing closed this Sep 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CoolWalletS hardware wallet.
3 participants