feat: hw signing tracker#43302
Open
montelaidev wants to merge 9 commits into
Open
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (6 files, +2016 -2)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [664a41e]
⚡ Performance Benchmarks (Total: 🟢 20 pass · 🟡 5 warn · 🔴 0 fail)
Bundle size diffs
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ddbd5ea. Configure here.
Contributor
Builds ready [17043d1]
⚡ Performance Benchmarks (Total: 🟢 19 pass · 🟡 6 warn · 🔴 0 fail)
Bundle size diffs [🚀 Bundle size reduced!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new hardware wallet signing tracker hook and improves retry logic for sequential hardware wallet signing.
Key changes:
Changelog
CHANGELOG entry: null
Related issues
Related to: https://consensyssoftware.atlassian.net/browse/MUL-1717
Manual testing steps
Not applicable
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches hardware-wallet swap submission and transaction abort/state-machine events; behavior is complex but isolated to new hook + retry path and heavily unit-tested, with UI not yet wired per PR notes.
Overview
Adds
useHwSignTracker, which listens toTransactionControllerevents for bridge/swap HW flows and drives the hardware-wallet signature state machine (FirstSignatureSubmitted,TransactionSubmitted, reject/fail). It supports batch tracking (batchId, STX-style) and sequential tracking (per tx id), filters stale batches/retries viaretryGenerationRef, and exposescancelCurrentBatchto callabortTransactionSigningwith guarded cleanup.useHwSwapSubmissiongains optionalfirstSignatureDoneRef: onretrySubmission, approval is omitted from the submitted quote when the first signature is already done; the ref resets when the locked quoterequestIdchanges. The hook is exported from the hardware-wallets index with types. Large unit test coverage accompanies both areas.Reviewed by Cursor Bugbot for commit 17043d1. Bugbot is set up for automated code reviews on this repo. Configure here.