chore: upgrade MetaMask design system packages#43344
Open
georgewrmarshall wants to merge 3 commits into
Open
Conversation
georgewrmarshall
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
mm-token-exchange-service
Bot
added
the
team-design-system
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (3 files, +8 -8)
✅ @MetaMask/confirmations (13 files, +33 -33)
👨🔧 @MetaMask/core-extension-ux (7 files, +16 -16)
🫰 @MetaMask/core-platform (3 files, +20 -20)
🎨 @MetaMask/design-system-engineers (18 files, +143 -0)
📜 @MetaMask/policy-reviewers (4 files, +152 -0)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔄 @MetaMask/swaps-engineers (6 files, +42 -42)
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Linux CI LavaMoat binding removed
- Restored the missing @unrs/resolver-binding-linux-x64-gnu entry alongside the existing Darwin binding in lavamoat/build-system/policy.json for eslint-import-resolver-typescript>unrs-resolver.
Or push these changes by commenting:
@cursor push 979fded4a3
Preview (979fded4a3)
diff --git a/lavamoat/build-system/policy.json b/lavamoat/build-system/policy.json
--- a/lavamoat/build-system/policy.json
+++ b/lavamoat/build-system/policy.json
@@ -6905,7 +6905,8 @@
"process.versions.pnp": true
},
"packages": {
- "eslint-import-resolver-typescript>unrs-resolver>@unrs/resolver-binding-darwin-arm64": true
+ "eslint-import-resolver-typescript>unrs-resolver>@unrs/resolver-binding-darwin-arm64": true,
+ "eslint-import-resolver-typescript>unrs-resolver>@unrs/resolver-binding-linux-x64-gnu": true
}
},
"uri-js": {You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 825e326. Configure here.
georgewrmarshall
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
georgewrmarshall
force-pushed
the
codex/upgrade-design-system-v43
branch
from
4fcc7ee to
84df567
Compare
georgewrmarshall
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
georgewrmarshall
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [84df567]
⚡ Performance Benchmarks (Total: 🟢 19 pass · 🟡 6 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
georgewrmarshall
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
georgewrmarshall
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
georgewrmarshall
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
georgewrmarshall
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [80351e5] [reused from 84df567]
⚡ Performance Benchmarks (Total: 🟢 19 pass · 🟡 6 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
brianacnguyen
approved these changes
Jun 8, 2026
Contributor
Author
LavaMoat Policy ReviewPer the process in docs/lavamoat-policy-review-process.md, here is my analysis of the ContextThis PR upgrades New packages introduced into policyThree new package entries appear across all four build configs (
Summary
Everything looks in order. @policy-reviewers please take a look when you get a chance. |
Contributor
Author
|
Correction to my previous analysis: I stated that The floating-ui packages ( The capability analysis in my previous comment still stands. The globals requested are the same standard DOM layout APIs that any positioning library needs. |
DDDDDanica
approved these changes
Jun 9, 2026
OGPoyraz
approved these changes
Jun 9, 2026
davidmurdoch
approved these changes
Jun 9, 2026
n3ps
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the MetaMask Extension design system dependencies to the latest MetaMask Design System release line.
Release links:
Package updates:
@metamask/design-system-react:^0.23.1->^0.25.0@metamask/design-system-shared:^0.19.0->^0.21.0@metamask/design-system-tailwind-preset:^0.8.0->^0.9.0@metamask/design-tokens:^8.4.0->^8.5.0Release changes covered by this upgrade:
@metamask/design-system-react@0.24.0TextFieldFlashFilledicon support@metamask/design-system-react@0.25.0PopoverTextAreaTextFieldSearchFormTextField@metamask/design-system-shared@0.20.0@metamask/design-system-shared@0.21.0@metamask/design-system-tailwind-preset@0.9.0@metamask/design-tokens@8.5.0Repository changes:
package.jsonandyarn.lock@deprecatedJSDoc migration notices to legacyui/components/component-librarycomponents that now have MMDS React replacements:FormTextFieldHeaderBaseHelpTextLabelModalModalBodyModalContentModalFocusModalFooterModalHeaderModalOverlayPopoverPopoverHeaderSensitiveTextSkeletonTextFieldTextFieldSearchTextarea->TextAreaMigration review:
v24.13, satisfying the Node 20+ breaking change.isReactNodeRenderable,WarningAlternative,SuccessAlternative,InfoAlternative,TextAreaPropsShared,panGestureHandlerProps,HeaderBaseVariant, andBottomSheetHeaderVariant.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
yarn install.yarn lint:changedandyarn lint:tsc.Pre-merge author checklist
Pre-merge reviewer checklist
Validation run:
yarn lint:lockfile:dedupe:fixyarn allow-scripts autoyarn lavamoat:autoyarn lint:changed:fixyarn lint:tscgit diff --checkNotes:
yarn lint:changed:fixcompleted with one existing warning inui/components/component-library/modal-content/modal-content.tsxforreact-hooks/exhaustive-deps; no lint errors were reported.Note
Low Risk
Dependency and styling-token updates with generated policy/snapshot churn; no auth or transaction logic changes, though avatar background shifts are visible across many screens.
Overview
Bumps MetaMask Design System packages (
design-system-react0.25.0, shared, tailwind-preset, design-tokens) and refreshes yarn.lock, including newer @floating-ui versions pulled in by the React package.LavaMoat browserify policies (beta, experimental, flask, main) now allow
@floating-ui/react-domand its DOM/core subpackages for@metamask/design-system-react.Legacy
ui/components/component-libraryexports gain@deprecatedJSDoc with links to the matching@metamask/design-system-reactcomponents and migration docs (modal stack, popover, form fields, etc.)—behavior unchanged.Jest snapshots update because upgraded avatars use
bg-alternativeinstead ofbg-sectionfor fallback surfaces (accounts, bridge, confirmations, snaps, and related UI).Reviewed by Cursor Bugbot for commit 80351e5. Bugbot is set up for automated code reviews on this repo. Configure here.