You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactored test/e2e/tests/carousel/carousel.spec.ts to follow the Page Object Model by moving inline driver selectors and carousel logic into a new CarouselPage page object.
Added test/e2e/page-objects/pages/home/carousel.ts with methods for loading the carousel, navigating slides, checking title/description, dismissing slides, and asserting visibility/dismissability.
Replaced deprecated driver APIs in the carousel flow:
isElementPresent / isDescendantPresent → isElementPresentAndVisible for presence checks
manual absence assertions → assertElementNotPresent with guards for carousel/close-button checks
Removed raw selectors, assert, tinyDelayMs, and this.skip() from the spec; tests now skip gracefully when no carousel is rendered.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test/e2e/tests/carousel/carousel.spec.tsto follow the Page Object Model by moving inline driver selectors and carousel logic into a newCarouselPagepage object.test/e2e/page-objects/pages/home/carousel.tswith methods for loading the carousel, navigating slides, checking title/description, dismissing slides, and asserting visibility/dismissability.isElementPresent/isDescendantPresent→isElementPresentAndVisiblefor presence checksassertElementNotPresentwith guards for carousel/close-button checksassert,tinyDelayMs, andthis.skip()from the spec; tests now skip gracefully when no carousel is rendered.Files changed:
test/e2e/page-objects/pages/home/carousel.ts(new)test/e2e/tests/carousel/carousel.spec.tsChangelog
CHANGELOG entry: null
Related issues
Fixes: MMQA-1907
Manual testing steps
Confirm both tests pass:
renders slides and each visible slide has title and descriptiondismisses slides that are dismissable and hides the carousel when none remainVerify the spec no longer uses raw selectors or deprecated
isElementPresent/isDescendantPresentcalls.Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist