feat: drive RPC connection banner from NetworkConnectionBannerController (WPC-1014)#43361
feat: drive RPC connection banner from NetworkConnectionBannerController (WPC-1014)#43361cryptodev-2s wants to merge 4 commits into
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Builds ready [69b0db8]
⚡ Performance Benchmarks (Total: 🟢 21 pass · 🟡 2 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
69b0db8 to
f0e8235
Compare
Builds ready [f0e8235]
⚡ Performance Benchmarks (Total: 🟢 19 pass · 🟡 2 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
|
Policy update failed. You can review the logs or retry the policy update here |
|
@metamaskbot update-policies |
|
LavaMoat validation failed but no policy diffs were produced (the validation job may have crashed before generating diffs). Failed jobs:
|
The banner-rule logic that needed eTLD+1 grouping now lives in the NetworkConnectionBannerController package; nothing in the extension imports `getDomain` anymore.
The field was removed from the controller in the previous refactor — update the inline snapshot to match.
e72aeec to
6f2f25a
Compare
Builds ready [6f2f25a] [reused from f0e8235]
⚡ Performance Benchmarks (Total: 🟢 19 pass · 🟡 2 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Replaces the in-app duplicate of the RPC connection banner rule + 5s/30s timer escalation with the new `@metamask/network-connection-banner-controller`, registered in `metamask-controller` alongside ConnectivityController.
Wiring
Cleanup
Net diff: −1,728 LOC. UI behavior unchanged.
Core PR: MetaMask/core#9041
Changelog
CHANGELOG entry: null
Related issues
Fixes: WPC-1014
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist