fix: fix native tokens disapearing cp-13.35.0#43379
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
11faf75 to
9e58625
Compare
Prithpal-Sooriya
left a comment
There was a problem hiding this comment.
Nice work, happy to validate this tomorrow morning
Builds ready [9e58625]
⚡ Performance Benchmarks (Total: 🟢 22 pass · 🟡 1 warn · 🔴 0 fail)
Bundle size diffs
|
|
@metamaskbot update-policies |
27ed9aa
|
Policies updated. Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 👀 lavamoat/browserify/beta/policy.json changes differ from lavamoat/browserify/main/policy.json changes |
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (8 files, +16 -16)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
Description
core PR: MetaMask/core#9063
Changelog
CHANGELOG entry: fix native tokens disapearing
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
bug.mov
After
fix.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches asset balance/metadata merge logic on every RPC balance refresh; wrong behavior could hide tokens or stale metadata, but scope is a targeted upstream fix with LavaMoat lockfile alignment.
Overview
Patches
@metamask/assets-controller@8.3.2(via Yarn) and pins the extension to that patched build instead of8.3.1, backporting core#9063.The patch changes
RpcDataSourceso balance polls no longer push existing asset metadata back into the pipeline. Native assets only get a minimal chain stub when state has no valid decimals yet; ERC-20 and natives that already have good metadata are omitted from the RPCassetsInfopayload so repeated polls do not overwrite richer entries (e.g. from Accounts API) or drop native tokens from the UI. Decimals for display stay available through existing state viapickValidDecimals.LavaMoat policy keys are updated to reflect the nested dependency path change (
bridge-status-controller→keyring-controllerinstead of viaassets-controller).Reviewed by Cursor Bugbot for commit 27ed9aa. Bugbot is set up for automated code reviews on this repo. Configure here.