-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Expand file tree
/
Copy pathuseUpdateTransactionPayAmount.test.ts
More file actions
422 lines (335 loc) · 14 KB
/
useUpdateTransactionPayAmount.test.ts
File metadata and controls
422 lines (335 loc) · 14 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
import { merge } from 'lodash';
import { renderHookWithProvider } from '../../../../../util/test/renderWithProvider';
import { useUpdateTransactionPayAmount } from './useUpdateTransactionPayAmount';
import { simpleSendTransactionControllerMock } from '../../__mocks__/controllers/transaction-controller-mock';
import { transactionApprovalControllerMock } from '../../__mocks__/controllers/approval-controller-mock';
import { otherControllersMock } from '../../__mocks__/controllers/other-controllers-mock';
import {
updateAtomicBatchData,
updateTransaction,
} from '../../../../../util/transaction-controller';
import {
updateMoneyAccountDepositTokenAmount,
updateMoneyAccountWithdrawTokenAmount,
} from '../../../../UI/Money/utils/moneyAccountTransactions';
import {
TransactionMeta,
TransactionType,
} from '@metamask/transaction-controller';
import { useUpdateTokenAmount } from '../transactions/useUpdateTokenAmount';
import Logger from '../../../../../util/Logger';
import { useTransactionPayRequiredTokens } from './useTransactionPayData';
import { TransactionPayRequiredToken } from '@metamask/transaction-pay-controller';
import { Hex } from '@metamask/utils';
jest.mock('../../../../../util/transaction-controller');
jest.mock('../../../../UI/Money/utils/moneyAccountTransactions');
jest.mock('../transactions/useUpdateTokenAmount');
jest.mock('../../../../../util/Logger');
jest.mock('./useTransactionPayData');
const moneyAccountDepositMeta: Partial<TransactionMeta> = {
type: TransactionType.moneyAccountDeposit,
};
const moneyAccountWithdrawMeta: Partial<TransactionMeta> = {
type: TransactionType.moneyAccountWithdraw,
};
function runHook({
transactionMeta,
}: {
transactionMeta?: Partial<TransactionMeta>;
} = {}) {
return renderHookWithProvider(useUpdateTransactionPayAmount, {
state: merge(
{},
simpleSendTransactionControllerMock,
transactionApprovalControllerMock,
otherControllersMock,
transactionMeta
? {
engine: {
backgroundState: {
TransactionController: {
transactions: [transactionMeta],
},
},
},
}
: {},
),
});
}
describe('useUpdateTransactionPayAmount', () => {
const updateAtomicBatchDataMock = jest.mocked(updateAtomicBatchData);
const updateTransactionMock = jest.mocked(updateTransaction);
const updateMoneyAccountDepositTokenAmountMock = jest.mocked(
updateMoneyAccountDepositTokenAmount,
);
const updateMoneyAccountWithdrawTokenAmountMock = jest.mocked(
updateMoneyAccountWithdrawTokenAmount,
);
const useUpdateTokenAmountMock = jest.mocked(useUpdateTokenAmount);
const useTransactionPayRequiredTokensMock = jest.mocked(
useTransactionPayRequiredTokens,
);
const updateTokenAmountMock = jest.fn();
const loggerErrorMock = jest.mocked(Logger.error);
beforeEach(() => {
jest.resetAllMocks();
updateAtomicBatchDataMock.mockResolvedValue('0x0');
useUpdateTokenAmountMock.mockReturnValue({
updateTokenAmount: updateTokenAmountMock,
});
useTransactionPayRequiredTokensMock.mockReturnValue([]);
});
async function flushPromises() {
await Promise.resolve();
await Promise.resolve();
}
it('calls updateAtomicBatchData for each update returned from updateMoneyAccountDepositTokenAmount', async () => {
updateMoneyAccountDepositTokenAmountMock.mockResolvedValue([
{ nestedTransactionIndex: 0, transactionData: '0xaaaa' },
{ nestedTransactionIndex: 2, transactionData: '0xbbbb' },
]);
const { result } = runHook({ transactionMeta: moneyAccountDepositMeta });
result.current.updateTransactionPayAmount('1.23');
await flushPromises();
expect(updateMoneyAccountDepositTokenAmountMock).toHaveBeenCalledTimes(1);
expect(updateMoneyAccountDepositTokenAmountMock).toHaveBeenCalledWith(
expect.any(Object),
'1.23',
);
expect(updateAtomicBatchDataMock).toHaveBeenCalledTimes(2);
expect(updateAtomicBatchDataMock).toHaveBeenNthCalledWith(1, {
transactionId: expect.any(String),
transactionIndex: 0,
transactionData: '0xaaaa',
});
expect(updateAtomicBatchDataMock).toHaveBeenNthCalledWith(2, {
transactionId: expect.any(String),
transactionIndex: 2,
transactionData: '0xbbbb',
});
expect(updateTokenAmountMock).not.toHaveBeenCalled();
});
it('does not call updateAtomicBatchData when no updates are returned', async () => {
updateMoneyAccountDepositTokenAmountMock.mockResolvedValue([]);
const { result } = runHook({ transactionMeta: moneyAccountDepositMeta });
result.current.updateTransactionPayAmount('1.23');
await flushPromises();
expect(updateAtomicBatchDataMock).not.toHaveBeenCalled();
});
it('does not call updateMoneyAccountDepositTokenAmount when there is no transaction meta', async () => {
const { result } = renderHookWithProvider(useUpdateTransactionPayAmount, {
state: merge(
{},
transactionApprovalControllerMock,
otherControllersMock,
{
engine: {
backgroundState: {
TransactionController: { transactions: [] },
},
},
},
),
});
result.current.updateTransactionPayAmount('1.23');
await flushPromises();
expect(updateMoneyAccountDepositTokenAmountMock).not.toHaveBeenCalled();
expect(updateMoneyAccountWithdrawTokenAmountMock).not.toHaveBeenCalled();
expect(updateAtomicBatchDataMock).not.toHaveBeenCalled();
expect(updateTokenAmountMock).not.toHaveBeenCalled();
});
it('delegates to updateTokenAmount for transactions that are neither money account deposit nor withdraw', () => {
const { result } = runHook();
result.current.updateTransactionPayAmount('1.23');
expect(updateTokenAmountMock).toHaveBeenCalledWith('1.23');
expect(updateMoneyAccountDepositTokenAmountMock).not.toHaveBeenCalled();
expect(updateMoneyAccountWithdrawTokenAmountMock).not.toHaveBeenCalled();
expect(updateAtomicBatchDataMock).not.toHaveBeenCalled();
});
it('logs an error when updateAtomicBatchData rejects', async () => {
const error = new Error('boom');
updateAtomicBatchDataMock.mockRejectedValue(error);
updateMoneyAccountDepositTokenAmountMock.mockResolvedValue([
{ nestedTransactionIndex: 0, transactionData: '0xaaaa' },
]);
const { result } = runHook({ transactionMeta: moneyAccountDepositMeta });
result.current.updateTransactionPayAmount('1.23');
await flushPromises();
expect(loggerErrorMock).toHaveBeenCalledWith(
error,
expect.stringContaining(
'Failed to update transaction pay amount in nested transaction',
),
);
});
it('logs an error when updateMoneyAccountDepositTokenAmount rejects', async () => {
const error = new Error('rpc failure');
updateMoneyAccountDepositTokenAmountMock.mockRejectedValue(error);
const { result } = runHook({ transactionMeta: moneyAccountDepositMeta });
result.current.updateTransactionPayAmount('1.23');
await flushPromises();
expect(updateAtomicBatchDataMock).not.toHaveBeenCalled();
expect(loggerErrorMock).toHaveBeenCalledWith(
error,
expect.stringContaining('Failed to prepare Money Account deposit'),
);
});
it('calls updateAtomicBatchData for each update returned from updateMoneyAccountWithdrawTokenAmount', async () => {
updateMoneyAccountWithdrawTokenAmountMock.mockResolvedValue([
{ nestedTransactionIndex: 0, transactionData: '0xcccc' },
{ nestedTransactionIndex: 1, transactionData: '0xdddd' },
]);
const { result } = runHook({ transactionMeta: moneyAccountWithdrawMeta });
result.current.updateTransactionPayAmount('4.56');
await flushPromises();
expect(updateMoneyAccountWithdrawTokenAmountMock).toHaveBeenCalledTimes(1);
expect(updateMoneyAccountWithdrawTokenAmountMock).toHaveBeenCalledWith(
expect.any(Object),
'4.56',
);
expect(updateAtomicBatchDataMock).toHaveBeenCalledTimes(2);
expect(updateAtomicBatchDataMock).toHaveBeenNthCalledWith(1, {
transactionId: expect.any(String),
transactionIndex: 0,
transactionData: '0xcccc',
});
expect(updateAtomicBatchDataMock).toHaveBeenNthCalledWith(2, {
transactionId: expect.any(String),
transactionIndex: 1,
transactionData: '0xdddd',
});
expect(updateMoneyAccountDepositTokenAmountMock).not.toHaveBeenCalled();
expect(updateTokenAmountMock).not.toHaveBeenCalled();
});
it('does not call updateAtomicBatchData when withdraw updater returns no updates', async () => {
updateMoneyAccountWithdrawTokenAmountMock.mockResolvedValue([]);
const { result } = runHook({ transactionMeta: moneyAccountWithdrawMeta });
result.current.updateTransactionPayAmount('4.56');
await flushPromises();
expect(updateMoneyAccountWithdrawTokenAmountMock).toHaveBeenCalledTimes(1);
expect(updateAtomicBatchDataMock).not.toHaveBeenCalled();
});
it('logs an error when updateMoneyAccountWithdrawTokenAmount rejects', async () => {
const error = new Error('withdraw rpc failure');
updateMoneyAccountWithdrawTokenAmountMock.mockRejectedValue(error);
const { result } = runHook({ transactionMeta: moneyAccountWithdrawMeta });
result.current.updateTransactionPayAmount('4.56');
await flushPromises();
expect(updateAtomicBatchDataMock).not.toHaveBeenCalled();
expect(loggerErrorMock).toHaveBeenCalledWith(
error,
expect.stringContaining('Failed to prepare Money Account withdraw'),
);
});
describe('syncMoneyAccountDepositRequiredAssets', () => {
const TOKEN_ADDRESS_MOCK = '0xToken' as Hex;
const existingRequiredAsset = {
address: TOKEN_ADDRESS_MOCK,
amount: '0x0' as Hex,
standard: 'erc20',
};
const moneyAccountDepositMetaWithRequiredAssets = {
...moneyAccountDepositMeta,
requiredAssets: [existingRequiredAsset],
};
beforeEach(() => {
updateMoneyAccountDepositTokenAmountMock.mockResolvedValue([]);
useTransactionPayRequiredTokensMock.mockReturnValue([
{ decimals: 6 } as TransactionPayRequiredToken,
]);
});
it('calls updateTransaction with hex-encoded amount when requiredAssets exist', async () => {
const { result } = runHook({
transactionMeta: moneyAccountDepositMetaWithRequiredAssets,
});
result.current.updateTransactionPayAmount('1');
await flushPromises();
expect(updateTransactionMock).toHaveBeenCalledTimes(1);
expect(updateTransactionMock).toHaveBeenCalledWith(
expect.objectContaining({
requiredAssets: [{ ...existingRequiredAsset, amount: '0xf4240' }],
}),
'Money Account deposit: sync requiredAssets amount',
);
});
it('rounds fractional atomic amounts up before encoding', async () => {
const { result } = runHook({
transactionMeta: moneyAccountDepositMetaWithRequiredAssets,
});
result.current.updateTransactionPayAmount('1.0000005');
await flushPromises();
expect(updateTransactionMock).toHaveBeenCalledWith(
expect.objectContaining({
requiredAssets: [{ ...existingRequiredAsset, amount: '0xf4241' }],
}),
expect.any(String),
);
});
it('does not call updateTransaction when transactionMeta has no requiredAssets', async () => {
const { result } = runHook({ transactionMeta: moneyAccountDepositMeta });
result.current.updateTransactionPayAmount('1');
await flushPromises();
expect(updateTransactionMock).not.toHaveBeenCalled();
});
it('does not call updateTransaction when no required tokens are available', async () => {
useTransactionPayRequiredTokensMock.mockReturnValue([]);
const { result } = runHook({
transactionMeta: moneyAccountDepositMetaWithRequiredAssets,
});
result.current.updateTransactionPayAmount('1');
await flushPromises();
expect(updateTransactionMock).not.toHaveBeenCalled();
});
it('does not call updateTransaction when computed amount matches existing amount', async () => {
const { result } = runHook({
transactionMeta: {
...moneyAccountDepositMeta,
requiredAssets: [{ ...existingRequiredAsset, amount: '0xf4240' }],
},
});
result.current.updateTransactionPayAmount('1');
await flushPromises();
expect(updateTransactionMock).not.toHaveBeenCalled();
});
it('does not run sync logic for non-deposit transaction types', async () => {
updateMoneyAccountWithdrawTokenAmountMock.mockResolvedValue([]);
const { result } = runHook({
transactionMeta: {
...moneyAccountWithdrawMeta,
requiredAssets: [existingRequiredAsset],
},
});
result.current.updateTransactionPayAmount('1');
await flushPromises();
expect(updateTransactionMock).not.toHaveBeenCalled();
});
it('logs an error when updateTransaction throws', async () => {
const error = new Error('updateTransaction failed');
updateTransactionMock.mockImplementation(() => {
throw error;
});
const { result } = runHook({
transactionMeta: moneyAccountDepositMetaWithRequiredAssets,
});
result.current.updateTransactionPayAmount('1');
await flushPromises();
expect(loggerErrorMock).toHaveBeenCalledWith(
error,
'Failed to sync Money Account deposit requiredAssets amount',
);
});
it('still applies money account deposit updates after syncing requiredAssets', async () => {
updateMoneyAccountDepositTokenAmountMock.mockResolvedValue([
{ nestedTransactionIndex: 0, transactionData: '0xaaaa' },
]);
const { result } = runHook({
transactionMeta: moneyAccountDepositMetaWithRequiredAssets,
});
result.current.updateTransactionPayAmount('1');
await flushPromises();
expect(updateTransactionMock).toHaveBeenCalledTimes(1);
expect(updateAtomicBatchDataMock).toHaveBeenCalledTimes(1);
});
});
});