Skip to content

Commit 00fe075

Browse files
authored
fix: 13165 fix ledger blind sign error displayed not correctly (#16200)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR will fix issue #13165 This PR will upgrade @metamask/eth-ledger-keyring-bridge library to correctly handle the blind signing not enable error and user reject transaction error. This PR will wait library upgrade PR merged and release first. MetaMask/accounts#294 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #13165 ## **Manual testing steps** 1. Install MM Mobile 2. Recover from SRP 3. Add hardware wallet (Ledger Stax) 4. Add Ledger account from account list 5. Launch MM Test dApp 6. Connect with Ledger account 7. Disable blind signing on Ledger device 8. Sign typed data v4 9. Verify error ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 8423995 commit 00fe075

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@
188188
"@metamask/eth-hd-keyring": "^12.1.0",
189189
"@metamask/eth-json-rpc-filters": "^9.0.0",
190190
"@metamask/eth-json-rpc-middleware": "^17.0.1",
191-
"@metamask/eth-ledger-bridge-keyring": "^11.0.3",
191+
"@metamask/eth-ledger-bridge-keyring": "11.1.0",
192192
"@metamask/eth-query": "^4.0.0",
193193
"@metamask/eth-sig-util": "^8.0.0",
194194
"@metamask/eth-snap-keyring": "^13.0.0",

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5030,10 +5030,10 @@
50305030
"@metamask/utils" "^11.1.0"
50315031
uuid "^8.3.2"
50325032

5033-
"@metamask/eth-ledger-bridge-keyring@^11.0.3":
5034-
version "11.0.3"
5035-
resolved "https://registry.yarnpkg.com/@metamask/eth-ledger-bridge-keyring/-/eth-ledger-bridge-keyring-11.0.3.tgz#9b646626e833d553ce174e35d2f7217aee3253ce"
5036-
integrity sha512-eezvOIpBJi3XrClx3vPG6AfomoaG6FKUHsQ1o1H+L0Czj5n036TioubzYThx4PWI5+cWZCw4r8X8uGKdCkjAcw==
5033+
"@metamask/eth-ledger-bridge-keyring@11.1.0":
5034+
version "11.1.0"
5035+
resolved "https://registry.yarnpkg.com/@metamask/eth-ledger-bridge-keyring/-/eth-ledger-bridge-keyring-11.1.0.tgz#c454da2c32242aecaf9e91cc6244b96dd7dd041b"
5036+
integrity sha512-QS6BI57eeKpBqg6ngDIqrHKNMDklYjIGng454pI/bKbTGtbiN7SnIP0TtTJlo2fgm1l5s93AKrNwGRUNVQkBtQ==
50375037
dependencies:
50385038
"@ethereumjs/rlp" "^5.0.2"
50395039
"@ethereumjs/tx" "^5.4.0"

0 commit comments

Comments
 (0)