Commit 00fe075
authored
fix: 13165 fix ledger blind sign error displayed not correctly (#16200)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
This PR will fix issue #13165
This PR will upgrade @metamask/eth-ledger-keyring-bridge library to
correctly handle the blind signing not enable error and user reject
transaction error.
This PR will wait library upgrade PR merged and release first.
MetaMask/accounts#294
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Related issues**
Fixes: #13165
## **Manual testing steps**
1. Install MM Mobile
2. Recover from SRP
3. Add hardware wallet (Ledger Stax)
4. Add Ledger account from account list
5. Launch MM Test dApp
6. Connect with Ledger account
7. Disable blind signing on Ledger device
8. Sign typed data v4
9. Verify error
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.1 parent 8423995 commit 00fe075
2 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
| 191 | + | |
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5030 | 5030 | | |
5031 | 5031 | | |
5032 | 5032 | | |
5033 | | - | |
5034 | | - | |
5035 | | - | |
5036 | | - | |
| 5033 | + | |
| 5034 | + | |
| 5035 | + | |
| 5036 | + | |
5037 | 5037 | | |
5038 | 5038 | | |
5039 | 5039 | | |
| |||
0 commit comments