chore(nav): type wallet, asset, and settings shell navigators (Phase 3)

Author: weitingsun

app/components/Nav/Main/types/navigation.ts

@@ -0,0 +1,97 @@
+import type { NavigatorScreenParams } from '@react-navigation/native';
+import type { AssetViewParams } from '../../../Views/Asset/Asset.types';
+import type { TokenDetailsRouteParams } from '../../../UI/TokenDetails/constants/constants';
+import type {
+  CreatePriceAlertRouteParams,
+  PriceAlertRouteParams,
+} from '../../../UI/Assets/PriceAlerts/constants';
+import type { RevealPrivateCredentialParams } from '../../../Views/RevealPrivateCredential/RevealPrivateCredential.types';
+import type { NetworkDetailsViewParams } from '../../../Views/NetworksManagement/NetworkDetailsView/NetworkDetailsView.types';
+import type { ContactFormParams } from '../../../Views/Settings/Contacts/ContactForm.types';
+import type { NotificationSettingsSectionProps } from '../../../Views/Settings/NotificationsSettings/NotificationSettingsSection';
+import type { RegionSelectorParams } from '../../../Views/Modals/Modals.types';
+import type {
+  ManualBackupStep1Params,
+  ManualBackupStep2Params,
+} from '../../../Views/ManualBackupStep1/ManualBackupStep1.types';
+import type {
+  AccountBackupParams,
+  ManualBackupStep3Params,
+} from '../../../Views/AccountBackup/AccountBackup.types';
+
+/**
+ * Param list for screens inside `AssetStackFlow` (token details + alerts).
+ */
+// ParamListBase requires `type`; `interface` cannot satisfy it.
+// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
+export type AssetStackParamList = {
+  Asset: AssetViewParams | undefined;
+  SecurityTrust: TokenDetailsRouteParams & {
+    isPricePositive?: boolean;
+    useAmbientColor?: boolean;
+  };
+  CreatePriceAlert: CreatePriceAlertRouteParams;
+  ManagePriceAlerts: PriceAlertRouteParams;
+};
+
+/**
+ * Param list for screens inside `WalletTabStackFlow`.
+ */
+// ParamListBase requires `type`; `interface` cannot satisfy it.
+// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
+export type WalletTabStackParamList = {
+  WalletView: undefined;
+  RevealPrivateCredential: RevealPrivateCredentialParams | undefined;
+};
+
+/**
+ * `WalletTabHome` is registered with component `WalletTabStackFlow`, but many
+ * call sites still navigate with an intermediate `WalletTabStackFlow` screen.
+ * Include both the real stack screens and that nested form.
+ */
+// ParamListBase requires `type`; `interface` cannot satisfy it.
+// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
+export type WalletTabHomeParamList = WalletTabStackParamList & {
+  WalletTabStackFlow:
+    | NavigatorScreenParams<WalletTabStackParamList>
+    | undefined;
+};
+
+/**
+ * Param list for screens inside `SettingsFlow` (`SettingsView`).
+ */
+// ParamListBase requires `type`; `interface` cannot satisfy it.
+// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
+export type SettingsStackParamList = {
+  AccountsMenuView: undefined;
+  Settings: undefined;
+  GeneralSettings: undefined;
+  AdvancedSettings: { scrollToBottom?: boolean } | undefined;
+  NetworksManagement: undefined;
+  NetworkDetails: NetworkDetailsViewParams | undefined;
+  SDKSessionsManager: undefined;
+  SecuritySettings: undefined;
+  RampSettings: undefined;
+  RampActivationKeyForm: undefined;
+  RampHeadlessPlayground: undefined;
+  AesCryptoTestForm: undefined;
+  ExperimentalSettings: undefined;
+  CompanySettings: undefined;
+  DeveloperOptions: undefined;
+  ContactsSettings: undefined;
+  ContactForm: ContactFormParams | undefined;
+  RevealPrivateCredentialView: RevealPrivateCredentialParams | undefined;
+  WalletConnectSessionsView: undefined;
+  ResetPassword: undefined;
+  WalletRecovery: undefined;
+  AccountBackupStep1B: AccountBackupParams | undefined;
+  ManualBackupStep1: ManualBackupStep1Params | undefined;
+  ManualBackupStep2: ManualBackupStep2Params | undefined;
+  ManualBackupStep3: ManualBackupStep3Params;
+  EnterPasswordSimple: undefined;
+  NotificationsSettings: undefined;
+  NotificationSettingsSection: NotificationSettingsSectionProps['route']['params'];
+  BackupAndSyncSettings: undefined;
+  SettingsRegionSelector: RegionSelectorParams | undefined;
+  SnapsSettingsList: undefined;
+};

app/core/NavigationService/types.ts

@@ -18,6 +18,12 @@ import type { LedgerTransactionModalParams } from '../../components/UI/LedgerMod
 // Browser params
 import type { BrowserParams } from '../../components/Views/Browser/Browser.types';
 import type { ActivityDetailsParams } from '../../components/Views/ActivityDetails/ActivityDetails.types';
+import type {
+  AssetStackParamList,
+  SettingsStackParamList,
+  WalletTabHomeParamList,
+  WalletTabStackParamList,
+} from '../../components/Nav/Main/types/navigation';
 
 // Bridge params
 import type { BatchSellTokenSelectRouteParams } from '../../components/UI/Bridge/Views/BatchSellTokenSelect/types';
@@ -115,11 +121,6 @@ import type {
   AssetViewParams,
 } from '../../components/Views/Asset/Asset.types';
 import type { NftDetailsParams } from '../../components/Views/NftDetails/NftDetails.types';
-import type { TokenDetailsRouteParams } from '../../components/UI/TokenDetails/constants/constants';
-import type {
-  PriceAlertRouteParams,
-  CreatePriceAlertRouteParams,
-} from '../../components/UI/Assets/PriceAlerts/constants';
 
 // Stake params
 import type {
@@ -373,7 +374,7 @@ export type RootStackParamList = {
   WalletView: undefined;
   BrowserTabHome: BrowserParams | NestedNavigationParams | undefined;
   BrowserView: BrowserParams | undefined;
-  SettingsView: NestedNavigationParams | undefined;
+  SettingsView: NavigatorScreenParams<SettingsStackParamList> | undefined;
   DeprecatedNetworkDetails: undefined;
 
   // Ramp routes
@@ -605,7 +606,7 @@ export type RootStackParamList = {
   Settings: undefined;
   ContactsSettings: undefined;
   CompanySettings: undefined;
-  AdvancedSettings: undefined;
+  AdvancedSettings: SettingsStackParamList['AdvancedSettings'];
   ResetPassword: undefined;
   ContactForm: ContactFormParams | undefined;
   DeveloperOptions: undefined;
@@ -685,8 +686,10 @@ export type RootStackParamList = {
   SimpleWebview: SimpleWebviewParams | undefined;
 
   // Wallet routes
-  WalletTabHome: NestedNavigationParams | undefined;
-  WalletTabStackFlow: NestedNavigationParams | undefined;
+  WalletTabHome: NavigatorScreenParams<WalletTabHomeParamList> | undefined;
+  WalletTabStackFlow:
+    | NavigatorScreenParams<WalletTabStackParamList>
+    | undefined;
   WalletConnectSessionsView: undefined;
   DeFiFullView: undefined;
   NftFullView: undefined;
@@ -988,13 +991,10 @@ export type RootStackParamList = {
   ConfirmAddAsset: ConfirmAddAssetParams | undefined;
 
   // Asset detail stack routes (nested under the `Asset` navigator)
-  AssetStackFlow: NestedNavigationParams | undefined;
-  SecurityTrust: TokenDetailsRouteParams & {
-    isPricePositive?: boolean;
-    useAmbientColor?: boolean;
-  };
-  CreatePriceAlert: CreatePriceAlertRouteParams;
-  ManagePriceAlerts: PriceAlertRouteParams;
+  AssetStackFlow: NavigatorScreenParams<AssetStackParamList> | undefined;
+  SecurityTrust: AssetStackParamList['SecurityTrust'];
+  CreatePriceAlert: AssetStackParamList['CreatePriceAlert'];
+  ManagePriceAlerts: AssetStackParamList['ManagePriceAlerts'];
 
   // NFT detail routes
   NftDetails: NftDetailsParams;