chore: money account related code refactor (#29228)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->

## **Description**

Code cleanup and refactoring.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1228

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**
NA

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I've included tests if applicable
- [X] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes confirmation flow UI/enablement and how `accountOverride` is
set for money-account transactions; miswiring could block confirmations
or select the wrong funding account.
> 
> **Overview**
> Extracts money-account deposit/withdraw account-picking into a
dedicated `PayAccountSelector` component that reads the current
`accountOverride` and writes updates via
`TransactionPayController.setTransactionConfig`.
> 
> Updates `CustomAmountInfo` to optionally show this selector via a new
`supportAccountSelection` prop, and **blocks pay-token display and
confirm** until an account has been selected (i.e., no
`accountOverride`). Money-account deposit/withdraw info components now
enable this flag, and unit tests are updated/added to cover the new
selector behavior and wiring.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d7a71aa. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: jpuri

app/components/Views/confirmations/components/PayAccountSelector/PayAccountSelector.test.tsx

@@ -0,0 +1,206 @@
+import React, { act } from 'react';
+import { fireEvent } from '@testing-library/react-native';
+import { TransactionType } from '@metamask/transaction-controller';
+import { Hex } from '@metamask/utils';
+import { merge } from 'lodash';
+
+import Engine from '../../../../../core/Engine';
+import renderWithProvider from '../../../../../util/test/renderWithProvider';
+import { transactionApprovalControllerMock } from '../../__mocks__/controllers/approval-controller-mock';
+import { otherControllersMock } from '../../__mocks__/controllers/other-controllers-mock';
+import { simpleSendTransactionControllerMock } from '../../__mocks__/controllers/transaction-controller-mock';
+import { useTransactionMetadataRequest } from '../../hooks/transactions/useTransactionMetadataRequest';
+import { useTransactionAccountOverride } from '../../hooks/transactions/useTransactionAccountOverride';
+import PayAccountSelector from './PayAccountSelector';
+
+jest.mock('../../hooks/transactions/useTransactionMetadataRequest');
+jest.mock('../../hooks/transactions/useTransactionAccountOverride');
+
+jest.mock('../../../../../core/Engine', () => ({
+  context: {
+    TransactionPayController: {
+      setTransactionConfig: jest.fn(),
+    },
+  },
+}));
+
+jest.mock('../AccountSelector', () => {
+  const { TouchableOpacity, Text } = jest.requireActual('react-native');
+  return {
+    __esModule: true,
+    default: ({
+      onAccountSelected,
+      selectedAddress,
+      label,
+    }: {
+      onAccountSelected: (address: string) => void;
+      selectedAddress?: string;
+      label?: string;
+    }) => (
+      <TouchableOpacity
+        testID="account-selector"
+        onPress={() => onAccountSelected('0xSelectedAddress')}
+      >
+        <Text testID="account-selector-label">{label ?? 'To'}</Text>
+        <Text testID="account-selector-address">
+          {selectedAddress ?? 'No selection'}
+        </Text>
+      </TouchableOpacity>
+    ),
+  };
+});
+
+const useTransactionMetadataRequestMock = jest.mocked(
+  useTransactionMetadataRequest,
+);
+const useTransactionAccountOverrideMock = jest.mocked(
+  useTransactionAccountOverride,
+);
+
+const setTransactionConfigMock = jest.mocked(
+  Engine.context.TransactionPayController.setTransactionConfig,
+);
+
+function render() {
+  return renderWithProvider(<PayAccountSelector />, {
+    state: merge(
+      {},
+      simpleSendTransactionControllerMock,
+      transactionApprovalControllerMock,
+      otherControllersMock,
+    ),
+  });
+}
+
+describe('PayAccountSelector', () => {
+  beforeEach(() => {
+    jest.resetAllMocks();
+
+    useTransactionMetadataRequestMock.mockReturnValue({
+      id: 'mock-tx-id',
+      type: TransactionType.moneyAccountDeposit,
+      txParams: { from: '0x123' },
+    } as never);
+
+    useTransactionAccountOverrideMock.mockReturnValue(undefined);
+  });
+
+  it('returns null for non-money-account transactions', () => {
+    useTransactionMetadataRequestMock.mockReturnValue({
+      id: 'mock-tx-id',
+      type: TransactionType.simpleSend,
+      txParams: { from: '0x123' },
+    } as never);
+
+    const { queryByTestId } = render();
+    expect(queryByTestId('account-selector')).toBeNull();
+  });
+
+  it('renders with no pre-selected address when accountOverride is undefined', () => {
+    const { getByTestId } = render();
+
+    expect(getByTestId('account-selector-address')).toHaveTextContent(
+      'No selection',
+    );
+  });
+
+  it('renders with pre-selected address from accountOverride', () => {
+    useTransactionAccountOverrideMock.mockReturnValue(
+      '0xOverrideAddress' as Hex,
+    );
+
+    const { getByTestId } = render();
+
+    expect(getByTestId('account-selector-address')).toHaveTextContent(
+      '0xOverrideAddress',
+    );
+  });
+
+  it('shows "From" label for deposit transactions', () => {
+    const { getByTestId } = render();
+
+    expect(getByTestId('account-selector-label')).toHaveTextContent('From');
+  });
+
+  it('shows default "To" label for withdraw transactions', () => {
+    useTransactionMetadataRequestMock.mockReturnValue({
+      id: 'mock-tx-id',
+      type: TransactionType.moneyAccountWithdraw,
+      txParams: { from: '0x123' },
+    } as never);
+
+    const { getByTestId } = render();
+
+    expect(getByTestId('account-selector-label')).toHaveTextContent('To');
+  });
+
+  it('calls setTransactionConfig with accountOverride on account selection', async () => {
+    const { getByTestId } = render();
+
+    await act(async () => {
+      fireEvent.press(getByTestId('account-selector'));
+    });
+
+    expect(setTransactionConfigMock).toHaveBeenCalledWith(
+      'mock-tx-id',
+      expect.any(Function),
+    );
+
+    const configCallback = setTransactionConfigMock.mock.calls[0][1];
+    const config = {} as { accountOverride?: Hex; isPostQuote?: boolean };
+    configCallback(config as never);
+
+    expect(config.accountOverride).toBe('0xSelectedAddress');
+  });
+
+  it('sets accountOverride for withdraw transactions', async () => {
+    useTransactionMetadataRequestMock.mockReturnValue({
+      id: 'mock-tx-id',
+      type: TransactionType.moneyAccountWithdraw,
+      txParams: { from: '0x123' },
+    } as never);
+
+    const { getByTestId } = render();
+
+    await act(async () => {
+      fireEvent.press(getByTestId('account-selector'));
+    });
+
+    const configCallback = setTransactionConfigMock.mock.calls[0][1];
+    const config = {} as { accountOverride?: Hex; isPostQuote?: boolean };
+    configCallback(config as never);
+
+    expect(config.accountOverride).toBe('0xSelectedAddress');
+    expect(config.isPostQuote).toBeUndefined();
+  });
+
+  it('does not set isPostQuote for deposit transactions', async () => {
+    const { getByTestId } = render();
+
+    await act(async () => {
+      fireEvent.press(getByTestId('account-selector'));
+    });
+
+    const configCallback = setTransactionConfigMock.mock.calls[0][1];
+    const config = {} as { accountOverride?: Hex; isPostQuote?: boolean };
+    configCallback(config as never);
+
+    expect(config.accountOverride).toBe('0xSelectedAddress');
+    expect(config.isPostQuote).toBeUndefined();
+  });
+
+  it('does not call setTransactionConfig when transactionId is missing', async () => {
+    useTransactionMetadataRequestMock.mockReturnValue({
+      type: TransactionType.moneyAccountDeposit,
+      txParams: { from: '0x123' },
+    } as never);
+
+    const { getByTestId } = render();
+
+    await act(async () => {
+      fireEvent.press(getByTestId('account-selector'));
+    });
+
+    expect(setTransactionConfigMock).not.toHaveBeenCalled();
+  });
+});

app/components/Views/confirmations/components/PayAccountSelector/PayAccountSelector.tsx

@@ -0,0 +1,55 @@
+import React, { useCallback } from 'react';
+import { TransactionType } from '@metamask/transaction-controller';
+import { Hex } from '@metamask/utils';
+
+import { strings } from '../../../../../../locales/i18n';
+import Engine from '../../../../../core/Engine';
+import { useTransactionMetadataRequest } from '../../hooks/transactions/useTransactionMetadataRequest';
+import { useTransactionAccountOverride } from '../../hooks/transactions/useTransactionAccountOverride';
+import { hasTransactionType } from '../../utils/transaction';
+import AccountSelector from '../AccountSelector';
+
+const PayAccountSelector: React.FC = () => {
+  const transactionMeta = useTransactionMetadataRequest();
+  const transactionId = transactionMeta?.id;
+  const accountOverride = useTransactionAccountOverride();
+
+  const isMoneyAccountWithdraw = hasTransactionType(transactionMeta, [
+    TransactionType.moneyAccountWithdraw,
+  ]);
+  const isMoneyAccountDeposit = hasTransactionType(transactionMeta, [
+    TransactionType.moneyAccountDeposit,
+  ]);
+
+  const handleAccountSelected = useCallback(
+    (address: string) => {
+      if (transactionId) {
+        Engine.context.TransactionPayController.setTransactionConfig(
+          transactionId,
+          (config) => {
+            config.accountOverride = address as Hex;
+          },
+        );
+      }
+    },
+    [transactionId],
+  );
+
+  if (!isMoneyAccountDeposit && !isMoneyAccountWithdraw) {
+    return null;
+  }
+
+  const label = isMoneyAccountDeposit
+    ? strings('confirm.label.from')
+    : undefined;
+
+  return (
+    <AccountSelector
+      label={label}
+      selectedAddress={accountOverride}
+      onAccountSelected={handleAccountSelected}
+    />
+  );
+};
+
+export default PayAccountSelector;

app/components/Views/confirmations/components/PayAccountSelector/index.ts

@@ -0,0 +1 @@
+export { default } from './PayAccountSelector';