Skip to content

Commit 123bfc5

Browse files
docs: trim workflows:write comments
Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 2604bb4 commit 123bfc5

2 files changed

Lines changed: 5 additions & 12 deletions

File tree

.github/workflows/create-release-pr.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,8 @@ jobs:
109109
# - contents: write → push the release / version-bump / changelog branches
110110
# - pull_requests: write → open the release PRs
111111
# - members: read → auto-changelog --autoCategorize resolves PR author teams (read:org)
112-
# - workflows: write → this job cuts the release branch/PR itself from main, which can
113-
# genuinely carry .github/workflows/* differences relative to the
114-
# previous release branch (workflow files evolve on main between
115-
# release cuts). This is a real need, not just a timeout workaround
116-
# (contrast with update-release-changelog.yml).
112+
# - workflows: write → the release branch cut here comes from main and can genuinely
113+
# differ in .github/workflows/* from the previous release branch
117114
# OIDC works on every trigger, so no workflow_dispatch vs workflow_call token split is needed.
118115
- name: Get token
119116
id: get-token

.github/workflows/update-release-changelog.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,9 @@ jobs:
5757
# Mint a short-lived token via the token-exchange service (OIDC). It needs:
5858
# - contents: write → push the changelog branch
5959
# - pull_requests: write → open/update the changelog PR
60-
# - workflows: write → this step only ever pushes CHANGELOG.md, so no real workflow
61-
# file diff is expected here. We only need this permission due
62-
# to a GitHub API timeout bug: GitHub's push-protection check
63-
# still has to determine on every push whether workflow files
64-
# changed, and that check has been timing out and rejecting the
65-
# push outright (same bug class as actions/checkout#2287).
66-
# Holding the scope up front avoids the check entirely.
60+
# - workflows: write → workaround for a GitHub push-protection timeout bug on new
61+
# branch pushes (see actions/checkout#2287); this step never
62+
# actually touches workflow files.
6763
- name: Get token
6864
id: get-token
6965
uses: MetaMask/github-tools/.github/actions/get-token@v1

0 commit comments

Comments
 (0)