Skip to content

Commit 12fe393

Browse files
committed
remove unnecessary flag and code
1 parent 6fbb41f commit 12fe393

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

package.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
"name": "metamask",
33
"version": "8.4.0",
44
"private": true,
5+
"repository": {
6+
"type": "git",
7+
"url": "https://github.com/MetaMask/metamask-mobile.git"
8+
},
59
"scripts": {
610
"install:foundryup": "yarn mm-foundryup",
711
"anvil": "node_modules/.bin/anvil",
@@ -20,7 +24,7 @@
2024
"lint:clean": "rm -f .eslintcache",
2125
"lint:tsc": "NODE_OPTIONS='--max-old-space-size=12288' tsc --project ./tsconfig.json",
2226
"lint:changelog": "./scripts/lint-changelog.sh",
23-
"lint:changelog:rc": "auto-changelog validate --rc --prettier --repo https://github.com/MetaMask/metamask-mobile",
27+
"lint:changelog:rc": "auto-changelog validate --rc --prettier",
2428
"format": "prettier '**/*.{js,ts,tsx,json}' --write",
2529
"format:check": "prettier '**/*.{js,ts,tsx,json}' --check",
2630
"format:check:changed": "git diff --name-only --diff-filter=ACM HEAD~1 | { grep -E '\\.(js|ts|tsx|json)$' || true; } | xargs --no-run-if-empty prettier --check",

scripts/lint-changelog.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ set -euo pipefail
1414
# release/X.Y.Z, release/X.Y.Z-ota (release branches, incl. OTA hotfixes)
1515
# release-changelog/X.Y.Z[...] (the changelog-generation working branch)
1616
#
17-
# package.json has no "repository" field, so --repo is passed explicitly.
17+
# package.json's "repository" field supplies the repo URL automatically (Yarn
18+
# 3.x/Berry sets PROJECT_CWD, which @metamask/auto-changelog reads), so --repo
19+
# does not need to be passed explicitly here.
1820
#
1921
# --prettier tells the validator to expect the changelog in Prettier-formatted
2022
# Markdown (blank line after headings), which matches this repo's existing
@@ -23,8 +25,6 @@ set -euo pipefail
2325
# @metamask/auto-changelog's stringifier, which would otherwise force
2426
# reformatting the entire file's history to pass.
2527

26-
readonly REPO_URL='https://github.com/MetaMask/metamask-mobile'
27-
2828
branch="${GITHUB_HEAD_REF:-}"
2929
if [[ -z "$branch" ]]; then
3030
branch="${GITHUB_REF_NAME:-}"
@@ -41,4 +41,4 @@ else
4141
echo "Branch '${branch}' is not release-oriented: validating without --rc"
4242
fi
4343

44-
yarn auto-changelog validate --repo "$REPO_URL" --prettier "${rc_flag[@]+"${rc_flag[@]}"}"
44+
yarn auto-changelog validate --prettier "${rc_flag[@]+"${rc_flag[@]}"}"

0 commit comments

Comments
 (0)