fix: show realized PnL on closed perp feed rows

Author: zone-live

app/components/Views/SocialLeaderboard/FeedView/utils/mapFeedItem.test.ts

@@ -280,6 +280,40 @@ describe('mapFeedItem', () => {
     expect(result?.valueLabel).toContain('4,659');
   });
 
+  it('shows realized PnL for a closed perp exit when marginUsd is still non-zero', () => {
+    const result = mapFeedItem(
+      mockPerpFeedItem({
+        tokenSymbol: 'BTC',
+        currentValueUSD: undefined,
+        pnlValueUsd: undefined,
+        pnlPercent: undefined,
+        realizedPnl: 12_500,
+        marginUsd: 151_400,
+        positionAmount: 2.5,
+        perpPositionType: 'short',
+        perpLeverage: 9,
+        trades: [
+          {
+            direction: 'sell',
+            intent: 'exit',
+            tokenAmount: -2.5,
+            usdCost: -151_400,
+            timestamp: 1_700_000_500,
+            transactionHash: '0xhash',
+            classification: 'perp',
+            perpPositionType: 'short',
+            perpLeverage: 9,
+          },
+        ],
+      }),
+    );
+
+    expect(result?.action).toBe('closed');
+    expect(result?.hasValueData).toBe(true);
+    expect(result?.hasPnlData).toBe(true);
+    expect(result?.valueLabel).toContain('12,500');
+  });
+
   it('marks negative PnL as not positive', () => {
     const result = mapFeedItem(
       mockPerpFeedItem({ pnlValueUsd: -500, realizedPnl: -500 }),

app/components/Views/SocialLeaderboard/FeedView/utils/mapFeedItem.ts

@@ -68,20 +68,30 @@ function findTriggeringTrade(
 }
 
 /**
- * Resolves the action verb for a feed row. Perp fills read as "opened"/"closed",
- * spot as "bought"/"sold" (mirrors `TradeRow`). When the position has no trade
- * to key off, falls back to the position's open/closed state.
+ * Feed rows are keyed off a triggering trade when one exists. Exit fills must
+ * use the closed presentation path (realized PnL) even when
+ * {@link isClosedPosition} misclassifies a perp that still carries stale
+ * non-zero margin in the Clicker payload.
  */
-function resolveAction(
+function isFeedItemClosed(
+  coreItem: CoreFeedItem,
   trade: Trade | undefined,
-  isPerp: boolean,
-  isClosed: boolean,
-): FeedAction {
-  const isExit = trade ? trade.intent === 'exit' : isClosed;
+): boolean {
+  if (trade?.intent === 'exit') {
+    return true;
+  }
+  return isClosedPosition(coreItem);
+}
+
+/**
+ * Resolves the action verb for a feed row. Perp fills read as "opened"/"closed",
+ * spot as "bought"/"sold" (mirrors `TradeRow`).
+ */
+function resolveAction(isPerp: boolean, isClosed: boolean): FeedAction {
   if (isPerp) {
-    return isExit ? 'closed' : 'opened';
+    return isClosed ? 'closed' : 'opened';
   }
-  return isExit ? 'sold' : 'bought';
+  return isClosed ? 'sold' : 'bought';
 }
 
 /**
@@ -286,9 +296,9 @@ export function mapFeedItem(coreItem: CoreFeedItem): FeedItem | null {
 
   const timestampMs = toMs(timestamp);
   const isPerp = isPerpPosition(coreItem);
-  const isClosed = isClosedPosition(coreItem);
   const trade = findTriggeringTrade(trades ?? [], timestampMs);
-  const action = resolveAction(trade, isPerp, isClosed);
+  const isClosed = isFeedItemClosed(coreItem, trade);
+  const action = resolveAction(isPerp, isClosed);
   const subHeader = buildSubHeader(trade);
   const presentation = buildFeedItemPresentation(coreItem, isClosed);