refactor(money): rename selector to selectWalletHomeOnboardingFlowVisible (MUSD-788)

Address review: clearer name for the wallet-home onboarding flow
visibility selector and its consumer; drop the explanatory comment.

Author: Kureev

app/components/UI/Money/components/MoneyBalanceCard/MoneyBalanceCard.test.tsx

@@ -7,7 +7,7 @@ import { strings } from '../../../../../../locales/i18n';
 import Routes from '../../../../../constants/navigation/Routes';
 import useMoneyAccountBalance from '../../hooks/useMoneyAccountBalance';
 import { selectMoneyOnboardingSeen } from '../../../../../reducers/user/selectors';
-import { selectInWalletHomeOnboardingFlow } from '../../../../../selectors/onboarding';
+import { selectWalletHomeOnboardingFlowVisible } from '../../../../../selectors/onboarding';
 import { useMoneyNavigation } from '../../hooks/useMoneyNavigation';
 
 const mockNavigate = jest.fn();
@@ -40,13 +40,13 @@ jest.mock('../../../../../reducers/user/selectors', () => ({
 
 jest.mock('../../../../../selectors/onboarding', () => ({
   __esModule: true,
-  selectInWalletHomeOnboardingFlow: jest.fn(),
+  selectWalletHomeOnboardingFlowVisible: jest.fn(),
 }));
 
 const mockUseMoneyAccountBalance = jest.mocked(useMoneyAccountBalance);
 const mockSelectMoneyOnboardingSeen = jest.mocked(selectMoneyOnboardingSeen);
-const mockSelectInWalletHomeOnboardingFlow = jest.mocked(
-  selectInWalletHomeOnboardingFlow,
+const mockSelectWalletHomeOnboardingFlowVisible = jest.mocked(
+  selectWalletHomeOnboardingFlowVisible,
 );
 const mockUseMoneyNavigation = jest.mocked(useMoneyNavigation);
 
@@ -87,7 +87,7 @@ describe('MoneyBalanceCard', () => {
     jest.clearAllMocks();
     mockUseMoneyAccountBalance.mockReturnValue(createBalanceMock());
     mockSelectMoneyOnboardingSeen.mockReturnValue(true);
-    mockSelectInWalletHomeOnboardingFlow.mockReturnValue(false);
+    mockSelectWalletHomeOnboardingFlowVisible.mockReturnValue(false);
     mockUseMoneyNavigation.mockReturnValue({
       navigateToMoneyHome: mockNavigateToMoneyHome,
     });
@@ -175,7 +175,7 @@ describe('MoneyBalanceCard', () => {
 
     describe('when the wallet-home onboarding stepper is not displayed', () => {
       beforeEach(() => {
-        mockSelectInWalletHomeOnboardingFlow.mockReturnValue(false);
+        mockSelectWalletHomeOnboardingFlowVisible.mockReturnValue(false);
       });
 
       it('renders the Earn button with the earn label', () => {
@@ -212,7 +212,7 @@ describe('MoneyBalanceCard', () => {
 
     describe('when the wallet-home onboarding stepper is displayed', () => {
       beforeEach(() => {
-        mockSelectInWalletHomeOnboardingFlow.mockReturnValue(true);
+        mockSelectWalletHomeOnboardingFlowVisible.mockReturnValue(true);
       });
 
       it('renders the Get started button with the get_started label', () => {

app/components/UI/Money/components/MoneyBalanceCard/MoneyBalanceCard.tsx

@@ -26,7 +26,7 @@ import { strings } from '../../../../../../locales/i18n';
 import Routes from '../../../../../constants/navigation/Routes';
 import { useStyles } from '../../../../../component-library/hooks';
 import { selectMoneyOnboardingSeen } from '../../../../../reducers/user/selectors';
-import { selectInWalletHomeOnboardingFlow } from '../../../../../selectors/onboarding';
+import { selectWalletHomeOnboardingFlowVisible } from '../../../../../selectors/onboarding';
 import useMoneyAccountBalance from '../../hooks/useMoneyAccountBalance';
 import styleSheet from './MoneyBalanceCard.styles';
 import { MoneyBalanceCardTestIds } from './MoneyBalanceCard.testIds';
@@ -47,8 +47,8 @@ const MoneyBalanceCard = () => {
   } = useMoneyAccountBalance();
   const { navigateToMoneyHome } = useMoneyNavigation();
   const hasSeenMoneyOnboarding = useSelector(selectMoneyOnboardingSeen);
-  const inWalletHomeOnboardingFlow = useSelector(
-    selectInWalletHomeOnboardingFlow,
+  const walletHomeOnboardingFlowVisible = useSelector(
+    selectWalletHomeOnboardingFlowVisible,
   );
 
   const isEmpty = totalFiatRaw === undefined || totalFiatRaw === '0';
@@ -62,7 +62,7 @@ const MoneyBalanceCard = () => {
   if (isNewUser) {
     balanceText = EMPTY_BALANCE_DISPLAY;
     containerTestId = MoneyBalanceCardTestIds.NEW_USER_CONTAINER;
-    if (inWalletHomeOnboardingFlow) {
+    if (walletHomeOnboardingFlowVisible) {
       buttonVariant = ButtonVariant.Secondary;
       buttonLabel = strings('homepage.sections.money_empty_state.get_started');
       buttonTestId = MoneyBalanceCardTestIds.GET_STARTED_BUTTON;

app/selectors/onboarding/index.test.ts

@@ -5,7 +5,7 @@ import {
   selectWalletHomeOnboardingSteps,
   selectWalletHomeOnboardingStepsEligible,
   selectShouldShowWalletHomeOnboardingSteps,
-  selectInWalletHomeOnboardingFlow,
+  selectWalletHomeOnboardingFlowVisible,
 } from '.';
 import { RootState } from '../../reducers';
 import { AccountType } from '../../constants/onboarding';
@@ -107,7 +107,7 @@ describe('Onboarding selectors', () => {
     });
   });
 
-  describe('selectInWalletHomeOnboardingFlow', () => {
+  describe('selectWalletHomeOnboardingFlowVisible', () => {
     // shouldShow comes from selectShouldShowWalletHomeOnboardingSteps:
     // eligible && steps.suppressedReason === null.
     const stateWithShouldShow = (shouldShow: boolean) =>
@@ -126,33 +126,33 @@ describe('Onboarding selectors', () => {
     it('is true when all three inputs are true', () => {
       mockSelectHomepageSectionsV1Enabled.mockReturnValue(true);
       mockSelectWalletHomeOnboardingStepsEnabled.mockReturnValue(true);
-      expect(selectInWalletHomeOnboardingFlow(stateWithShouldShow(true))).toBe(
-        true,
-      );
+      expect(
+        selectWalletHomeOnboardingFlowVisible(stateWithShouldShow(true)),
+      ).toBe(true);
     });
 
     it('is false when sectionsV1 is false', () => {
       mockSelectHomepageSectionsV1Enabled.mockReturnValue(false);
       mockSelectWalletHomeOnboardingStepsEnabled.mockReturnValue(true);
-      expect(selectInWalletHomeOnboardingFlow(stateWithShouldShow(true))).toBe(
-        false,
-      );
+      expect(
+        selectWalletHomeOnboardingFlowVisible(stateWithShouldShow(true)),
+      ).toBe(false);
     });
 
     it('is false when stepsEnabled is false', () => {
       mockSelectHomepageSectionsV1Enabled.mockReturnValue(true);
       mockSelectWalletHomeOnboardingStepsEnabled.mockReturnValue(false);
-      expect(selectInWalletHomeOnboardingFlow(stateWithShouldShow(true))).toBe(
-        false,
-      );
+      expect(
+        selectWalletHomeOnboardingFlowVisible(stateWithShouldShow(true)),
+      ).toBe(false);
     });
 
     it('is false when shouldShow is false', () => {
       mockSelectHomepageSectionsV1Enabled.mockReturnValue(true);
       mockSelectWalletHomeOnboardingStepsEnabled.mockReturnValue(true);
-      expect(selectInWalletHomeOnboardingFlow(stateWithShouldShow(false))).toBe(
-        false,
-      );
+      expect(
+        selectWalletHomeOnboardingFlowVisible(stateWithShouldShow(false)),
+      ).toBe(false);
     });
   });
 });

app/selectors/onboarding/index.ts

@@ -55,15 +55,9 @@ export const selectShouldShowWalletHomeOnboardingSteps = createSelector(
   (eligible, steps) => eligible && steps?.suppressedReason === null,
 );
 
-// Plain (non-memoized) composition: a module-load `createSelector(...)` would
-// dereference these imported selectors at evaluation time, and this module is
-// eagerly pulled in via `app/reducers/index.ts`. Any suite that builds a store
-// while partially mocking `featureFlagController/homepage` would then hit
-// reselect's "input-selectors must be functions" assertion at require time and
-// take down the whole file. Composing at call time keeps it mock/cycle-safe;
-// the body is a trivial boolean AND over already-memoized selectors, so there
-// is nothing to memoize.
-export const selectInWalletHomeOnboardingFlow = (state: RootState): boolean =>
+export const selectWalletHomeOnboardingFlowVisible = (
+  state: RootState,
+): boolean =>
   selectHomepageSectionsV1Enabled(state) &&
   selectWalletHomeOnboardingStepsEnabled(state) &&
   selectShouldShowWalletHomeOnboardingSteps(state);