small parameter refactor

Author: bergarces

app/components/UI/Assets/PriceAlerts/Views/CreatePriceAlertView/AbsolutePriceAlertForm.test.tsx

@@ -53,7 +53,6 @@ const baseProps: React.ComponentProps<typeof AbsolutePriceAlertForm> = {
   displayTicker: 'ETH',
   currentPrice: 1201.98,
   currentCurrency: 'USD',
-  isEditing: false,
 };
 
 const editingAlert: AbsolutePriceAlert = {
@@ -504,7 +503,6 @@ describe('AbsolutePriceAlertForm', () => {
   describe('editing', () => {
     const renderEditingForm = () =>
       renderForm({
-        isEditing: true,
         editingAlert,
         existingThresholds: [1500],
         fromManage: true,
@@ -713,7 +711,6 @@ describe('AbsolutePriceAlertForm', () => {
 
     it('tracks previous and updated threshold properties while editing', async () => {
       const screen = renderForm({
-        isEditing: true,
         editingAlert,
         existingThresholds: [1500],
         fromManage: true,

app/components/UI/Assets/PriceAlerts/Views/CreatePriceAlertView/AbsolutePriceAlertForm.tsx

@@ -38,7 +38,6 @@ interface AbsolutePriceAlertFormProps {
   currentPrice: number;
   currentCurrency: string;
   fromManage?: boolean;
-  isEditing: boolean;
   editingAlert?: AbsolutePriceAlert;
   existingThresholds?: number[];
 }
@@ -49,12 +48,12 @@ const AbsolutePriceAlertForm: React.FC<AbsolutePriceAlertFormProps> = ({
   currentPrice,
   currentCurrency,
   fromManage,
-  isEditing,
   editingAlert,
   existingThresholds,
 }) => {
   const tw = useTailwind();
   const { trackEvent, createEventBuilder } = useAnalytics();
+  const isEditing = Boolean(editingAlert);
   const [targetAmount, setTargetAmount] = useState(
     editingAlert ? toKeypadString(editingAlert.threshold) : KEYPAD_EMPTY,
   );
@@ -128,7 +127,7 @@ const AbsolutePriceAlertForm: React.FC<AbsolutePriceAlertFormProps> = ({
         threshold: targetPrice,
         recurring: isRecurring,
       });
-      if (isEditing && editingAlert) {
+      if (editingAlert) {
         patchAlertCache(editingAlert.id, {
           threshold: targetPrice,
           recurring: isRecurring,
@@ -175,7 +174,6 @@ const AbsolutePriceAlertForm: React.FC<AbsolutePriceAlertFormProps> = ({
     displayTicker,
     editingAlert,
     hasValidTarget,
-    isEditing,
     isRecurring,
     navigateAfterSave,
     patchAlertCache,

app/components/UI/Assets/PriceAlerts/Views/CreatePriceAlertView/CreatePriceAlertView.tsx

@@ -123,7 +123,6 @@ const CreatePriceAlertView: React.FC = () => {
             assetId={assetId}
             displayTicker={displayTicker}
             fromManage={fromManage}
-            isEditing={isEditing}
             editingAlert={editingPercentAlert}
             existingPercentAlerts={existingPercentAlerts}
           />
@@ -134,7 +133,6 @@ const CreatePriceAlertView: React.FC = () => {
             currentPrice={currentPrice}
             currentCurrency={currentCurrency}
             fromManage={fromManage}
-            isEditing={isEditing}
             editingAlert={editingAbsoluteAlert}
             existingThresholds={existingThresholds}
           />

app/components/UI/Assets/PriceAlerts/Views/CreatePriceAlertView/PercentChangeAlertForm.test.tsx

@@ -51,7 +51,6 @@ function WithToast({ children }: { children: React.ReactNode }) {
 const baseProps: React.ComponentProps<typeof PercentChangeAlertForm> = {
   assetId: 'eip155:1/slip44:60',
   displayTicker: 'ETH',
-  isEditing: false,
 };
 
 const editingPercentAlert: PercentChangeAlert = {
@@ -158,7 +157,6 @@ describe('PercentChangeAlertForm', () => {
 
   it('prepopulates edit values and locks immutable form controls', () => {
     const screen = renderForm({
-      isEditing: true,
       editingAlert: editingPercentAlert,
       existingPercentAlerts: [editingPercentAlert],
     });
@@ -179,7 +177,6 @@ describe('PercentChangeAlertForm', () => {
 
   it('updates a percent alert after recurrence changes', async () => {
     const screen = renderForm({
-      isEditing: true,
       editingAlert: editingPercentAlert,
       existingPercentAlerts: [editingPercentAlert],
     });

app/components/UI/Assets/PriceAlerts/Views/CreatePriceAlertView/PercentChangeAlertForm.tsx

@@ -43,7 +43,6 @@ interface PercentChangeAlertFormProps {
   assetId: string;
   displayTicker: string;
   fromManage?: boolean;
-  isEditing: boolean;
   editingAlert?: PercentChangeAlert;
   existingPercentAlerts?: PercentChangeAlert[];
 }
@@ -52,12 +51,12 @@ const PercentChangeAlertForm: React.FC<PercentChangeAlertFormProps> = ({
   assetId,
   displayTicker,
   fromManage,
-  isEditing,
   editingAlert,
   existingPercentAlerts,
 }) => {
   const tw = useTailwind();
   const { trackEvent, createEventBuilder } = useAnalytics();
+  const isEditing = Boolean(editingAlert);
   const [percentAmount, setPercentAmount] = useState(
     editingAlert ? toPercentKeypadString(editingAlert.threshold) : KEYPAD_EMPTY,
   );
@@ -127,7 +126,7 @@ const PercentChangeAlertForm: React.FC<PercentChangeAlertFormProps> = ({
         direction,
         recurring: isRecurring,
       });
-      if (isEditing && editingAlert) {
+      if (editingAlert) {
         patchAlertCache(editingAlert.id, {
           threshold: percentValue,
           recurring: isRecurring,
@@ -179,7 +178,6 @@ const PercentChangeAlertForm: React.FC<PercentChangeAlertFormProps> = ({
     displayTicker,
     editingAlert,
     hasValidPercent,
-    isEditing,
     isRecurring,
     navigateAfterSave,
     patchAlertCache,