Skip to content

Commit 1c7ae2d

Browse files
runway-github[bot]EtherWizard33EtherWizard22tommasini
authored
chore(runway): cherry-pick fix(15815): in TransactionElement componet, ticker displayed as undefined instead instead of ticker symbol. This is now fixed (#16308)
- fix(15815): in TransactionElement componet, ticker displayed as undefined instead instead of ticker symbol. This is now fixed (#16043) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Issue: the transaction detail was displaying undefined instead of the ticker. Solution: The solution is to remove the feature flag check since the fix works with both the feature flag on or off. (It was actually a bug fixed at the same time as delivering a feature (per-dapp-selected-networks) which was behind a feature flag, and in fact the bug or fix were not related or caused by the feauture in question). <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #15815 ## **Manual testing steps** 1. Do a dapp transaction 2. Go to the activity list, see one transaction and it's ticker is diplsaying as expected 3. Click one transaction in the list and confirm it's ticker is displaying as expected ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> | Before | After | |--------------|--------------| | <img width="350" alt="Screenshot 2024-04-18 at 3 56 43 PM" src="https://github.com/user-attachments/assets/515af9f7-7946-4892-96d1-2530ef025dc5"> |<img width="350" alt="Screenshot 2024-04-18 at 3 56 43 PM" src="https://github.com/user-attachments/assets/fe10056c-47f3-401c-8bd6-a1c2132e78c2"> | ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: EtherWizard33 <etherwizard22@gmail.com> [e3c7d63](e3c7d63) Co-authored-by: EtherWizard33 <165834542+EtherWizard33@users.noreply.github.com> Co-authored-by: EtherWizard33 <etherwizard22@gmail.com> Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
1 parent 6273417 commit 1c7ae2d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • app/components/UI/TransactionElement

app/components/UI/TransactionElement/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -703,7 +703,7 @@ const mapStateToProps = (state, ownProps) => ({
703703
primaryCurrency: selectPrimaryCurrency(state),
704704
swapsTransactions: selectSwapsTransactions(state),
705705
swapsTokens: swapsControllerTokens(state),
706-
ticker: isPerDappSelectedNetworkEnabled() ? selectTickerByChainId(state, ownProps.tx.chainId) : undefined,
706+
ticker: selectTickerByChainId(state, ownProps.tx.chainId),
707707
});
708708

709709
TransactionElement.contextType = ThemeContext;

0 commit comments

Comments
 (0)