refactor(settings): remove account menu feature flag and related code

Author: PatrykLucka

.github/scripts/known-feature-flag-constants.ts

@@ -13,7 +13,6 @@ const FILE_SOURCES: Array<{ key: string; file: string; exportName: string }> = [
   { key: 'TRON_REWARDS_FLAG_NAME', file: REWARDS_FILE, exportName: 'TRON_REWARDS_FLAG_NAME' },
   { key: 'SNAPSHOTS_REWARDS_FLAG_NAME', file: REWARDS_FILE, exportName: 'SNAPSHOTS_REWARDS_FLAG_NAME' },
   { key: 'MISSING_ENROLLED_ACCOUNTS_FLAG_NAME', file: REWARDS_FILE, exportName: 'MISSING_ENROLLED_ACCOUNTS_FLAG_NAME' },
-  { key: 'ACCOUNT_MENU_FLAG_KEY', file: sel('accountMenu'), exportName: 'ACCOUNT_MENU_FLAG_KEY' },
   { key: 'NETWORK_MANAGEMENT_FLAG_KEY', file: sel('networkManagement'), exportName: 'NETWORK_MANAGEMENT_FLAG_KEY' },
   // FEATURE_FLAG_NAME is omitted (non-unique across rwa / gasFeesSponsored); per-file fallback handles it.
   { key: 'OTA_UPDATES_FLAG_NAME', file: sel('otaUpdates'), exportName: 'OTA_UPDATES_FLAG_NAME' },

app/component-library/components/Navigation/TabBar/TabBar.test.tsx

@@ -15,7 +15,6 @@ import { backgroundState } from '../../../../util/test/initial-root-state';
 import TabBar from './TabBar';
 import { TabBarIconKey, ExtendedBottomTabDescriptor } from './TabBar.types';
 import Routes from '../../../../constants/navigation/Routes';
-import { useAccountMenuEnabled } from '../../../../selectors/featureFlagController/accountMenu/useAccountMenuEnabled';
 
 // Minimal descriptor interface for tests - only includes what TabBar component uses
 interface TestTabDescriptor {
@@ -30,14 +29,6 @@ interface TestDescriptors {
   [key: string]: TestTabDescriptor;
 }
 
-// Mock account menu feature flag hook
-jest.mock(
-  '../../../../selectors/featureFlagController/accountMenu/useAccountMenuEnabled',
-  () => ({
-    useAccountMenuEnabled: jest.fn(() => false),
-  }),
-);
-
 // Mock the navigation object with proper typing
 const navigation: NavigationHelpers<ParamListBase> = {
   navigate: jest.fn(),
@@ -129,10 +120,7 @@ describe('TabBar', () => {
     expect(toJSON()).toMatchSnapshot();
   });
 
-  it('navigates to the correct screen when a tab is pressed and account menu is disabled', () => {
-    // Explicitly disable the account menu feature flag for this test
-    jest.mocked(useAccountMenuEnabled).mockReturnValue(false);
-
+  it('navigates to the correct screen when a tab is pressed', () => {
     const { getByTestId } = renderWithProvider(
       <TabBar
         state={state as TabNavigationState<ParamListBase>}
@@ -168,7 +156,7 @@ describe('TabBar', () => {
 
     fireEvent.press(getByTestId(`tab-bar-item-${TabBarIconKey.Setting}`));
     expect(navigation.navigate).toHaveBeenCalledWith(Routes.SETTINGS_VIEW, {
-      screen: 'Settings',
+      screen: Routes.ACCOUNTS_MENU_VIEW,
     });
   });
 
@@ -230,23 +218,4 @@ describe('TabBar', () => {
     fireEvent.press(getByTestId(`tab-bar-item-${TabBarIconKey.Trending}`));
     expect(navigation.navigate).toHaveBeenCalledWith(Routes.TRENDING_VIEW);
   });
-
-  it('navigates to Accounts Menu when settings tab is pressed and account menu is enabled', () => {
-    // Enable the account menu feature flag for this test
-    jest.mocked(useAccountMenuEnabled).mockReturnValue(true);
-
-    const { getByTestId } = renderWithProvider(
-      <TabBar
-        state={state as TabNavigationState<ParamListBase>}
-        descriptors={descriptors as Record<string, ExtendedBottomTabDescriptor>}
-        navigation={navigation}
-      />,
-      { state: mockInitialState },
-    );
-
-    fireEvent.press(getByTestId(`tab-bar-item-${TabBarIconKey.Setting}`));
-    expect(navigation.navigate).toHaveBeenCalledWith(Routes.SETTINGS_VIEW, {
-      screen: Routes.ACCOUNTS_MENU_VIEW,
-    });
-  });
 });

app/component-library/components/Navigation/TabBar/TabBar.tsx

@@ -28,7 +28,6 @@ import {
   LABEL_BY_TAB_BAR_ICON_KEY,
 } from './TabBar.constants';
 import { selectChainId } from '../../../../selectors/networkController';
-import { useAccountMenuEnabled } from '../../../../selectors/featureFlagController/accountMenu/useAccountMenuEnabled';
 
 const FILLED_ICONS: Partial<Record<TabBarIconKey, IconName>> = {
   [TabBarIconKey.Wallet]: IconName.HomeFilled,
@@ -41,7 +40,6 @@ const TabBar = ({ state, descriptors, navigation }: TabBarProps) => {
   const { trackEvent, createEventBuilder } = useMetrics();
   const { bottom: bottomInset } = useSafeAreaInsets();
   const chainId = useSelector(selectChainId);
-  const isAccountMenuEnabled = useAccountMenuEnabled();
   const tabBarRef = useRef(null);
   const previousTabIndexRef = useRef<number>(state.index);
   const tw = useTailwind();
@@ -107,9 +105,7 @@ const TabBar = ({ state, descriptors, navigation }: TabBarProps) => {
             break;
           case Routes.SETTINGS_VIEW:
             navigation.navigate(Routes.SETTINGS_VIEW, {
-              screen: isAccountMenuEnabled
-                ? Routes.ACCOUNTS_MENU_VIEW
-                : 'Settings',
+              screen: Routes.ACCOUNTS_MENU_VIEW,
             });
             break;
           case Routes.TRENDING_VIEW:
@@ -146,7 +142,6 @@ const TabBar = ({ state, descriptors, navigation }: TabBarProps) => {
       trackEvent,
       createEventBuilder,
       tw,
-      isAccountMenuEnabled,
     ],
   );