You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/CONTRIBUTING.md
+5Lines changed: 5 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -11,6 +11,7 @@ There are also plenty of open issues we'd love help with. Search the [`good firs
11
11
If you're picking up a bounty or an existing issue, feel free to ask clarifying questions on the issue as you go about your work.
12
12
13
13
### Submitting a pull request
14
+
14
15
When you're done with your project / bugfix / feature and ready to submit a PR, there are a couple guidelines we ask you to follow:
15
16
16
17
-[ ]**Make sure you followed our [`coding guidelines`](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md)**: These guidelines aim to maintain consistency and readability across the codebase. They help ensure that the code is easy to understand, maintain, and modify, which is particularly important when working with multiple contributors.
@@ -23,4 +24,8 @@ When you're done with your project / bugfix / feature and ready to submit a PR,
23
24
-[ ]**Get the PR reviewed by code owners**: At least two code owner approvals are mandatory before merging any PR.
24
25
-[ ]**Ensure the PR is correctly labeled.**: More detail about labels definitions can be found [here](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md).
25
26
27
+
### Shadow CI jobs
28
+
29
+
CI jobs prefixed with `[shadow]` (e.g., from `ci-namespace-shadow.yml`) are **advisory only** and never gate merge. They run the same test suite on Namespace runners for performance benchmarking. If a shadow job fails, it does not indicate a problem with your PR -- it reflects the state of the Namespace runner migration trial.
Copy file name to clipboardExpand all lines: .github/actions/smart-e2e-selection/action.yml
+6-6Lines changed: 6 additions & 6 deletions
Original file line number
Diff line number
Diff line change
@@ -27,7 +27,7 @@ inputs:
27
27
required: false
28
28
default: 'false'
29
29
base-ref:
30
-
description: 'PR base branch ref passed to the AI analysis script for diff comparison. When release/*, AI selection is skipped and the full E2E suite is selected.'
30
+
description: 'PR base branch ref passed to the AI analysis script for diff comparison. When release/* or stable, AI selection is skipped and the full E2E suite is selected.'
31
31
required: false
32
32
default: ''
33
33
outputs:
@@ -57,15 +57,15 @@ runs:
57
57
echo "⏭️ SKIP=true due to 'skip-smart-e2e-selection' label on PR"
58
58
fi
59
59
60
-
- name: Check release target branch (full E2E, no AI selection)
60
+
- name: Check release or stable target branch (full E2E, no AI selection)
61
61
id: check-release-target
62
62
shell: bash
63
63
run: |
64
64
echo "SKIP=false" >> "$GITHUB_OUTPUT"
65
65
BASE='${{ inputs.base-ref }}'
66
-
if [[ -n "$BASE" && "$BASE" == release/* ]]; then
66
+
if [[ -n "$BASE" && ( "$BASE" == release/* || "$BASE" == "stable" ) ]]; then
67
67
echo "SKIP=true" >> "$GITHUB_OUTPUT"
68
-
echo "⏭️ Base branch is release/* — skipping AI E2E selection; full E2E suite will run"
68
+
echo "⏭️ Base branch is release/* or stable — skipping AI E2E selection; full E2E suite will run"
0 commit comments