fix: money account withdraw should not be enabled in case there is no quote

Author: jpuri

app/components/Views/confirmations/hooks/alerts/useNoPayTokenQuotesAlert.test.ts

@@ -13,6 +13,7 @@ import { strings } from '../../../../../../locales/i18n';
 import {
   useIsTransactionPayLoading,
   useTransactionPayFiatPayment,
+  useTransactionPayIsMaxAmount,
   useTransactionPayIsPostQuote,
   useTransactionPayQuotes,
   useTransactionPayRequiredTokens,
@@ -78,6 +79,7 @@ describe('useNoPayTokenQuotesAlert', () => {
     useTransactionPayIsPostQuoteMock.mockReturnValue(false);
     useTransactionPayRequiredTokensMock.mockReturnValue([]);
     jest.mocked(useTransactionPayFiatPayment).mockReturnValue(undefined);
+    jest.mocked(useTransactionPayIsMaxAmount).mockReturnValue(false);
   });
 
   it('returns alert if pay token selected and no quotes available', () => {
@@ -209,4 +211,78 @@ describe('useNoPayTokenQuotesAlert', () => {
       }),
     ]);
   });
+
+  // Money account withdraw MUSD -> MUSD: `calculatePostQuoteSourceAmounts`
+  // filters out same-token/same-chain entries, so `sourceAmounts` is empty
+  // even when the user has entered a positive amount. The alert must still
+  // fire so the Withdraw button stays disabled.
+  it('returns alert for post-quote when sourceAmounts is empty but a required token has a positive amount', () => {
+    useTransactionPayIsPostQuoteMock.mockReturnValue(true);
+    useTransactionPaySourceAmountsMock.mockReturnValue([]);
+    useTransactionPayQuotesMock.mockReturnValue([]);
+
+    useTransactionPayRequiredTokensMock.mockReturnValue([
+      {
+        address: ADDRESS_MOCK,
+        chainId: CHAIN_ID_MOCK,
+        amountRaw: '10000',
+        skipIfBalance: false,
+      } as TransactionPayRequiredToken,
+    ]);
+
+    const { result } = runHook();
+
+    expect(result.current).toEqual([
+      expect.objectContaining({
+        key: AlertKeys.NoPayTokenQuotes,
+        severity: Severity.Danger,
+        isBlocking: true,
+      }),
+    ]);
+  });
+
+  it('returns no alerts for post-quote with empty sourceAmounts when the required token amount is zero', () => {
+    useTransactionPayIsPostQuoteMock.mockReturnValue(true);
+    useTransactionPaySourceAmountsMock.mockReturnValue([]);
+    useTransactionPayQuotesMock.mockReturnValue([]);
+
+    useTransactionPayRequiredTokensMock.mockReturnValue([
+      {
+        address: ADDRESS_MOCK,
+        chainId: CHAIN_ID_MOCK,
+        amountRaw: '0',
+        skipIfBalance: false,
+      } as TransactionPayRequiredToken,
+    ]);
+
+    const { result } = runHook();
+
+    expect(result.current).toStrictEqual([]);
+  });
+
+  it('returns alert for post-quote with empty sourceAmounts when isMaxAmount is true', () => {
+    useTransactionPayIsPostQuoteMock.mockReturnValue(true);
+    useTransactionPaySourceAmountsMock.mockReturnValue([]);
+    useTransactionPayQuotesMock.mockReturnValue([]);
+    jest.mocked(useTransactionPayIsMaxAmount).mockReturnValue(true);
+
+    useTransactionPayRequiredTokensMock.mockReturnValue([
+      {
+        address: ADDRESS_MOCK,
+        chainId: CHAIN_ID_MOCK,
+        amountRaw: '0',
+        skipIfBalance: false,
+      } as TransactionPayRequiredToken,
+    ]);
+
+    const { result } = runHook();
+
+    expect(result.current).toEqual([
+      expect.objectContaining({
+        key: AlertKeys.NoPayTokenQuotes,
+        severity: Severity.Danger,
+        isBlocking: true,
+      }),
+    ]);
+  });
 });

app/components/Views/confirmations/hooks/alerts/useNoPayTokenQuotesAlert.ts

@@ -7,6 +7,7 @@ import { strings } from '../../../../../../locales/i18n';
 import {
   useIsTransactionPayLoading,
   useTransactionPayFiatPayment,
+  useTransactionPayIsMaxAmount,
   useTransactionPayIsPostQuote,
   useTransactionPayQuotes,
   useTransactionPayRequiredTokens,
@@ -21,6 +22,7 @@ export function useNoPayTokenQuotesAlert() {
   const sourceAmounts = useTransactionPaySourceAmounts();
   const requiredTokens = useTransactionPayRequiredTokens();
   const isPostQuote = useTransactionPayIsPostQuote();
+  const isMaxAmount = useTransactionPayIsMaxAmount();
 
   const fiatAmount = Number(fiatPayment?.amountFiat);
   const hasValidFiatAmount = Number.isFinite(fiatAmount) && fiatAmount > 0;
@@ -57,8 +59,29 @@ export function useNoPayTokenQuotesAlert() {
     sourceAmounts?.length === 0 &&
     quotes?.length === 0;
 
+  // Post-quote flows (e.g. money account withdraw MUSD -> MUSD) can end up with
+  // an empty `sourceAmounts` when the source and destination tokens match and
+  // get filtered out in `calculatePostQuoteSourceAmounts`. In that case the
+  // non-fiat branch above never fires, so we also emit the alert whenever the
+  // user has entered a positive input amount but no quote is available.
+  const hasPositiveRequiredAmount = (requiredTokens ?? []).some(
+    (t) =>
+      !t.skipIfBalance &&
+      (isMaxAmount || (Boolean(t.amountRaw) && t.amountRaw !== '0')),
+  );
+
+  const shouldShowPostQuoteNoQuotesAlert =
+    isPostQuote &&
+    Boolean(payToken) &&
+    !isQuotesLoading &&
+    !sourceAmounts?.length &&
+    !quotes?.length &&
+    hasPositiveRequiredAmount;
+
   const showAlert =
-    shouldShowNonFiatNoQuotesAlert || shouldShowFiatNoQuotesAlert;
+    shouldShowNonFiatNoQuotesAlert ||
+    shouldShowFiatNoQuotesAlert ||
+    shouldShowPostQuoteNoQuotesAlert;
 
   return useMemo(() => {
     if (!showAlert) {