perf: improve predict explore re-renders (#30135)

## **Description**

Reduce tab performance degredation in explore - optimise predict
rerenders.

From 60+ renders to 2/3

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: perf: improve predict explore re-renders

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

https://www.loom.com/share/96f8b59522674684a93076e6e8e7c4fc

### **After**

https://www.loom.com/share/34bffb5bcb59430286dac312e660d11e

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk refactor focused on render performance: it only restructures
how bet button press handlers are memoized and passed down, without
changing pricing/market logic or external APIs.
> 
> **Overview**
> Reduces re-renders in `PredictActionButtons` by extracting the
OPEN-market bet button rendering into a new `PredictBetButtonsContainer`
and memoizing `onYesPress`/`onNoPress` with `useCallback` (and the
optional `onDrawPress`).
> 
> This keeps the bet button UI/props the same while avoiding new inline
handler functions on each render.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
5dba77f. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: Prithpal-Sooriya

app/components/UI/Predict/components/PredictActionButtons/PredictActionButtons.tsx

@@ -1,4 +1,4 @@
-import React, { useMemo } from 'react';
+import React, { useCallback, useMemo } from 'react';
 import { Box } from '@metamask/design-system-react-native';
 import PredictBetButtons from './PredictBetButtons';
 import PredictClaimButton from './PredictClaimButton';
@@ -166,30 +166,60 @@ const PredictActionButtons: React.FC<PredictActionButtonsProps> = ({
   }
 
   if (market.status === PredictMarketStatus.OPEN && buttonConfig) {
-    const drawToken = buttonConfig.drawToken;
-
     return (
-      <Box twClassName="w-full mt-4">
-        <PredictBetButtons
-          yesLabel={buttonConfig.yesLabel}
-          yesPrice={buttonConfig.yesPrice}
-          onYesPress={() => onBetPress(buttonConfig.yesToken)}
-          drawLabel={buttonConfig.drawLabel}
-          drawPrice={buttonConfig.drawPrice}
-          onDrawPress={drawToken ? () => onBetPress(drawToken) : undefined}
-          noLabel={buttonConfig.noLabel}
-          noPrice={buttonConfig.noPrice}
-          onNoPress={() => onBetPress(buttonConfig.noToken)}
-          yesTeamColor={buttonConfig.yesTeamColor}
-          noTeamColor={buttonConfig.noTeamColor}
-          testID={`${testID}${PREDICT_ACTION_BUTTONS_TEST_IDS.PREDICT_BET_BUTTON}`}
-          isCarousel={isCarousel}
-        />
-      </Box>
+      <PredictBetButtonsContainer
+        buttonConfig={buttonConfig}
+        onBetPress={onBetPress}
+        testID={testID}
+        isCarousel={isCarousel}
+      />
     );
   }
 
   return null;
 };
 
+function PredictBetButtonsContainer(props: {
+  buttonConfig: ButtonConfig;
+  onBetPress: (token: PredictOutcomeToken) => void;
+  testID: string;
+  isCarousel?: boolean;
+}) {
+  const { buttonConfig, onBetPress, testID, isCarousel } = props;
+  const { yesToken, drawToken, noToken } = buttonConfig;
+
+  const onYesPress = useCallback(
+    () => onBetPress(yesToken),
+    [onBetPress, yesToken],
+  );
+  const onDrawPress = useMemo(
+    () => (drawToken ? () => onBetPress(drawToken) : undefined),
+    [onBetPress, drawToken],
+  );
+  const onNoPress = useCallback(
+    () => onBetPress(noToken),
+    [onBetPress, noToken],
+  );
+
+  return (
+    <Box twClassName="w-full mt-4">
+      <PredictBetButtons
+        yesLabel={buttonConfig.yesLabel}
+        yesPrice={buttonConfig.yesPrice}
+        onYesPress={onYesPress}
+        drawLabel={buttonConfig.drawLabel}
+        drawPrice={buttonConfig.drawPrice}
+        onDrawPress={onDrawPress}
+        noLabel={buttonConfig.noLabel}
+        noPrice={buttonConfig.noPrice}
+        onNoPress={onNoPress}
+        yesTeamColor={buttonConfig.yesTeamColor}
+        noTeamColor={buttonConfig.noTeamColor}
+        testID={`${testID}${PREDICT_ACTION_BUTTONS_TEST_IDS.PREDICT_BET_BUTTON}`}
+        isCarousel={isCarousel}
+      />
+    </Box>
+  );
+}
+
 export default PredictActionButtons;