fix(MUSD-747): no mount animation on education-seen path

Conditionally seed footerTranslateY and isStepperVisibleRef from
isStepperRendered. Previously both were unconditionally initialized
(translateY=240, ref=true), so on mount when education is already
seen the visibility-recompute effect saw next=false (no stepper) vs
ref.current=true and triggered a 300ms slide-in animation every
time the screen mounted post-education.

Lock the invariant via a withTiming spy: the education-seen path
must not call withTiming on mount or on the post-mount scroll
events. Tests previously missed this because withTiming is mocked
to resolve synchronously.

Addresses bugbot finding r3194824789.

Author: Kureev

app/components/UI/Money/Views/MoneyHomeView/MoneyHomeView.test.tsx

@@ -985,6 +985,8 @@ describe('MoneyHomeView', () => {
     });
 
     it('always renders the footer and never the stepper when education has been seen', () => {
+      mockWithTiming.mockClear();
+
       const { queryByTestId, getByTestId } = renderWithProvider(
         <MoneyHomeView />,
         { state: educationSeenState },
@@ -997,15 +999,21 @@ describe('MoneyHomeView', () => {
       expect(
         queryByTestId(MoneyOnboardingCardTestIds.CONTAINER),
       ).not.toBeOnTheScreen();
+      // The footer must render in its final visible position with NO
+      // mount animation. If withTiming fires here, the user sees an
+      // unwanted 300ms slide-in every time the screen mounts post-education.
+      expect(mockWithTiming).not.toHaveBeenCalled();
 
-      // Scroll events with the stepper absent must keep the footer visible.
+      // Scroll events with the stepper absent must keep the footer visible
+      // and must not trigger any animation (visibility ref starts in sync).
       const scrollView = getByTestId(MoneyHomeViewTestIds.SCROLL_VIEW);
       act(() => {
         fireScrollViewLayout(scrollView);
         fireScroll(scrollView, 0);
       });
 
       expect(queryByTestId(MoneyFooterTestIds.CONTAINER)).toBeOnTheScreen();
+      expect(mockWithTiming).not.toHaveBeenCalled();
     });
 
     it('keeps the footer translated off-screen when the stepper is below the viewport (off-screen, not yet scrolled to)', () => {

app/components/UI/Money/Views/MoneyHomeView/MoneyHomeView.tsx

@@ -231,7 +231,13 @@ const MoneyHomeView = () => {
   const [footerHeight, setFooterHeight] = useState(0);
 
   const isStepperRendered = !hasSeenMusdConversionEducation;
-  const footerTranslateY = useSharedValue(FOOTER_HIDDEN_OFFSET);
+  // Conditionally seed both shared value and visibility ref so the
+  // education-seen path renders the footer in its final position with NO
+  // mount animation. Otherwise the on-mount visibility-recompute effect
+  // would slide the footer in from FOOTER_HIDDEN_OFFSET → 0 every time.
+  const footerTranslateY = useSharedValue(
+    isStepperRendered ? FOOTER_HIDDEN_OFFSET : 0,
+  );
   const footerAnimatedStyle = useAnimatedStyle(() => ({
     transform: [{ translateY: footerTranslateY.value }],
   }));
@@ -240,11 +246,12 @@ const MoneyHomeView = () => {
     [footerHeight],
   );
 
-  // Default to "stepper visible" until layouts settle so the footer stays
-  // hidden in the initial paint and we avoid a brief flash of "Add money".
-  // Mirrored in a ref so the scroll-driven flip can compare without stale
-  // state and trigger the animation outside any setState updater.
-  const isStepperVisibleRef = useRef(true);
+  // Seed visibility tracking based on whether the stepper is rendered at all.
+  // - Stepper rendered: default to "visible" until layouts settle so the
+  //   footer stays hidden on initial paint and we avoid a flash of "Add money".
+  // - Stepper not rendered (education seen): default to "not visible" so the
+  //   on-mount visibility-recompute matches and produces no animation.
+  const isStepperVisibleRef = useRef(isStepperRendered);
 
   const computeStepperVisibility = useCallback(() => {
     // When the stepper isn't rendered, it can't obstruct the footer.