Skip to content

Commit 382f6b0

Browse files
chore: sentry cleanup: stop logging deeplinked URL parsing errors (#15121)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Remove Sentry error event dispatch on invalid URLs from deeplinks. Keep the event in the Sentry breadcrumbs. User is already being notified when there's an invalid URL from a deeplink, using the React Native Alert component ![Screenshot 2025-05-13 at 14 32 07](https://github.com/user-attachments/assets/64bd2a64-3368-4019-98a2-086c5190f92a) ## **Related issues** Fixes: #10027 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 3b33bf8 commit 382f6b0

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

app/core/DeeplinkManager/ParseManager/parseDeeplink.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,7 @@ function parseDeeplink({
9595
} catch (error) {
9696
const isPrivateKey = url.length === 64;
9797
if (error && !isPrivateKey) {
98-
Logger.error(
99-
error as Error,
98+
Logger.log(
10099
'DeepLinkManager:parse error parsing deeplink',
101100
);
102101
if (origin === AppConstants.DEEPLINKS.ORIGIN_QR_CODE) {

0 commit comments

Comments
 (0)