chore(runway): cherry-pick fix(MUSD-651): polish Cash & mUSD UI per latest designs cp-7.74.0 (#28996)

- fix(MUSD-651): polish Cash & mUSD UI per latest designs cp-7.74.0
(#28921)

## **Description**

Implements the four remaining MUSD-651 polish items on the Cash full
view, mUSD asset detail page, and home Cash section. Audit confirmed the
other ticket items (tooltip icon color, stablecoin tag
checkmarks/dark-mode fill, 3% bonus tag on home) already shipped in PRs
#28479, #28656, and #28718.

**Lifetime bonus formatting** — `AssetOverviewClaimBonus` now renders
`$0.00` in default text color until the user has actually claimed a
bonus, then switches to `+$X` in `SuccessDefault` green. Previously
always rendered `+$0.00` in green.

**Get mUSD CTA** — `MusdConversionAssetListCta` button promoted from
`Secondary` to `Primary` to match the white-on-dark Figma spec;
redundant inner `<Text>` color override dropped so the Button can drive
its own text color from the variant.

**Drop "Claim bonus" link from token rows** — `MusdAggregatedRow` (home
Cash section) and `TokenListItem` (mUSD per-network rows) no longer
render the blue "Claim bonus" affordance when a bonus is claimable. They
fall through to the green "3% bonus" label instead. The claim CTA still
lives on the mUSD asset detail page (`AssetOverviewClaimBonus`), which
is now the canonical claim entry point.

**Padding above "Convert your stablecoins"** — bumped top padding
(`pt-3`) inside `MoneyConvertStablecoins` so the divider isn't flush
with the title.

`MusdAggregatedRow` also dropped its now-unused `useMerklBonusClaim`,
`useNetworkName`, and analytics dependencies — the removed click handler
was the only reason the hook was called.

**Note:** claim bonus tag shape is addressed separately in [this
PR](#28903).

## **Changelog**

CHANGELOG entry: Polished Cash and mUSD bonus UI: lifetime bonus shows
zero state in white, "Get mUSD" CTA is now primary, blue "Claim bonus"
link removed from token rows.

## **Related issues**

Fixes: MUSD-651

## **Manual testing steps**

```gherkin
Feature: MUSD-651 Cash & mUSD UI polish

  Scenario: lifetime bonus shows zero state in white
    Given the user has never claimed an mUSD bonus
    When user opens the Cash full view from Home → Cash header
    Then the "Lifetime bonus claimed" row reads "$0.00" in default (white) text

  Scenario: lifetime bonus shows positive amount in green
    Given the user has previously claimed at least one mUSD bonus
    When user opens the Cash full view
    Then the "Lifetime bonus claimed" row reads "+$<amount>" in green

  Scenario: Get mUSD CTA is primary
    Given the user has no mUSD balance and is geo-eligible
    When user views the home wallet asset list
    Then the "Get mUSD" CTA renders as a primary (white-on-dark) button

  Scenario: Cash row never shows blue "Claim bonus" link
    Given the user has a claimable mUSD bonus on Linea
    When user views Home → Cash section
    Then the row shows green "3% bonus" text (no blue "Claim bonus" link)
    And tapping the row navigates to the Cash full view

  Scenario: token list mUSD rows never show "Claim bonus"
    Given the user holds mUSD across multiple chains with claimable rewards
    When user opens the Cash full view
    Then each mUSD row in the token list shows green "3% bonus" (no blue link)
    And the "Claim $X bonus" CTA on the asset detail "Your bonus" section still works

  Scenario: spacing above "Convert your stablecoins"
    Given the user is on the Cash full view
    When user scrolls to the "Convert your stablecoins" section
    Then there is visible breathing room between the divider line and the section title
```

## **Screenshots/Recordings**
<img width="1206" height="2622" alt="image"

src="https://github.com/user-attachments/assets/642d6690-5896-48ca-b01f-3d47b26a493b"
/>
<img width="1206" height="2622" alt="image"

src="https://github.com/user-attachments/assets/8d72bb20-608e-49d1-b694-a3624f485292"
/>


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
- [ ] I've tested with a power user scenario
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> UI/UX behavior changes around when/where users can claim mUSD bonuses
(removing claim affordances from token rows) plus token list rendering
tweaks could affect discoverability and row layout, but no core auth or
funds-transfer logic is modified.
> 
> **Overview**
> Polishes mUSD bonus presentation to match updated designs:
`AssetOverviewClaimBonus` now shows lifetime bonus as **`$0.00` in
default text** until a first claim, switching to **green `+$X`** only
when non-zero, and tests are updated accordingly.
> 
> Updates Cash and token list rows to stop showing the previous inline
*claim bonus* affordance: `TokenListItem` removes
`useMerklBonusClaim`/spinner/claim handling entirely and, when eligible,
renders a dedicated mUSD “`3% bonus`” row layout (hiding the price
rail), while `MusdAggregatedRow` standardizes the label to “`Claim 3%
bonus`” when claimable and uses the design-system spinner; analytics
properties are adjusted to match the new button text.
> 
> Small UI tweaks: promotes the “Get mUSD” asset-list CTA button to
`Primary` (letting the Button control text styling), adds top padding in
`MoneyConvertStablecoins`, and simplifies `TokenList` by removing
viewability state/props and dropping the `scrollToMerklRewards`
navigation param type.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
c6155a3. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
[775a207](775a207)

Co-authored-by: Alexey Kureev <a.g.kureev@gmail.com>

Author: runway-github[bot]

app/components/UI/Earn/components/AssetOverviewClaimBonus/AssetOverviewClaimBonus.test.tsx

@@ -319,7 +319,7 @@ describe('AssetOverviewClaimBonus', () => {
       ).toHaveTextContent('+$0.00');
       expect(
         getByTestId(ASSET_OVERVIEW_CLAIM_BONUS_TEST_IDS.LIFETIME_VALUE),
-      ).toHaveTextContent('+$0.00');
+      ).toHaveTextContent('$0.00');
     });
   });
 

app/components/UI/Earn/components/AssetOverviewClaimBonus/AssetOverviewClaimBonus.tsx

@@ -121,10 +121,11 @@ const AssetOverviewClaimBonus: React.FC<AssetOverviewClaimBonusProps> = ({
     ? `+$${estimatedAnnualBonus.toFixed(2)}`
     : '+$0.00';
 
-  // Lifetime bonus
-  const formattedLifetimeBonus = lifetimeBonusClaimed
+  // Lifetime bonus: white $0.00 until first claim, then green +$X.
+  const hasLifetimeBonus = Number(lifetimeBonusClaimed) > 0;
+  const formattedLifetimeBonus = hasLifetimeBonus
     ? `+$${lifetimeBonusClaimed}`
-    : '+$0.00';
+    : '$0.00';
 
   // CTA state
   const { ctaLabel, ctaDisabled } = useMemo(() => {
@@ -320,7 +321,11 @@ const AssetOverviewClaimBonus: React.FC<AssetOverviewClaimBonusProps> = ({
           <Text
             variant={TextVariant.BodyMd}
             fontWeight={FontWeight.Medium}
-            color={TextColor.SuccessDefault}
+            color={
+              hasLifetimeBonus
+                ? TextColor.SuccessDefault
+                : TextColor.TextDefault
+            }
             testID={ASSET_OVERVIEW_CLAIM_BONUS_TEST_IDS.LIFETIME_VALUE}
           >
             {formattedLifetimeBonus}

app/components/UI/Earn/components/Musd/MusdConversionAssetListCta/index.tsx

@@ -204,14 +204,12 @@ const MusdConversionAssetListCta = () => {
       </View>
 
       <Button
-        variant={ButtonVariant.Secondary}
+        variant={ButtonVariant.Primary}
         style={styles.button}
         onPress={() => handlePress(CTA_CLICK_TARGET.CTA_BUTTON)}
         size={ButtonSize.Sm}
       >
-        <Text variant={TextVariant.BodySMMedium} color={TextColor.Default}>
-          {buttonText}
-        </Text>
+        {buttonText}
       </Button>
     </View>
   );

app/components/UI/Money/components/MoneyConvertStablecoins/MoneyConvertStablecoins.tsx

@@ -136,7 +136,7 @@ const MoneyConvertStablecoins = ({
 
   return (
     <Box testID={MoneyConvertStablecoinsTestIds.CONTAINER}>
-      <Box twClassName="px-4">
+      <Box twClassName="px-4 pt-3">
         {!hasTokens && (
           <Box
             twClassName="mb-4"

app/components/UI/Tokens/TokenList/TokenList.tsx

@@ -1,12 +1,6 @@
-import React, {
-  useCallback,
-  useRef,
-  useMemo,
-  useEffect,
-  useState,
-} from 'react';
+import React, { useCallback, useRef, useMemo, useEffect } from 'react';
 import { DeviceEventEmitter, RefreshControl } from 'react-native';
-import { FlashList, FlashListRef, ViewToken } from '@shopify/flash-list';
+import { FlashList, FlashListRef } from '@shopify/flash-list';
 import { useSelector } from 'react-redux';
 import { useTheme } from '../../../../util/theme';
 import {
@@ -144,18 +138,6 @@ const TokenListComponent = ({
     [],
   );
 
-  // Track which items are currently visible in the viewport.
-  const [visibleKeys, setVisibleKeys] = useState<Set<string>>(new Set());
-
-  const handleViewableItemsChanged = useCallback(
-    ({ viewableItems }: { viewableItems: ViewToken<FlashListAssetKey>[] }) => {
-      setVisibleKeys(
-        new Set(viewableItems.map(({ item }) => getTokenKey(item))),
-      );
-    },
-    [getTokenKey],
-  );
-
   const renderTokenListItem = useCallback(
     ({ item }: { item: FlashListAssetKey }) => (
       <TokenListItem
@@ -166,7 +148,6 @@ const TokenListComponent = ({
         showPercentageChange={showPercentageChange}
         isFullView={isFullView}
         shouldShowTokenListItemCta={shouldShowTokenListItemCta}
-        isVisible={visibleKeys.has(getTokenKey(item))}
       />
     ),
     [
@@ -176,8 +157,6 @@ const TokenListComponent = ({
       showPercentageChange,
       isFullView,
       shouldShowTokenListItemCta,
-      visibleKeys,
-      getTokenKey,
     ],
   );
 
@@ -196,7 +175,6 @@ const TokenListComponent = ({
           showPercentageChange={showPercentageChange}
           isFullView={isFullView}
           shouldShowTokenListItemCta={shouldShowTokenListItemCta}
-          isVisible
         />
       ))}
       {shouldShowViewAllButton && (
@@ -219,11 +197,6 @@ const TokenListComponent = ({
         testID={WalletViewSelectorsIDs.TOKENS_CONTAINER_LIST}
         data={displayTokenKeys}
         removeClippedSubviews={false}
-        viewabilityConfig={{
-          itemVisiblePercentThreshold: 50,
-          minimumViewTime: 1000,
-        }}
-        onViewableItemsChanged={handleViewableItemsChanged}
         renderItem={renderTokenListItem}
         keyExtractor={(item, idx) => `${getTokenKey(item)}-${idx}`}
         refreshControl={
@@ -234,7 +207,7 @@ const TokenListComponent = ({
             onRefresh={onRefresh}
           />
         }
-        extraData={{ isTokenNetworkFilterEqualCurrentNetwork, visibleKeys }}
+        extraData={{ isTokenNetworkFilterEqualCurrentNetwork }}
         contentContainerStyle={!isFullView ? undefined : tw`px-4`}
         ListFooterComponent={
           isFullView && listFooterComponent ? (