Skip to content

Commit 3a5db6d

Browse files
authored
chore: Remove all bitrise artifacts (#30204)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR completely removes Bitrise from the app ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-260 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Medium risk because it removes Bitrise-triggered workflows/scripts and related build metadata handling, which could disrupt CI/build/release pipelines if any consumers still depend on them. > > **Overview** > Removes Bitrise-specific CI/E2E tooling and cleanup of remaining references, shifting fully to GitHub Actions-based build workflows. > > This deletes the Bitrise PR label/E2E gate scripts under `.github/scripts/bitrise/`, drops the associated workflow YAMLs (previously `.disabled`), and prunes Bitrise-only dependencies from `.github/scripts/package.json`/`yarn.lock`. It also removes Bitrise config hooks from `.detoxrc.js`, Gradle (Bitrise NDK path helper), version-bump workflow (`update-latest-build-version.yml` no longer stages `bitrise.yml`), and updates docs/comments/config filters/CODEOWNERS to stop treating `bitrise.yml` as a critical/owned/CI file. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 4cc0ebf. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent c35327c commit 3a5db6d

58 files changed

Lines changed: 54 additions & 6220 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.ai-pr-analyzer/config.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ critical:
2121
- android/settings.gradle
2222
- android/gradle.properties
2323
- android/app/build.gradle
24-
- bitrise.yml
2524
- builds.yml
2625
- .github/workflows/ci.yml
2726
- .github/workflows/build.yml

.detoxrc.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -100,15 +100,6 @@ module.exports = {
100100
forceAdbInstall: true,
101101
gpuMode: 'swiftshader_indirect',
102102
},
103-
'android.bitrise.emulator': {
104-
type: 'android.emulator',
105-
device: {
106-
avdName: 'emulator',
107-
},
108-
// optimized for Bitrise CI runners
109-
bootArgs: '-verbose -show-kernel -no-audio -netdelay none -no-snapshot -wipe-data -gpu auto -no-window -no-boot-anim -read-only',
110-
forceAdbInstall: true,
111-
}
112103
},
113104
apps: {
114105
'ios.debug': {

.github/CODEOWNERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ app/components/hooks/useMetrics/ @MetaMask/mobile-pla
2626
app/selectors/featureFlagController/* @MetaMask/mobile-platform
2727
app/selectors/featureFlagController/minimumAppVersion/ @MetaMask/mobile-platform
2828
app/store/migrations/ @MetaMask/mobile-platform
29-
bitrise.yml @MetaMask/mobile-platform
3029
ios/Podfile.lock @MetaMask/mobile-platform
3130
app/components/Views/BrowserTab/BrowserTab.tsx @MetaMask/mobile-platform
3231
app/components/Nav/NavigationProvider @MetaMask/mobile-platform

.github/rules/filter-rules.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ config_files: &config_files
4444
# CI/GITHUB FILES — overridden by e2e_related_workflows below
4545
ci_files: &ci_files
4646
- '.github/**'
47-
- 'bitrise.yml'
4847

4948
# ALL IGNORABLE FILES - safe to skip E2E
5049
e2e_ignorable:

.github/scripts/bitrise/.yarnrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

.github/scripts/bitrise/bitrise-results-check.ts

Lines changed: 0 additions & 85 deletions
This file was deleted.

0 commit comments

Comments
 (0)