test: reverts the patch in favor or Playwright-only Node shim

Author: christopherferreira9

.yarn/patches/@ethereumjs-util-npm-9.1.0-7e85509408.patch

@@ -2,14 +2,12 @@ diff --git a/dist/cjs/account.js b/dist/cjs/account.js
 index 9c7b96d50a1e1e9a08463e0be74f1462576b8b53..04f390b50c11a10b20971bccb46d212978c2ac89 100644
 --- a/dist/cjs/account.js
 +++ b/dist/cjs/account.js
-@@ -476,7 +476,9 @@ const pubToAddress = function (pubKey, sanitize = false) {
+@@ -476,7 +476,7 @@ const pubToAddress = function (pubKey, sanitize = false) {
      // Only take the lower 160bits of the hash
      return (0, keccak_js_1.keccak256)(pubKey).subarray(-20);
  };
 -exports.pubToAddress = pubToAddress;
-+let _nativeUtils;
-+try { _nativeUtils = require('@metamask/native-utils'); } catch (_) {}
-+exports.pubToAddress = (_nativeUtils && _nativeUtils.pubToAddress) || pubToAddress;
++exports.pubToAddress = require('@metamask/native-utils').pubToAddress;
  exports.publicToAddress = exports.pubToAddress;
  /**
   * Returns the ethereum public key of a given private key.

.yarn/patches/@metamask-key-tree-npm-10.1.1-0bfab435ac.patch

@@ -2,21 +2,20 @@ diff --git a/dist/curves/ed25519.cjs b/dist/curves/ed25519.cjs
 index 3f6b0951c046dbda89f18edb7f17e6d23b839fc5..d2aee95598d942c0219128a77f6f83abdf206b80 100644
 --- a/dist/curves/ed25519.cjs
 +++ b/dist/curves/ed25519.cjs
-@@ -14,6 +14,8 @@ const isValidPrivateKey = (_privateKey) => true;
+@@ -14,6 +14,7 @@ const isValidPrivateKey = (_privateKey) => true;
  exports.isValidPrivateKey = isValidPrivateKey;
  exports.deriveUnhardenedKeys = false;
  exports.publicKeyLength = 33;
-+let _nativeUtils;
-+try { _nativeUtils = require('@metamask/native-utils'); } catch (_) {}
++const nativeUtils = require('@metamask/native-utils')
  const getGetPublicKey = () => {
      let hasSetWindowSize = false;
      const getPublicKey = (privateKey, _compressed) => {
-@@ -21,7 +23,7 @@ const getGetPublicKey = () => {
+@@ -21,7 +22,7 @@ const getGetPublicKey = () => {
              ed25519_1.ed25519.ExtendedPoint.BASE._setWindowSize(4);
              hasSetWindowSize = true;
          }
 -        const publicKey = ed25519_1.ed25519.getPublicKey(privateKey);
-+        const publicKey = (_nativeUtils && _nativeUtils.getPublicKeyEd25519) ? _nativeUtils.getPublicKeyEd25519(privateKey) : ed25519_1.ed25519.getPublicKey(privateKey);
++        const publicKey = nativeUtils.getPublicKeyEd25519(privateKey);
          return (0, utils_1.concatBytes)([new Uint8Array([0]), publicKey]);
      };
      return getPublicKey;

tests/docs/README.md

@@ -5,6 +5,7 @@
 - [E2E Framework Structure](#e2e-framework-structure)
 - [Playwright: local emulator `buildPath` and app install](PLAYWRIGHT_LOCAL_EMULATOR.md)
 - [E2E Testing Best Practices](#e2e-testing-best-practices)
+- [Playwright Node Runtime Shims](#playwright-node-runtime-shims)
 - [E2E Test Examples and Patterns](#e2e-test-examples-and-patterns)
 - [E2E Testing Anti-Patterns (AVOID THESE)](#e2e-testing-anti-patterns-avoid-these)
 - [E2E Code Review Checklist](#e2e-code-review-checklist)
@@ -90,6 +91,15 @@ await withFixtures(
 - Default mocks are loaded from `tests/api-mocking/mock-responses/defaults/`
 - Feature flags mocked via `setupRemoteFeatureFlagsMock` helper
 
+## Playwright Node Runtime Shims
+
+Playwright specs and `FixtureBuilder` run in Node, while the app runs in React Native/Metro. If a native-only module fails during Playwright import or fixture setup, keep the app on the native implementation and isolate the Node workaround in test infrastructure.
+
+- Use `tests/framework/nodeNativeUtilsShim.cjs` for `@metamask/native-utils` in Playwright's Node process.
+- Register Node shims from Playwright framework entrypoints before importing code that may load native modules.
+- Do not add JS fallbacks to shared dependency patches unless the app runtime also needs them.
+- Validate with `yarn playwright test --list --project android --config tests/playwright.config.ts` before running devices.
+
 **Element State Configuration:**
 
 ```typescript

tests/framework/config/ConfigHandler.ts

@@ -1,4 +1,5 @@
 /* eslint-disable import-x/no-nodejs-modules */
+import '../nodeNativeUtilsShim.cjs';
 import path from 'path';
 import {
   defineConfig as defineConfigPlaywright,

tests/framework/fixture/index.ts

@@ -1,3 +1,4 @@
+import '../nodeNativeUtilsShim.cjs';
 import { test as base, type FullProject } from '@playwright/test';
 import {
   WebDriverConfig,

tests/framework/nodeNativeUtilsShim.cjs

@@ -0,0 +1,62 @@
+/* eslint-disable import-x/no-commonjs, import-x/no-nodejs-modules */
+/* global globalThis */
+/*
+ * Playwright runs FixtureBuilder in Node, but the mobile app resolves
+ * @metamask/native-utils through React Native/Metro. The native package is ESM
+ * and depends on react-native-nitro-modules, so CommonJS dependency patches
+ * cannot require it in the Playwright process. This shim only affects Node's
+ * CommonJS loader in the current process.
+ */
+const Module = require('module');
+const { secp256k1 } = require('@noble/curves/secp256k1');
+const { ed25519 } = require('@noble/curves/ed25519');
+const { hmac } = require('@noble/hashes/hmac');
+const { sha512 } = require('@noble/hashes/sha2');
+const { keccak_256: keccak256 } = require('@noble/hashes/sha3');
+
+const registerKey = Symbol.for('metamask.playwright.nativeUtilsNodeShim');
+
+const nativeUtilsMock = {
+  getPublicKey: secp256k1.getPublicKey,
+  getPublicKeyEd25519: ed25519.getPublicKey,
+  hmacSha512: (key, data) => hmac(sha512, key, data),
+  keccak256,
+  multiply: (a, b) => a * b,
+  pubToAddress: (pubKey, sanitize = false) => {
+    let key = pubKey;
+
+    if (sanitize && pubKey.length !== 64) {
+      key = secp256k1.ProjectivePoint.fromHex(pubKey)
+        .toRawBytes(false)
+        .slice(1);
+    }
+
+    if (key.length !== 64) {
+      throw new Error('Expected pubKey to be of length 64');
+    }
+
+    return keccak256(key).subarray(-20);
+  },
+};
+
+const existingRegistration = globalThis[registerKey];
+
+if (existingRegistration) {
+  module.exports = existingRegistration.nativeUtilsMock;
+} else {
+  const originalLoad = Module._load;
+
+  Module._load = function loadWithNativeUtilsShim(request, parent, isMain) {
+    if (request === '@metamask/native-utils') {
+      return nativeUtilsMock;
+    }
+
+    return originalLoad.call(this, request, parent, isMain);
+  };
+
+  globalThis[registerKey] = {
+    nativeUtilsMock,
+  };
+
+  module.exports = nativeUtilsMock;
+}

tests/performance/fixtures/test.spec.ts

@@ -12,59 +12,59 @@ import { remoteFeatureFlagHomepageSectionsV1Enabled } from '../../api-mocking/mo
 import { RampsRegions, RampsRegionsEnum } from '../../framework/Constants';
 import { LocalNodeType } from '../../framework';
 import { Hardfork } from '../../seeder/anvil-manager';
+import { Performance } from '../../tags.performance';
 
 /* Dummy test to test fixtures */
-test.skip('Test Fixtures', async ({
-  currentDeviceDetails,
-  driver,
-}, testInfo) => {
-  await withFixtures(
-    {
-      fixture: new FixtureBuilder()
-        .withPerpsProfile('no-positions')
-        .withPerpsFirstTimeUser(false)
-        .withNetworkController({
-          type: 'rpc',
-          chainId: '0xa4b1',
-          rpcUrl: 'https://arb1.arbitrum.io/rpc',
-          nickname: 'Arbitrum One',
-          ticker: 'ETH',
-        })
-        .withTokensForAllPopularNetworks([
+test.describe(Performance, () => {
+  test('Test Fixtures', async ({ currentDeviceDetails, driver }, testInfo) => {
+    await withFixtures(
+      {
+        fixture: new FixtureBuilder()
+          .withPerpsProfile('no-positions')
+          .withPerpsFirstTimeUser(false)
+          .withNetworkController({
+            type: 'rpc',
+            chainId: '0xa4b1',
+            rpcUrl: 'https://arb1.arbitrum.io/rpc',
+            nickname: 'Arbitrum One',
+            ticker: 'ETH',
+          })
+          .withTokensForAllPopularNetworks([
+            {
+              address: '0xff970a61a04b1ca14834a43f5de4533ebddb5cc8',
+              symbol: 'USDC',
+              decimals: 6,
+              name: 'USD Coin',
+              type: 'erc20',
+            },
+          ])
+          .withPopularNetworks()
+          .build(),
+        restartDevice: true,
+        currentDeviceDetails,
+        testSpecificMock: async (mockServer: Mockttp) => {
+          await setupRemoteFeatureFlagsMock(mockServer, {
+            ...remoteFeatureFlagHomepageSectionsV1Enabled(),
+          });
+          await PERPS_ARBITRUM_MOCKS(mockServer);
+          await mockPerpsGeolocation(
+            mockServer,
+            RampsRegions[RampsRegionsEnum.SPAIN],
+          );
+        },
+        localNodeOptions: [
           {
-            address: '0xff970a61a04b1ca14834a43f5de4533ebddb5cc8',
-            symbol: 'USDC',
-            decimals: 6,
-            name: 'USD Coin',
-            type: 'erc20',
+            type: LocalNodeType.anvil,
+            options: { hardfork: 'prague' as Hardfork },
           },
-        ])
-        .withPopularNetworks()
-        .build(),
-      restartDevice: true,
-      currentDeviceDetails,
-      testSpecificMock: async (mockServer: Mockttp) => {
-        await setupRemoteFeatureFlagsMock(mockServer, {
-          ...remoteFeatureFlagHomepageSectionsV1Enabled(),
-        });
-        await PERPS_ARBITRUM_MOCKS(mockServer);
-        await mockPerpsGeolocation(
-          mockServer,
-          RampsRegions[RampsRegionsEnum.SPAIN],
-        );
+        ],
       },
-      localNodeOptions: [
-        {
-          type: LocalNodeType.anvil,
-          options: { hardfork: 'prague' as Hardfork },
-        },
-      ],
-    },
-    async () => {
-      console.log('currentDeviceDetails', currentDeviceDetails);
-      await loginToAppPlaywright({ scenarioType: 'e2e' });
+      async () => {
+        console.log('currentDeviceDetails', currentDeviceDetails);
+        await loginToAppPlaywright({ scenarioType: 'e2e' });
 
-      // Add any actions you may want to test.
-    },
-  );
+        // Add any actions you may want to test.
+      },
+    );
+  });
 });

yarn.lock

@@ -3034,11 +3034,11 @@ __metadata:
 
 "@ethereumjs/util@patch:@ethereumjs/util@npm%3A9.1.0#~/.yarn/patches/@ethereumjs-util-npm-9.1.0-7e85509408.patch":
   version: 9.1.0
-  resolution: "@ethereumjs/util@patch:@ethereumjs/util@npm%3A9.1.0#~/.yarn/patches/@ethereumjs-util-npm-9.1.0-7e85509408.patch::version=9.1.0&hash=2510bd"
+  resolution: "@ethereumjs/util@patch:@ethereumjs/util@npm%3A9.1.0#~/.yarn/patches/@ethereumjs-util-npm-9.1.0-7e85509408.patch::version=9.1.0&hash=f1f3d0"
   dependencies:
     "@ethereumjs/rlp": "npm:^5.0.2"
     ethereum-cryptography: "npm:^2.2.1"
-  checksum: 10/5080e01285d05c8eb99b35df6940b44f1609bb56f6c71365d6f31dc5173b8e202d99e89c469ffa757aa5cdc577344051d5b8a43b3c4e12a29fface2d42f73eb5
+  checksum: 10/ab8e9ff226989daf026de6297932598f180de2306b6d059db628c1fdb5338d36dfa622a94c7a4d0f768a95975c31e526c5b12837ab6d1c322ce5d6888d40b398
   languageName: node
   linkType: hard
 
@@ -8913,14 +8913,14 @@ __metadata:
 
 "@metamask/key-tree@patch:@metamask/key-tree@npm%3A10.1.1#~/.yarn/patches/@metamask-key-tree-npm-10.1.1-0bfab435ac.patch":
   version: 10.1.1
-  resolution: "@metamask/key-tree@patch:@metamask/key-tree@npm%3A10.1.1#~/.yarn/patches/@metamask-key-tree-npm-10.1.1-0bfab435ac.patch::version=10.1.1&hash=7ecdc9"
+  resolution: "@metamask/key-tree@patch:@metamask/key-tree@npm%3A10.1.1#~/.yarn/patches/@metamask-key-tree-npm-10.1.1-0bfab435ac.patch::version=10.1.1&hash=40cbda"
   dependencies:
     "@metamask/scure-bip39": "npm:^2.1.1"
     "@metamask/utils": "npm:^11.0.1"
     "@noble/curves": "npm:^1.8.1"
     "@noble/hashes": "npm:^1.3.2"
     "@scure/base": "npm:^1.0.0"
-  checksum: 10/5af2d0347334a477ba6c00f29aece8308219ac339f919fa9ed26070cc1fab34b56e52ffb7b9c9e24942607204cf2c1465b92baea1904577e684401d7a6bdce4b
+  checksum: 10/27e41df10066976063d91cfa66fa5dd2c9e460afd12e79550f72eb94ddcd9d3b6603922a57614e128dfefc14f93dcfbf493067e4a20ae57a754516ca4ba3834d
   languageName: node
   linkType: hard