Skip to content

Commit 3ed0ccc

Browse files
pnarayanaswamypnarayanaswamy
committed
fix: address review comments
1 parent 7c9bf6d commit 3ed0ccc

2 files changed

Lines changed: 30 additions & 33 deletions

File tree

‎.github/CODEOWNERS‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,7 @@ tests/websocket/ @MetaMask/qa
353353
.github/workflows/run-performance-e2e.yml @MetaMask/qa
354354
.github/workflows/run-performance-e2e-experimental.yml @MetaMask/qa
355355
.github/workflows/run-performance-e2e-release.yml @MetaMask/qa
356+
.github/workflows/run-system-tests.yml @MetaMask/qa
356357
.github/scripts/e2e-*.mjs @MetaMask/qa
357358
.github/scripts/collect-qa-stats.mjs @MetaMask/qa
358359
.github/scripts/generate-regression-slack-summary.mjs @MetaMask/qa

‎.github/workflows/run-system-tests.yml‎

Lines changed: 29 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@
1111
name: Nightly System Tests
1212

1313
on:
14+
# TODO: Remove push trigger before merging to main
15+
push:
16+
branches:
17+
- run-system-tests
1418
schedule:
1519
- cron: '0 5 * * *' # 5 AM UTC daily
1620
workflow_dispatch:
@@ -40,18 +44,11 @@ concurrency:
4044
group: system-tests-${{ github.ref }}
4145
cancel-in-progress: true
4246
jobs:
43-
# ─────────────────────────────────────────────────────────────────────────
44-
# Phase 1 — Build apps via build.yml (same pipeline as nightly)
45-
# Builds are skipped when ANY manual BrowserStack URL is provided — the
46-
# user wants a quick test run with pre-built artifacts, not a 30 min build.
47-
# ─────────────────────────────────────────────────────────────────────────
48-
4947
build-with-srp:
5048
name: Build with-SRP (login tests)
5149
if: >-
52-
github.event_name == 'schedule'
53-
|| (github.event_name == 'workflow_dispatch'
54-
&& !inputs.browserstack_app_url_android
50+
github.event_name != 'workflow_dispatch'
51+
|| (!inputs.browserstack_app_url_android
5552
&& !inputs.browserstack_app_url_ios
5653
&& !inputs.browserstack_clean_app_url_android
5754
&& !inputs.browserstack_clean_app_url_ios)
@@ -66,9 +63,8 @@ jobs:
6663
build-clean:
6764
name: Build clean RC (onboarding tests)
6865
if: >-
69-
github.event_name == 'schedule'
70-
|| (github.event_name == 'workflow_dispatch'
71-
&& !inputs.browserstack_app_url_android
66+
github.event_name != 'workflow_dispatch'
67+
|| (!inputs.browserstack_app_url_android
7268
&& !inputs.browserstack_app_url_ios
7369
&& !inputs.browserstack_clean_app_url_android
7470
&& !inputs.browserstack_clean_app_url_ios)
@@ -96,28 +92,28 @@ jobs:
9692
steps:
9793
- name: Download Android APK (with-SRP)
9894
if: needs.build-with-srp.result == 'success'
99-
uses: actions/download-artifact@v4
95+
uses: actions/download-artifact@v8
10096
with:
10197
name: android-apk-main-rc-with-srp
10298
path: artifacts/android-with-srp
10399

104100
- name: Download iOS IPA (with-SRP)
105101
if: needs.build-with-srp.result == 'success'
106-
uses: actions/download-artifact@v4
102+
uses: actions/download-artifact@v8
107103
with:
108104
name: ios-ipa-main-rc-with-srp
109105
path: artifacts/ios-with-srp
110106

111107
- name: Download Android APK (clean)
112108
if: needs.build-clean.result == 'success'
113-
uses: actions/download-artifact@v4
109+
uses: actions/download-artifact@v8
114110
with:
115111
name: android-apk-main-rc
116112
path: artifacts/android-clean
117113

118114
- name: Download iOS IPA (clean)
119115
if: needs.build-clean.result == 'success'
120-
uses: actions/download-artifact@v4
116+
uses: actions/download-artifact@v8
121117
with:
122118
name: ios-ipa-main-rc
123119
path: artifacts/ios-clean
@@ -208,10 +204,10 @@ jobs:
208204
BROWSERSTACK_ANDROID_APP_URL: ${{ needs.upload-to-browserstack.outputs.android-login-url }}
209205
steps:
210206
- name: Checkout code
211-
uses: actions/checkout@v4
207+
uses: actions/checkout@v6
212208

213209
- name: Restore node_modules cache
214-
uses: actions/cache@v4
210+
uses: actions/cache@v6
215211
with:
216212
path: |
217213
node_modules
@@ -237,7 +233,7 @@ jobs:
237233

238234
- name: Restore .metamask folder
239235
id: restore-metamask
240-
uses: actions/cache@v4
236+
uses: actions/cache@v6
241237
with:
242238
path: .metamask
243239
key: .metamask-${{ hashFiles('package.json', 'yarn.lock') }}
@@ -287,7 +283,7 @@ jobs:
287283
run: yarn run-system-tests:android-login
288284

289285
- name: Upload test results
290-
uses: actions/upload-artifact@v4
286+
uses: actions/upload-artifact@v8
291287
if: always()
292288
with:
293289
name: system-test-report-android-login
@@ -306,10 +302,10 @@ jobs:
306302
BROWSERSTACK_ANDROID_CLEAN_APP_URL: ${{ needs.upload-to-browserstack.outputs.android-onboarding-url }}
307303
steps:
308304
- name: Checkout code
309-
uses: actions/checkout@v4
305+
uses: actions/checkout@v6
310306

311307
- name: Restore node_modules cache
312-
uses: actions/cache@v4
308+
uses: actions/cache@v6
313309
with:
314310
path: |
315311
node_modules
@@ -335,7 +331,7 @@ jobs:
335331

336332
- name: Restore .metamask folder
337333
id: restore-metamask
338-
uses: actions/cache@v4
334+
uses: actions/cache@v6
339335
with:
340336
path: .metamask
341337
key: .metamask-${{ hashFiles('package.json', 'yarn.lock') }}
@@ -385,7 +381,7 @@ jobs:
385381
run: yarn run-system-tests:android-onboarding
386382

387383
- name: Upload test results
388-
uses: actions/upload-artifact@v4
384+
uses: actions/upload-artifact@v8
389385
if: always()
390386
with:
391387
name: system-test-report-android-onboarding
@@ -404,10 +400,10 @@ jobs:
404400
BROWSERSTACK_IOS_APP_URL: ${{ needs.upload-to-browserstack.outputs.ios-login-url }}
405401
steps:
406402
- name: Checkout code
407-
uses: actions/checkout@v4
403+
uses: actions/checkout@v6
408404

409405
- name: Restore node_modules cache
410-
uses: actions/cache@v4
406+
uses: actions/cache@v6
411407
with:
412408
path: |
413409
node_modules
@@ -433,7 +429,7 @@ jobs:
433429

434430
- name: Restore .metamask folder
435431
id: restore-metamask
436-
uses: actions/cache@v4
432+
uses: actions/cache@v6
437433
with:
438434
path: .metamask
439435
key: .metamask-${{ hashFiles('package.json', 'yarn.lock') }}
@@ -483,7 +479,7 @@ jobs:
483479
run: yarn run-system-tests:ios-login
484480

485481
- name: Upload test results
486-
uses: actions/upload-artifact@v4
482+
uses: actions/upload-artifact@v8
487483
if: always()
488484
with:
489485
name: system-test-report-ios-login
@@ -502,10 +498,10 @@ jobs:
502498
BROWSERSTACK_IOS_CLEAN_APP_URL: ${{ needs.upload-to-browserstack.outputs.ios-onboarding-url }}
503499
steps:
504500
- name: Checkout code
505-
uses: actions/checkout@v4
501+
uses: actions/checkout@v6
506502

507503
- name: Restore node_modules cache
508-
uses: actions/cache@v4
504+
uses: actions/cache@v6
509505
with:
510506
path: |
511507
node_modules
@@ -531,7 +527,7 @@ jobs:
531527

532528
- name: Restore .metamask folder
533529
id: restore-metamask
534-
uses: actions/cache@v4
530+
uses: actions/cache@v6
535531
with:
536532
path: .metamask
537533
key: .metamask-${{ hashFiles('package.json', 'yarn.lock') }}
@@ -581,7 +577,7 @@ jobs:
581577
run: yarn run-system-tests:ios-onboarding
582578

583579
- name: Upload test results
584-
uses: actions/upload-artifact@v4
580+
uses: actions/upload-artifact@v8
585581
if: always()
586582
with:
587583
name: system-test-report-ios-onboarding
@@ -600,7 +596,7 @@ jobs:
600596
runs-on: ubuntu-latest
601597
steps:
602598
- name: Download all test reports
603-
uses: actions/download-artifact@v4
599+
uses: actions/download-artifact@v8
604600
with:
605601
pattern: system-test-report-*
606602
path: all-reports

0 commit comments

Comments
 (0)