cleanup

Author: n3ps

app/components/Views/UnifiedTransactionsView/UnifiedTransactionsView.test.tsx

@@ -422,7 +422,7 @@ describe('UnifiedTransactionsView with transactions', () => {
             accounts: {
               'evm-account-id': {
                 id: 'evm-account-id',
-                type: 'eip155:eoa',
+                type: 'eip155:eoa' as const,
                 address: ACTIVE_EVM_ADDRESS,
                 options: {},
                 methods: [],
@@ -448,7 +448,7 @@ describe('UnifiedTransactionsView with transactions', () => {
                 from: ACTIVE_EVM_ADDRESS,
                 to: '0x1111111111111111111111111111111111111111',
                 value: '0x0',
-                nonce: 1,
+                nonce: '0x1',
               },
             },
           ],

app/components/Views/UnifiedTransactionsView/helpers/adapters.ts

@@ -26,7 +26,10 @@ function resolveTransactionMetaType(
     return TransactionType.incoming;
   }
 
-  const data = transaction.methodId?.toLowerCase();
+  const rawData = transaction.methodId?.toLowerCase();
+  // Treat '0x' (empty calldata) the same as no methodId, since the API
+  // returns '0x' for simple ETH sends.
+  const data = rawData && rawData !== '0x' ? rawData : undefined;
 
   if (data && !transaction.to) {
     return TransactionType.deployContract;

app/components/Views/UnifiedTransactionsView/helpers/transformations.test.ts

@@ -28,15 +28,15 @@ describe('selectTransactions', () => {
       to: otherAddress,
       from: address,
       ...overrides,
-    } as unknown as V1TransactionByHashResponse);
+    }) as unknown as V1TransactionByHashResponse;
 
   const buildData = (
     transactions: V1TransactionByHashResponse[],
   ): InfiniteData<V4MultiAccountTransactionsResponse> =>
     ({
       pages: [{ data: transactions } as V4MultiAccountTransactionsResponse],
       pageParams: [undefined],
-    } as InfiniteData<V4MultiAccountTransactionsResponse>);
+    }) as InfiniteData<V4MultiAccountTransactionsResponse>;
 
   it('transforms transactions into view models with id and transactionMeta', () => {
     const tx = buildTransaction();

tests/helpers/swap/bridge-mocks.ts

@@ -126,11 +126,4 @@ export const testSpecificMock: TestSpecificMock = async (
     response: BRIDGE_TX_STATUS_COMPLETE,
     responseCode: 200,
   });
-
-  await setupMockRequest(mockServer, {
-    requestMethod: 'GET',
-    url: /api\.myx\.finance\/openapi\/gateway\/scan\/market/i,
-    response: {},
-    responseCode: 200,
-  });
 };