Skip to content

Commit 44e542b

Browse files
committed
update client-id to env vars
1 parent 56b6db3 commit 44e542b

1 file changed

Lines changed: 23 additions & 9 deletions

File tree

  • tests/module-mocking/oauth/OAuthLoginHandlers

tests/module-mocking/oauth/OAuthLoginHandlers/index.ts

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,22 @@ import {
1616
import type { BaseHandlerOptions } from '../../../../app/core/OAuthService/OAuthLoginHandlers/baseHandler';
1717

1818
const MOCK_GOOGLE_OAUTH_CLIENT_ID_IOS =
19-
'387141446914-5ja3p4dfanfkm8uq238fm1b8t1rkscv4.apps.googleusercontent.com';
19+
process.env.MAIN_IOS_GOOGLE_CLIENT_ID_UAT;
2020
const MOCK_GOOGLE_OAUTH_CLIENT_ID_ANDROID =
21-
'387141446914-olajr83p1bbvabh1u8tfglt1k4u6jlcb.apps.googleusercontent.com';
21+
process.env.MAIN_ANDROID_GOOGLE_CLIENT_ID_UAT;
2222

2323
function getMockGoogleOAuthClientId(): string {
24-
return Platform.OS === 'ios'
25-
? MOCK_GOOGLE_OAUTH_CLIENT_ID_IOS
26-
: MOCK_GOOGLE_OAUTH_CLIENT_ID_ANDROID;
24+
const clientId =
25+
Platform.OS === 'ios'
26+
? MOCK_GOOGLE_OAUTH_CLIENT_ID_IOS
27+
: MOCK_GOOGLE_OAUTH_CLIENT_ID_ANDROID;
28+
if (!clientId) {
29+
throw new Error(
30+
`[E2E Mock] Missing Google OAuth UAT client ID env var for platform "${Platform.OS}". ` +
31+
'Ensure MAIN_IOS_GOOGLE_CLIENT_ID_UAT or MAIN_ANDROID_GOOGLE_CLIENT_ID_UAT is set.',
32+
);
33+
}
34+
return clientId;
2735
}
2836

2937
/**
@@ -261,10 +269,16 @@ export function createLoginHandler(
261269
clientId: getMockGoogleOAuthClientId(),
262270
redirectUri: 'metamask://e2e',
263271
});
264-
case 'apple':
265-
return new MockAppleLoginHandler({
266-
clientId: 'io.metamask.appleloginclient.uat',
267-
});
272+
case 'apple': {
273+
const appleClientId = process.env.MAIN_ANDROID_APPLE_CLIENT_ID_UAT;
274+
if (!appleClientId) {
275+
throw new Error(
276+
'[E2E Mock] Missing Apple OAuth UAT client ID. ' +
277+
'Ensure MAIN_ANDROID_APPLE_CLIENT_ID_UAT is set.',
278+
);
279+
}
280+
return new MockAppleLoginHandler({ clientId: appleClientId });
281+
}
268282
default:
269283
throw new Error(`[E2E Mock] Unsupported provider: ${provider}`);
270284
}

0 commit comments

Comments
 (0)