Commit 484fa2b
authored
feat: MUSD-691 clean up deprecated quick convert code (#29351)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.
In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->
## **Description**
This PR removes the now deprecated Quick Convert code paths. We're
keeping the Max convert bottom sheet and the `MusdConversionAssetRow`
components to integrate into the Money Home screen.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: remove deprecated quick convert feature code paths
## **Related issues**
Fixes:
- [MUSD-691: Clean up deprecated Quick Convert Home and related code
paths](https://consensyssoftware.atlassian.net/browse/MUSD-691)
## **Manual testing steps**
N/A
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
N/A
### **After**
<!-- [screenshots/recordings] -->
N/A
## **Pre-merge author checklist**
<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.
Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
#### Performance checks (if applicable)
- [ ] I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example
For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).
## **Pre-merge reviewer checklist**
<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Medium risk because it removes a navigation route/feature flag and
rewires mUSD conversion CTAs and analytics to always use the
custom-amount flow, which could affect user routing and event reporting
if any remaining callers expected Quick Convert.
>
> **Overview**
> Removes the deprecated mUSD **Quick Convert** flow end-to-end: deletes
`MusdQuickConvertView` (and `MusdBalanceCard`), drops the
`MM_MUSD_QUICK_CONVERT_ENABLED` env var, removes the quick-convert
feature-flag selector/remote registry entries, and removes the
`Routes.EARN.MUSD.QUICK_CONVERT` route.
>
> Updates mUSD conversion entry points (`useMusdConversion`, education
screen, cash/token list/asset CTAs) to stop passing/handling
`navigationOverride` and to always route/track redirects to
`CUSTOM_AMOUNT_SCREEN` (while keeping the max-convert bottom sheet
location constant).
>
> Renames `ConvertTokenRow` to `MusdConversionAssetRow` and updates
downstream usage/tests (e.g., Money convert stablecoins, cash tokens
skeleton) to use the new component/test IDs.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
74947e7. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 9b73aff commit 484fa2b
39 files changed
Lines changed: 139 additions & 1872 deletions
File tree
- app
- components
- UI
- Earn
- Views
- EarnMusdConversionEducationView
- MusdQuickConvertView
- components/MusdBalanceCard
- components
- EarnLendingBalance
- Musd
- MusdConversionAssetListCta
- MusdConversionAssetOverviewCta
- MusdConversionAssetRow
- constants/events
- hooks
- routes
- selectors/featureFlags
- types
- Money/components/MoneyConvertStablecoins
- Tokens/TokenList/TokenListItem
- Views
- CashTokensFullView
- Homepage
- Sections/Cash
- core/Analytics
- tests/feature-flags
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
118 | 117 | | |
119 | 118 | | |
120 | 119 | | |
| |||
Lines changed: 0 additions & 82 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | 24 | | |
27 | 25 | | |
28 | 26 | | |
| |||
74 | 72 | | |
75 | 73 | | |
76 | 74 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | 75 | | |
82 | 76 | | |
83 | 77 | | |
| |||
123 | 117 | | |
124 | 118 | | |
125 | 119 | | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | 120 | | |
131 | 121 | | |
132 | 122 | | |
| |||
236 | 226 | | |
237 | 227 | | |
238 | 228 | | |
239 | | - | |
240 | 229 | | |
241 | 230 | | |
242 | 231 | | |
| |||
321 | 310 | | |
322 | 311 | | |
323 | 312 | | |
324 | | - | |
325 | 313 | | |
326 | 314 | | |
327 | 315 | | |
| |||
512 | 500 | | |
513 | 501 | | |
514 | 502 | | |
515 | | - | |
516 | 503 | | |
517 | 504 | | |
518 | 505 | | |
| |||
1057 | 1044 | | |
1058 | 1045 | | |
1059 | 1046 | | |
1060 | | - | |
1061 | 1047 | | |
1062 | 1048 | | |
1063 | 1049 | | |
| |||
1115 | 1101 | | |
1116 | 1102 | | |
1117 | 1103 | | |
1118 | | - | |
1119 | | - | |
1120 | | - | |
1121 | | - | |
1122 | | - | |
1123 | | - | |
1124 | | - | |
1125 | | - | |
1126 | | - | |
1127 | | - | |
1128 | | - | |
1129 | | - | |
1130 | | - | |
1131 | | - | |
1132 | | - | |
1133 | | - | |
1134 | | - | |
1135 | | - | |
1136 | | - | |
1137 | | - | |
1138 | | - | |
1139 | | - | |
1140 | | - | |
1141 | | - | |
1142 | | - | |
1143 | | - | |
1144 | | - | |
1145 | | - | |
1146 | | - | |
1147 | | - | |
1148 | | - | |
1149 | | - | |
1150 | 1104 | | |
1151 | 1105 | | |
1152 | 1106 | | |
| |||
1232 | 1186 | | |
1233 | 1187 | | |
1234 | 1188 | | |
1235 | | - | |
1236 | | - | |
1237 | | - | |
1238 | | - | |
1239 | | - | |
1240 | | - | |
1241 | | - | |
1242 | | - | |
1243 | | - | |
1244 | | - | |
1245 | | - | |
1246 | | - | |
1247 | | - | |
1248 | | - | |
1249 | | - | |
1250 | | - | |
1251 | | - | |
1252 | | - | |
1253 | | - | |
1254 | | - | |
1255 | | - | |
1256 | | - | |
1257 | | - | |
1258 | | - | |
1259 | | - | |
1260 | | - | |
1261 | | - | |
1262 | | - | |
1263 | | - | |
1264 | | - | |
1265 | | - | |
1266 | | - | |
1267 | | - | |
1268 | | - | |
1269 | | - | |
1270 | | - | |
1271 | 1189 | | |
1272 | 1190 | | |
1273 | 1191 | | |
| |||
Lines changed: 4 additions & 31 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
| 43 | + | |
48 | 44 | | |
49 | 45 | | |
50 | 46 | | |
| |||
65 | 61 | | |
66 | 62 | | |
67 | 63 | | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | 64 | | |
75 | 65 | | |
76 | 66 | | |
| |||
86 | 76 | | |
87 | 77 | | |
88 | 78 | | |
89 | | - | |
90 | 79 | | |
91 | 80 | | |
92 | 81 | | |
93 | 82 | | |
94 | 83 | | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
| 84 | + | |
| 85 | + | |
101 | 86 | | |
102 | 87 | | |
103 | 88 | | |
| |||
219 | 204 | | |
220 | 205 | | |
221 | 206 | | |
222 | | - | |
223 | | - | |
224 | | - | |
| 207 | + | |
225 | 208 | | |
226 | 209 | | |
227 | 210 | | |
| |||
245 | 228 | | |
246 | 229 | | |
247 | 230 | | |
248 | | - | |
249 | 231 | | |
250 | | - | |
251 | 232 | | |
252 | 233 | | |
253 | 234 | | |
| |||
325 | 306 | | |
326 | 307 | | |
327 | 308 | | |
328 | | - | |
329 | | - | |
330 | 309 | | |
331 | 310 | | |
332 | 311 | | |
333 | 312 | | |
334 | 313 | | |
335 | | - | |
336 | | - | |
337 | 314 | | |
338 | 315 | | |
339 | 316 | | |
340 | 317 | | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | 318 | | |
345 | 319 | | |
346 | 320 | | |
| |||
365 | 339 | | |
366 | 340 | | |
367 | 341 | | |
368 | | - | |
369 | 342 | | |
370 | 343 | | |
371 | 344 | | |
| |||
Lines changed: 0 additions & 39 deletions
This file was deleted.
0 commit comments