upload to test flight internally distrivution

Author: tommasini

.github/workflows/nightly-build.yml

@@ -141,7 +141,8 @@ jobs:
             "github_actions_main-exp" \
             "${{ github.ref_name }}" \
             "${{ steps.ipa.outputs.path }}" \
-            "MetaMask BETA & Release Candidates"
+            "MetaMask BETA & Release Candidates" \
+            "false"
 
       - name: Cleanup API Key
         if: always()
@@ -200,7 +201,8 @@ jobs:
             "github_actions_main-rc" \
             "${{ github.ref_name }}" \
             "${{ steps.ipa.outputs.path }}" \
-            "MetaMask BETA & Release Candidates"
+            "MetaMask BETA & Release Candidates" \
+            "false"
 
       - name: Cleanup API Key
         if: always()

ios/fastlane/Fastfile

@@ -20,7 +20,8 @@ platform :ios do
     # Convert groups parameter to array (Fastlane CLI passes strings, not arrays)
     groups_param = options[:groups] || ['MetaMask BETA & Release Candidates']
     groups = groups_param.is_a?(Array) ? groups_param : [groups_param]
-    notify_external_testers = true
+    distribute_external = options[:distribute_external].nil? ? true : options[:distribute_external].to_s.downcase == 'true'
+    notify_external_testers = distribute_external
 
     if ipa_path.nil? || ipa_path.empty?
       UI.user_error!("You must provide an ipa_path using ipa_path: '/path/to/app.ipa'")
@@ -96,7 +97,7 @@ platform :ios do
     upload_to_testflight(
       api_key: api_key,
       ipa: ipa_path,
-      distribute_external: true,
+      distribute_external: distribute_external,
       groups: groups,
       notify_external_testers: notify_external_testers,
       changelog: changelog_message

scripts/upload-to-testflight.sh

@@ -4,13 +4,14 @@
 # This script can be used in both Bitrise and GitHub Actions workflows
 #
 # Usage:
-#   ./scripts/upload-to-testflight.sh <pipeline_name> <branch> [ipa_path] [testflight_group]
+#   ./scripts/upload-to-testflight.sh <pipeline_name> <branch> [ipa_path] [testflight_group] [distribute_external]
 #
 # Arguments:
-#   pipeline_name    - Pipeline or workflow name (required)
-#   branch           - Git branch name (required)
-#   ipa_path         - Optional: Direct path to IPA file (if not provided, uses find-ipa-file.sh)
-#   testflight_group - Optional: TestFlight external testing group name (default: MetaMask BETA & Release Candidates)
+#   pipeline_name       - Pipeline or workflow name (required)
+#   branch              - Git branch name (required)
+#   ipa_path            - Optional: Direct path to IPA file (if not provided, uses find-ipa-file.sh)
+#   testflight_group    - Optional: TestFlight external testing group name (default: MetaMask BETA & Release Candidates)
+#   distribute_external - Optional: Whether to distribute to external testers (default: true)
 #
 # Environment variables:
 #   IPA_PATH - IPA path (set by find-ipa-file.sh if not provided as argument)
@@ -27,6 +28,7 @@ PIPELINE_NAME="$1"
 BRANCH="$2"
 LOCAL_IPA_PATH="$3"
 TESTFLIGHT_GROUP="${4:-MetaMask BETA & Release Candidates}"
+DISTRIBUTE_EXTERNAL="${5:-true}"
 
 # Get IPA path: use argument if provided, otherwise use find-ipa-file.sh
 if [ -n "$LOCAL_IPA_PATH" ]; then
@@ -74,5 +76,6 @@ cd ios
 bundle exec fastlane upload_to_testflight_only \
   ipa_path:"$IPA_PATH" \
   groups:"$TESTFLIGHT_GROUP" \
-  changelog:"$CHANGELOG"
+  changelog:"$CHANGELOG" \
+  distribute_external:"$DISTRIBUTE_EXTERNAL"