Skip to content

Commit 4a3ed84

Browse files
authored
fix: fix scroll custom import tokens (#16079)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #15267 ## **Manual testing steps** 1. Go to import token page 2. go to custom import 3. click on select network then try to scroll ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/441e7fd0-05eb-4f27-a3c3-6f7163f4cbd7 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 0a6d672 commit 4a3ed84

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

app/components/Views/AddAsset/components/NetworkListBottomSheet.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import {
1919
} from '../../../../component-library/components/Avatars/Avatar';
2020
import { Hex } from '@metamask/utils';
2121
import { getNetworkImageSource } from '../../../../util/networks';
22+
import BottomSheetHeader from '../../../../component-library/components/BottomSheets/BottomSheetHeader';
2223

2324
export const NETWORK_LIST_BOTTOM_SHEET = 'NETWORK_LIST_BOTTOM_SHEET';
2425

@@ -42,14 +43,17 @@ export default function NetworkListBottomSheet({
4243
<BottomSheet
4344
shouldNavigateBack={false}
4445
ref={sheetRef}
46+
isInteractable={false}
4547
onClose={() => setOpenNetworkSelector(false)}
46-
isInteractable
4748
style={styles.bottomSheetWrapperContent}
4849
testID={NETWORK_LIST_BOTTOM_SHEET}
4950
>
50-
<Text variant={TextVariant.HeadingMD} style={styles.bottomSheetTitle}>
51-
{strings('networks.select_network')}
52-
</Text>
51+
<BottomSheetHeader onClose={() => setOpenNetworkSelector(false)}>
52+
<Text variant={TextVariant.HeadingMD} style={styles.bottomSheetTitle}>
53+
{strings('networks.select_network')}
54+
</Text>
55+
</BottomSheetHeader>
56+
5357
<ScrollView>
5458
{Object.values(networkConfigurations).map((network) => (
5559
<View style={styles.bottomSheetWrapper} key={network.chainId}>

0 commit comments

Comments
 (0)