fix: cp-7.46.0 Fix Approval component to unnecessary override on confirmation (#14935)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Legacy `Approval` component overriding `EIP-1559` transaction and it's
gas values - when confirmations gets approved it's unnecessarily
collecting and updating big chunk of `transaction` object.

This PR aims to remove that update since it's unnecessary. 

## **Related issues**

Fixes: MetaMask/MetaMask-planning#4775

## **Manual testing steps**

1. Go to test-dapp
2. Connect Sepolia or LineaSepolia
3. Try "Send EIP1559 transaction" or "Create ERC20 token". Those should
be functional and working

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: OGPoyraz

app/components/Views/confirmations/legacy/Approval/index.js

@@ -1,4 +1,5 @@
 import React, { PureComponent } from 'react';
+import { TransactionEnvelopeType } from '@metamask/transaction-controller';
 import { StyleSheet, AppState, Alert, InteractionManager } from 'react-native';
 import Engine from '../../../../../core/Engine';
 import PropTypes from 'prop-types';
@@ -379,8 +380,8 @@ class Approval extends PureComponent {
       request_source: this.originIsMMSDKRemoteConn
         ? AppConstants.REQUEST_SOURCES.SDK_REMOTE_CONN
         : this.originIsWalletConnect
-          ? AppConstants.REQUEST_SOURCES.WC
-          : AppConstants.REQUEST_SOURCES.IN_APP_BROWSER,
+        ? AppConstants.REQUEST_SOURCES.WC
+        : AppConstants.REQUEST_SOURCES.IN_APP_BROWSER,
     };
 
     try {
@@ -497,7 +498,6 @@ class Approval extends PureComponent {
     const { KeyringController, ApprovalController } = Engine.context;
     const {
       transactions,
-      chainId,
       shouldUseSmartTransaction,
       simulationData: { isUpdatedAfterSecurityCheck } = {},
       navigation,
@@ -565,20 +565,23 @@ class Approval extends PureComponent {
           },
           (transactionMeta) => transactionMeta.id === transaction.id,
         );
+      await KeyringController.resetQRKeyringState();
 
       const fullTx = transactions.find(({ id }) => id === transaction.id);
 
+      if (fullTx.txParams.type !== TransactionEnvelopeType.legacy) {
+        // For EIP-1559 transactions, we need to remove gasPrice as it's not compatible
+        delete transaction.gasPrice;
+      }
+
       const updatedTx = {
         ...fullTx,
         txParams: {
-          ...fullTx.txParams,
           ...transaction,
-          chainId,
         },
       };
 
       await updateTransaction(updatedTx);
-      await KeyringController.resetQRKeyringState();
 
       // For Ledger Accounts we handover the signing to the confirmation flow
       if (isLedgerAccount) {