Commit 4dcbb6f
feat(predict): update liveline chart foundation (#30003)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.
In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->
## **Description**
This PR updates the shared Liveline chart foundation used by the Predict
crypto up/down work. It makes the React Native wrapper and WebView
template support imperative live-point updates, queued messages before
chart readiness, native loading behavior, and safer callback handling.
# TODO
1. This PR is stack item 1/3 and should merge before #30004 and #30005.
2. Keep this PR as draft until the stacked PRs are validated and all
required checks are passing.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: null
## **Related issues**
Fixes: N/A - stacked Predict crypto up/down implementation split from
#29436.
## **Manual testing steps**
```gherkin
Feature: Liveline chart foundation
Scenario: chart initializes and accepts live data updates
Given a Predict screen renders a Liveline chart with historical data
When the chart WebView becomes ready and live price points arrive
Then the chart remains mounted and updates without showing an error state
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
N/A
### **After**
N/A
## **Pre-merge author checklist**
<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.
Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
#### Performance checks (if applicable)
- [ ] I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example
For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).
## **Pre-merge reviewer checklist**
<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Moderate risk because it changes the RN↔WebView messaging contract and
rendering flow (adds queued imperative updates and live-mode state),
which could affect chart correctness, loading states, and performance.
>
> **Overview**
> Updates `LivelineChart` to support an imperative ref API
(`appendPoint`, `clearData`) that sends incremental WebView messages,
queues them until `CHART_READY`, and flushes deterministically before
firing `onChartReady`.
>
> Extends the RN↔WebView protocol and template to handle
`APPEND_POINT`/`CLEAR_DATA`, maintain a live-mode data buffer with
merge/trim behavior, and optionally hide in-chart controls via the new
`hideControls` prop (CSS body class).
>
> Adjusts loading and callback handling: keeps a native loading overlay
while `loading` is true, stabilizes `onMessage` while always using
latest callback props, and adds dev-only `PERF` telemetry logging plus
expanded unit tests for the new behaviors.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
ce2a7e2. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Co-authored-by: Cursor <cursoragent@cursor.com>1 parent 268e164 commit 4dcbb6f
5 files changed
Lines changed: 507 additions & 194 deletions
File tree
- app/components/UI/Charts/LivelineChart
- __tests__
0 commit comments