Skip to content

Commit 520fa22

Browse files
fix: added back the component box with the previous gap (#30007)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> ## **Description** Added back the padding between perps section header and pnl <img width="377" height="96" alt="Screenshot 2026-05-12 at 12 33 58" src="https://github.com/user-attachments/assets/d5ab835b-c6cd-4be7-a578-d407046f4fb3" /> <img width="386" height="97" alt="Screenshot 2026-05-12 at 12 33 53" src="https://github.com/user-attachments/assets/24a25672-a7f1-4072-b721-05e967fe910a" /> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI-only layout change that re-wraps existing components to restore vertical spacing; no business logic, networking, or data handling changes. > > **Overview** > Restores the previous vertical spacing between the section header and the unrealized PnL row on the homepage. > > In both `PerpsSection` and `HomepagePredictPositions`, the header and `HomepageSectionUnrealizedPnlRow` are wrapped in an extra `Box` with `gap={1}` so the PnL row renders with consistent padding beneath the title. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 395a75f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 8a06762 commit 520fa22

2 files changed

Lines changed: 28 additions & 24 deletions

File tree

app/components/Views/Homepage/Sections/Perpetuals/PerpsSection.tsx

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -442,16 +442,18 @@ const PerpsSectionMain = forwardRef<SectionRefreshHandle, PerpsSectionProps>(
442442
return (
443443
<View ref={sectionViewRef} onLayout={onLayout}>
444444
<Box gap={3}>
445-
<SectionHeader title={title} onPress={handleViewAllPerps} />
446-
{showHomepageUnrealizedPnl && (
447-
<HomepageSectionUnrealizedPnlRow
448-
isLoading={perpsAccountLoading}
449-
valueText={homepageUnrealizedPnl?.valueText}
450-
tone={homepageUnrealizedPnl?.tone ?? 'neutral'}
451-
label={strings('perps.unrealized_pnl')}
452-
testID="homepage-perps-unrealized-pnl"
453-
/>
454-
)}
445+
<Box gap={1}>
446+
<SectionHeader title={title} onPress={handleViewAllPerps} />
447+
{showHomepageUnrealizedPnl && (
448+
<HomepageSectionUnrealizedPnlRow
449+
isLoading={perpsAccountLoading}
450+
valueText={homepageUnrealizedPnl?.valueText}
451+
tone={homepageUnrealizedPnl?.tone ?? 'neutral'}
452+
label={strings('perps.unrealized_pnl')}
453+
testID="homepage-perps-unrealized-pnl"
454+
/>
455+
)}
456+
</Box>
455457
{showSkeleton || pendingTrending ? (
456458
<SectionRow>
457459
<PerpsPositionSkeleton />

app/components/Views/Homepage/Sections/Predictions/PredictionsSection.tsx

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -199,20 +199,22 @@ const HomepagePredictPositions = ({
199199
}: HomepagePredictPositionsProps) => (
200200
<Box gap={3}>
201201
{showHeader && (
202-
<SectionHeader
203-
title={title}
204-
onPress={onViewAll}
205-
testID={WalletViewSelectorsIDs.HOMEPAGE_SECTION_TITLE('predictions')}
206-
/>
207-
)}
208-
{showHeader && predictHomepageUnrealizedPnl.show && (
209-
<HomepageSectionUnrealizedPnlRow
210-
isLoading={predictHomepageUnrealizedPnl.isLoading}
211-
valueText={predictHomepageUnrealizedPnl.valueText}
212-
tone={predictHomepageUnrealizedPnl.tone}
213-
label={strings('predict.unrealized_pnl_label')}
214-
testID="homepage-predict-unrealized-pnl"
215-
/>
202+
<Box gap={1}>
203+
<SectionHeader
204+
title={title}
205+
onPress={onViewAll}
206+
testID={WalletViewSelectorsIDs.HOMEPAGE_SECTION_TITLE('predictions')}
207+
/>
208+
{predictHomepageUnrealizedPnl.show && (
209+
<HomepageSectionUnrealizedPnlRow
210+
isLoading={predictHomepageUnrealizedPnl.isLoading}
211+
valueText={predictHomepageUnrealizedPnl.valueText}
212+
tone={predictHomepageUnrealizedPnl.tone}
213+
label={strings('predict.unrealized_pnl_label')}
214+
testID="homepage-predict-unrealized-pnl"
215+
/>
216+
)}
217+
</Box>
216218
)}
217219
{isLoadingPositions ? (
218220
<>

0 commit comments

Comments
 (0)