fix(rewards): sync mUSD calculator disclaimer APY with conversion rate

Parameterize disclaimer_calculator with {{apy}} and pass MUSD_CONVERSION_APY; document constant in musd.ts.

Author: andrewjcohen

app/components/UI/Earn/constants/musd.ts

@@ -61,6 +61,7 @@ export const MUSD_TOKEN_ASSET_ID_BY_CHAIN: Record<Hex, string> = {
 };
 
 export const MUSD_CURRENCY = 'MUSD';
+/** APY in whole percent (e.g. 3 → 3%). Drives Earn UI and Rewards mUSD calculator math and disclaimer copy. */
 export const MUSD_CONVERSION_APY = 3;
 
 // Delay before cleaning up toast tracking entries after final transaction status

app/components/UI/Rewards/components/Tabs/MusdCalculatorTab/MusdCalculatorTab.tsx

@@ -38,6 +38,7 @@ import { BridgeToken } from '../../../../Bridge/types';
 import { getTokenIconUrl } from '../../../../Bridge/utils';
 import { getNativeSourceToken } from '../../../../Bridge/utils/tokenUtils';
 import {
+  MUSD_CONVERSION_APY,
   MUSD_TOKEN,
   MUSD_TOKEN_ADDRESS,
   MUSD_TOKEN_ASSET_ID_BY_CHAIN,
@@ -433,7 +434,9 @@ const MusdCalculatorTab: React.FC = () => {
           color={TextColor.TextAlternative}
           twClassName="mb-6 max-w-[361px] self-center text-center leading-[22px]"
         >
-          {strings('rewards.musd.disclaimer_calculator')}
+          {strings('rewards.musd.disclaimer_calculator', {
+            apy: MUSD_CONVERSION_APY,
+          })}
         </Text>
 
         <Box

locales/languages/en.json

@@ -8407,7 +8407,7 @@
       "earnings_per_month_suffix": "/mo",
       "earnings_per_day_suffix": "/day",
       "slider_amount_label": "Amount",
-      "disclaimer_calculator": "Calculation based on 3% APY. Bonus rate may change. Paid daily, claimable any time.",
+      "disclaimer_calculator": "Calculation based on {{apy}}% APY. Bonus rate may change. Paid daily, claimable any time.",
       "buy_button": "Buy mUSD",
       "swap_button": "Swap to mUSD"
     },