Skip to content

Commit 52fedde

Browse files
chore(runway): cherry-pick fix: bridge controllers bumps (#15973)
- fix: cp-7.47.0 bridge controllers bumps (#15862)
1 parent e38c5be commit 52fedde

8 files changed

Lines changed: 92 additions & 178 deletions

File tree

app/components/UI/Bridge/hooks/useInitialSourceToken/index.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { selectEvmNetworkConfigurationsByChainId } from '../../../../../selector
66
import { useSwitchNetworks } from '../../../../Views/NetworkSelector/useSwitchNetworks';
77
import { useNetworkInfo } from '../../../../../selectors/selectedNetworkController';
88
import { CaipChainId, Hex } from '@metamask/utils';
9-
import { getNativeAssetForChainId } from '@metamask/bridge-controller';
9+
import { getNativeAssetForChainId, isSolanaChainId } from '@metamask/bridge-controller';
1010
import { constants } from 'ethers';
1111
///: BEGIN:ONLY_INCLUDE_IF(keyring-snaps)
1212
import { SolScope } from '@metamask/keyring-api';
@@ -15,8 +15,11 @@ import { SolScope } from '@metamask/keyring-api';
1515
export const getNativeSourceToken = (chainId: Hex | CaipChainId) => {
1616
const nativeAsset = getNativeAssetForChainId(chainId);
1717

18+
// getNativeAssetForChainId returns zero address for Solana, we need the assetId to get balances properly for native SOL
19+
const address = isSolanaChainId(chainId) ? nativeAsset.assetId : nativeAsset.address;
20+
1821
const nativeSourceTokenFormatted: BridgeToken = {
19-
address: nativeAsset.address,
22+
address,
2023
name: nativeAsset.name ?? '',
2124
symbol: nativeAsset.symbol,
2225
image: 'iconUrl' in nativeAsset ? nativeAsset.iconUrl : '',

app/components/UI/Bridge/hooks/useSwapBridgeNavigation/useSwapBridgeNavigation.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import Engine from '../../../../../core/Engine';
99
import Routes from '../../../../../constants/navigation/Routes';
1010
import { selectChainId } from '../../../../../selectors/networkController';
1111
import { selectIsBridgeEnabledSource } from '../../../../../core/redux/slices/bridge';
12+
import { ethers } from 'ethers';
1213

1314
// Mock dependencies
1415
const mockNavigate = jest.fn();
@@ -280,7 +281,7 @@ describe('useSwapBridgeNavigation', () => {
280281
screen: 'BridgeView',
281282
params: {
282283
token: {
283-
address: 'solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/slip44:501',
284+
address: ethers.constants.AddressZero,
284285
name: 'Solana',
285286
symbol: 'SOL',
286287
image: '',
@@ -313,7 +314,7 @@ describe('useSwapBridgeNavigation', () => {
313314
screen: 'BridgeView',
314315
params: {
315316
token: {
316-
address: 'solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/slip44:501',
317+
address: ethers.constants.AddressZero,
317318
name: 'Solana',
318319
symbol: 'SOL',
319320
image: '',

app/components/Views/WalletActions/WalletActions.test.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import { trace, TraceName } from '../../../util/trace';
3232
import { RampType } from '../../../reducers/fiatOrders/types';
3333
import { selectStablecoinLendingEnabledFlag } from '../../UI/Earn/selectors/featureFlags';
3434
import { isBridgeAllowed } from '../../UI/Bridge/utils';
35+
import { ethers } from 'ethers';
3536

3637
jest.mock('../../UI/Earn/selectors/featureFlags', () => ({
3738
selectStablecoinLendingEnabledFlag: jest.fn(),
@@ -456,7 +457,7 @@ describe('WalletActions', () => {
456457
bridgeViewMode: 'Swap',
457458
sourcePage: 'MainView',
458459
token: {
459-
address: 'solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/slip44:501',
460+
address: ethers.constants.AddressZero,
460461
chainId: 'solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp',
461462
decimals: 9,
462463
image: '',

app/core/Engine/Engine.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -988,7 +988,11 @@ export class Engine {
988988
'SnapController:handleRequest',
989989
'TransactionController:getState',
990990
],
991-
allowedEvents: [],
991+
allowedEvents: [
992+
'TransactionController:transactionConfirmed',
993+
'TransactionController:transactionFailed',
994+
'MultichainTransactionsController:transactionConfirmed',
995+
],
992996
}),
993997
state: initialState.BridgeStatusController,
994998
clientId: BridgeClientId.MOBILE,

app/core/Engine/messengers/multichain-transactions-controller-messenger/types.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {
44
AccountsControllerListMultichainAccountsAction,
55
AccountsControllerAccountTransactionsUpdatedEvent,
66
} from '@metamask/accounts-controller';
7+
import { MultichainTransactionsControllerTransactionConfirmedEvent } from '@metamask/multichain-transactions-controller';
78
import { HandleSnapRequest } from '@metamask/snaps-controllers';
89

910
export type MultichainTransactionsControllerActions =
@@ -17,4 +18,5 @@ export type MultichainTransactionsControllerEvents =
1718
| {
1819
type: 'MultichainTransactionsController:stateChange';
1920
payload: [unknown];
20-
};
21+
}
22+
| MultichainTransactionsControllerTransactionConfirmedEvent

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,10 +166,10 @@
166166
"@metamask/approval-controller": "^7.1.3",
167167
"@metamask/assets-controllers": "^62.0.0",
168168
"@metamask/base-controller": "^8.0.0",
169-
"@metamask/bitcoin-wallet-snap": "^0.9.0",
170-
"@metamask/bridge-controller": "^23.0.0",
171-
"@metamask/bridge-status-controller": "^20.0.0",
172-
"@metamask/chain-agnostic-permission": "^0.3.0",
169+
"@metamask/bitcoin-wallet-snap": "^0.12.1",
170+
"@metamask/bridge-controller": "^28.0.0",
171+
"@metamask/bridge-status-controller": "^25.0.0",
172+
"@metamask/chain-agnostic-permission": "^0.6.0",
173173
"@metamask/composable-controller": "^11.0.0",
174174
"@metamask/controller-utils": "11.7.1-backport",
175175
"@metamask/design-tokens": "^7.0.0",

patches/@metamask+bridge-controller+23.0.0.patch

Lines changed: 0 additions & 117 deletions
This file was deleted.

0 commit comments

Comments
 (0)