Merge branch 'main' into rn-upgrade/0.81.5-no-unit-tests

Author: adnxy

app/components/UI/Card/hooks/useAssetBalances.test.ts

@@ -60,7 +60,7 @@ jest.mock('../../Ramp/Deposit/constants/networks', () => ({
     chainId: 'solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp',
   },
 }));
-jest.mock('../../../../util/number', () => ({
+jest.mock('../../../../util/number/bigint', () => ({
   balanceToFiatNumber: jest.fn((balance: string, rate: number) => {
     const bal = parseFloat(balance);
     return (bal * rate).toString();

app/components/UI/Card/hooks/useAssetBalances.tsx

@@ -8,7 +8,6 @@ import { useTokensWithBalance } from '../../Bridge/hooks/useTokensWithBalance';
 import { isSolanaChainId } from '@metamask/bridge-controller';
 import { selectCurrentCurrency } from '../../../../selectors/currencyRateController';
 import Engine from '../../../../core/Engine';
-import { balanceToFiatNumber } from '../../../../util/number';
 import { safeFormatChainIdToHex } from '../util/safeFormatChainIdToHex';
 import { TokenI } from '../../Tokens/types';
 import { MarketDataDetails } from '@metamask/assets-controllers';
@@ -17,6 +16,7 @@ import I18n from '../../../../../locales/i18n';
 import { deriveBalanceFromAssetMarketDetails } from '../../Tokens/util';
 import { buildTokenIconUrl } from '../util/buildTokenIconUrl';
 import { CARD_CHAIN_IDS } from '../constants';
+import { balanceToFiatNumber } from '../../../../util/number/bigint';
 
 const extractTrailingCurrencyCode = (value: string): string | undefined => {
   const match = value.trim().match(/([A-Za-z]{3})$/);

app/components/UI/Card/hooks/useCardDelegation.test.ts

@@ -9,7 +9,7 @@ import Logger from '../../../../util/Logger';
 import { MetaMetricsEvents } from '../../../../core/Analytics';
 import { useAnalytics } from '../../../hooks/useAnalytics/useAnalytics';
 import { createMockUseAnalyticsHook } from '../../../../util/test/analyticsMock';
-import { toTokenMinimalUnit } from '../../../../util/number';
+import { toTokenMinimalUnit } from '../../../../util/number/bigint';
 import { safeToChecksumAddress } from '../../../../util/address';
 import { ARBITRARY_ALLOWANCE } from '../constants';
 import {
@@ -42,7 +42,7 @@ jest.mock('../../../../util/Logger', () => ({
   error: jest.fn(),
 }));
 
-jest.mock('../../../../util/number', () => ({
+jest.mock('../../../../util/number/bigint', () => ({
   toTokenMinimalUnit: jest.fn(),
 }));
 
@@ -223,7 +223,7 @@ describe('useCardDelegation', () => {
       });
 
     // Setup utility mocks
-    mockToTokenMinimalUnit.mockReturnValue('100000000000000000000');
+    mockToTokenMinimalUnit.mockReturnValue(100000000000000000000n);
     mockSafeToChecksumAddress.mockImplementation(
       (address?: string) => (address as `0x${string}`) || undefined,
     );
@@ -401,7 +401,7 @@ describe('useCardDelegation', () => {
       const mockToken = createMockToken({ decimals: 6 });
       const params = createMockDelegationParams();
 
-      mockToTokenMinimalUnit.mockReturnValue('100000000');
+      mockToTokenMinimalUnit.mockReturnValue(100000000n);
 
       const { result } = renderHook(() => useCardDelegation(mockToken));
 
@@ -1356,7 +1356,7 @@ describe('useCardDelegation', () => {
       };
 
       mockToTokenMinimalUnit.mockReturnValue(
-        '999999999999999999999999999000000000000000000',
+        999999999999999999999999999000000000000000000n,
       );
 
       const { result } = renderHook(() => useCardDelegation(mockToken));

app/components/UI/Card/hooks/useCardDelegation.ts

@@ -20,7 +20,7 @@ import { useAnalytics } from '../../../hooks/useAnalytics/useAnalytics';
 import { useEnsureCardNetworkExists } from './useEnsureCardNetworkExists';
 import { MetaMetricsEvents } from '../../../../core/Analytics';
 import { ARBITRARY_ALLOWANCE } from '../constants';
-import { toTokenMinimalUnit } from '../../../../util/number';
+import { toTokenMinimalUnit } from '../../../../util/number/bigint';
 import AppConstants from '../../../../core/AppConstants';
 import { safeToChecksumAddress } from '../../../../util/address';
 import { handleSnapRequest } from '../../../../core/Snaps/utils';

app/components/UI/Card/hooks/useNeedsGasFaucet.ts

@@ -4,13 +4,12 @@ import { GAS_ESTIMATE_TYPES } from '@metamask/gas-fee-controller';
 import { isNonEvmChainId, isSolanaChainId } from '@metamask/bridge-controller';
 import { Hex, CaipChainId } from '@metamask/utils';
 import { BigNumber } from 'bignumber.js';
-import BN from 'bnjs4';
 import Engine from '../../../../core/Engine';
 import { useAccountNativeBalance } from '../../../Views/confirmations/hooks/useAccountNativeBalance';
 import { selectMinSolBalance } from '../../../../selectors/bridgeController';
 import { selectSelectedInternalAccountFormattedAddress } from '../../../../selectors/accountsController';
 import { decGWEIToHexWEI } from '../../../../util/conversions';
-import { hexToBN } from '../../../../util/number';
+import { hexToBigInt } from '../../../../util/number/bigint';
 import { safeFormatChainIdToHex } from '../util/safeFormatChainIdToHex';
 import { CardFundingToken } from '../types';
 import { useLatestBalance } from '../../Bridge/hooks/useLatestBalance';
@@ -93,7 +92,7 @@ export const useNeedsGasFaucet = (
   /**
    * Estimate gas fee for EVM chains
    */
-  const estimateEvmGasFee = useCallback(async (): Promise<BN> => {
+  const estimateEvmGasFee = useCallback(async (): Promise<bigint> => {
     try {
       const { GasFeeController } = Engine.context;
       const result = await GasFeeController.fetchGasFeeEstimates();
@@ -120,16 +119,16 @@ export const useNeedsGasFaucet = (
           break;
       }
 
-      const weiGasPrice = hexToBN(decGWEIToHexWEI(gasPrice));
-      return weiGasPrice.muln(gasLimitWithBuffer);
+      const weiGasPrice = hexToBigInt(decGWEIToHexWEI(gasPrice) as string);
+      return weiGasPrice * BigInt(gasLimitWithBuffer);
     } catch (err) {
       // Return a conservative fallback estimate if gas estimation fails
       // Assume ~20 Gwei gas price as fallback
-      const fallbackGasPrice = new BN('20000000000'); // 20 Gwei in Wei
+      const fallbackGasPrice = 20000000000n; // 20 Gwei in Wei
       const gasLimitWithBuffer = Math.ceil(
         ERC20_APPROVE_GAS_LIMIT * GAS_LIMIT_BUFFER,
       );
-      return fallbackGasPrice.muln(gasLimitWithBuffer);
+      return fallbackGasPrice * BigInt(gasLimitWithBuffer);
     }
   }, []);
 
@@ -144,10 +143,10 @@ export const useNeedsGasFaucet = (
 
     try {
       const estimatedGasFee = await estimateEvmGasFee();
-      const balanceBN = new BN(balanceWeiInHex.replace('0x', ''), 'hex');
+      const balance = hexToBigInt(balanceWeiInHex);
 
       // User needs faucet if balance is less than estimated gas fee
-      return balanceBN.lt(estimatedGasFee);
+      return balance < estimatedGasFee;
     } catch (err) {
       console.error('Error checking EVM faucet need:', err);
       // Assume needs faucet on error