chore(runway): cherry-pick fix: cp-7.65.0 Remove speed-up and cancel buttons temporarily (#25925)

- fix: cp-7.65.0 Remove speed-up and cancel buttons temporarily (#25859)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR aims to remove speed up and cancel buttons from transaction
activity temporarily.

We will introduce as part of redesign here:
https://github.com/MetaMask/MetaMask-planning/issues/6569

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes: #25781

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I've included tests if applicable
- [X] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I've applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> UI-only removal of existing actions; risk is mainly a temporary loss
of user functionality with minimal chance of breaking unrelated
transaction rendering.
> 
> **Overview**
> Removes the **Speed up** and **Cancel** transaction action buttons
from the activity list rows and from the transaction details modal
(`TransactionElement` and `TransactionDetails`).
> 
> Cleans up related wiring by dropping the smart-transaction gating
selector/props and deleting the associated UI handlers/tests (including
the `TransactionDetails` button rendering test and unused callbacks in
`TransactionDetailsSheet`).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
78845da. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->


[fb14049](fb14049)

Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com>

Author: runway-github[bot]

app/components/UI/TransactionElement/TransactionDetails/index.js

@@ -18,7 +18,6 @@ import Logger from '../../../../util/Logger';
 import EthereumAddress from '../../EthereumAddress';
 import TransactionSummary from '../../../Views/TransactionSummary';
 import { toDateFormat } from '../../../../util/date';
-import StyledButton from '../../StyledButton';
 import StatusText from '../../../Base/StatusText';
 import Text, {
   TextColor,
@@ -43,7 +42,6 @@ import { selectTokensByChainIdAndAddress } from '../../../../selectors/tokensCon
 import { selectContractExchangeRatesByChainId } from '../../../../selectors/tokenRatesController';
 import { selectSelectedInternalAccountFormattedAddress } from '../../../../selectors/accountsController';
 import { regex } from '../../../../../app/util/regex';
-import { selectShouldUseSmartTransaction } from '../../../../selectors/smartTransactionsController';
 import {
   selectPrimaryCurrency,
   selectAvatarAccountType,
@@ -152,8 +150,6 @@ class TransactionDetails extends PureComponent {
     /**
      * A string representing the network name
      */
-    showSpeedUpModal: PropTypes.func,
-    showCancelModal: PropTypes.func,
     selectedAddress: PropTypes.string,
     transactions: PropTypes.array,
     ticker: PropTypes.string,
@@ -164,11 +160,6 @@ class TransactionDetails extends PureComponent {
     swapsTransactions: PropTypes.object,
     swapsTokens: PropTypes.array,
     primaryCurrency: PropTypes.string,
-
-    /**
-     * Boolean that indicates if smart transaction should be used
-     */
-    shouldUseSmartTransaction: PropTypes.bool,
     /**
      * Avatar style to render for account icons
      */
@@ -177,7 +168,6 @@ class TransactionDetails extends PureComponent {
 
   state = {
     rpcBlockExplorer: undefined,
-    renderTxActions: true,
     updatedTransactionDetails: undefined,
   };
 
@@ -323,60 +313,10 @@ class TransactionDetails extends PureComponent {
     return createStyles(colors);
   };
 
-  showSpeedUpModal = () => {
-    const { showSpeedUpModal, close } = this.props;
-    if (close) {
-      close();
-      showSpeedUpModal();
-    }
-  };
-
-  showCancelModal = () => {
-    const { showCancelModal, close } = this.props;
-    if (close) {
-      close();
-      showCancelModal();
-    }
-  };
-
-  renderSpeedUpButton = () => {
-    const styles = this.getStyles();
-
-    return (
-      <StyledButton
-        type={'normal'}
-        containerStyle={[
-          styles.actionContainerStyle,
-          styles.speedupActionContainerStyle,
-        ]}
-        style={styles.actionStyle}
-        onPress={this.showSpeedUpModal}
-      >
-        {strings('transaction.speedup')}
-      </StyledButton>
-    );
-  };
-
-  renderCancelButton = () => {
-    const styles = this.getStyles();
-
-    return (
-      <StyledButton
-        type={'cancel'}
-        containerStyle={styles.actionContainerStyle}
-        style={styles.actionStyle}
-        onPress={this.showCancelModal}
-      >
-        {strings('transaction.cancel')}
-      </StyledButton>
-    );
-  };
-
   render = () => {
     const {
       transactionObject,
       transactionObject: { status, time, txParams, chainId: txChainId },
-      shouldUseSmartTransaction,
     } = this.props;
     const chainId = txChainId;
     const hasNestedTransactions = Boolean(
@@ -385,9 +325,6 @@ class TransactionDetails extends PureComponent {
     const { updatedTransactionDetails } = this.state;
     const styles = this.getStyles();
 
-    const renderTxActions =
-      (status === 'submitted' || status === 'approved') &&
-      !shouldUseSmartTransaction;
     const { rpcBlockExplorer } = this.state;
 
     return updatedTransactionDetails ? (
@@ -412,13 +349,6 @@ class TransactionDetails extends PureComponent {
               {strings('transactions.status')}
             </DetailsModal.SectionTitle>
             <StatusText status={status} />
-            {!!renderTxActions &&
-              updatedTransactionDetails?.txChainId === chainId && (
-                <View style={styles.transactionActionsContainer}>
-                  {this.renderSpeedUpButton()}
-                  {this.renderCancelButton()}
-                </View>
-              )}
           </DetailsModal.Column>
           <DetailsModal.Column end>
             <DetailsModal.SectionTitle>
@@ -567,10 +497,6 @@ const mapStateToProps = (state, ownProps) => ({
   primaryCurrency: selectPrimaryCurrency(state),
   swapsTransactions: selectSwapsTransactions(state),
   swapsTokens: swapsControllerTokens(state),
-  shouldUseSmartTransaction: selectShouldUseSmartTransaction(
-    state,
-    ownProps.transactionObject.chainId,
-  ),
   avatarAccountType: selectAvatarAccountType(state),
 });
 

app/components/UI/TransactionElement/TransactionDetails/index.test.tsx

@@ -1,6 +1,6 @@
 import React from 'react';
 import { query } from '@metamask/controller-utils';
-import { fireEvent, waitFor } from '@testing-library/react-native';
+import { fireEvent } from '@testing-library/react-native';
 import TransactionDetails from './';
 import { backgroundState } from '../../../../util/test/initial-root-state';
 import { MOCK_ACCOUNTS_CONTROLLER_STATE } from '../../../../util/test/accountsControllerTestUtils';
@@ -348,37 +348,6 @@ describe('TransactionDetails', () => {
     });
   });
 
-  it('should render speed up and cancel buttons', async () => {
-    const { getByText } = renderComponent({
-      state: {
-        ...initialState,
-        engine: {
-          ...initialState.engine,
-          backgroundState: {
-            ...initialState.engine.backgroundState,
-            PreferencesController: {
-              smartTransactionsOptInStatus: false,
-            },
-          },
-        },
-      },
-      hash: '0x3',
-      txParams: {
-        multiLayerL1FeeTotal: '0x1',
-      },
-      status: 'submitted',
-    });
-
-    await waitFor(() => {
-      const speedUpButton = getByText('Speed up');
-      expect(speedUpButton).toBeDefined();
-      const cancelButton = getByText('Cancel');
-      expect(cancelButton).toBeDefined();
-      fireEvent.press(speedUpButton);
-      fireEvent.press(cancelButton);
-    });
-  });
-
   it('should render `Batched transactions` tag if there are nested transactions', async () => {
     const { getByText } = renderComponent({
       state: initialState,

app/components/UI/TransactionElement/TransactionDetailsSheet/TransactionDetailsSheet.tsx

@@ -59,16 +59,6 @@ const TransactionDetailsSheet: React.FC = () => {
     sheetRef.current?.onCloseBottomSheet();
   }, []);
 
-  // Note: TransactionDetails internally calls close() before invoking these,
-  // so we don't need to close the sheet here - it's already handled
-  const handleSpeedUp = useCallback(() => {
-    route.params.showSpeedUpModal();
-  }, [route.params]);
-
-  const handleCancel = useCallback(() => {
-    route.params.showCancelModal();
-  }, [route.params]);
-
   return (
     <BottomSheet ref={sheetRef} shouldNavigateBack>
       <BottomSheetHeader onClose={handleClose}>
@@ -83,8 +73,6 @@ const TransactionDetailsSheet: React.FC = () => {
       <TransactionDetails
         transactionObject={tx}
         transactionDetails={transactionDetails}
-        showSpeedUpModal={handleSpeedUp}
-        showCancelModal={handleCancel}
         close={handleClose}
       />
     </BottomSheet>

app/components/UI/TransactionElement/index.js

@@ -498,7 +498,7 @@ class TransactionElement extends PureComponent {
       isQRHardwareAccount,
       isLedgerAccount,
       i,
-      tx: { status, isSmartTransaction, chainId, type },
+      tx: { status, chainId, type },
       tx,
       bridgeTxHistoryData: { bridgeTxHistoryItem, isBridgeComplete },
     } = this.props;
@@ -513,14 +513,6 @@ class TransactionElement extends PureComponent {
             bridgeTxHistoryItem.status.status,
           )
         : status;
-
-    const renderNormalActions =
-      (transactionStatus === 'submitted' ||
-        (transactionStatus === 'approved' &&
-          !isQRHardwareAccount &&
-          !isLedgerAccount)) &&
-      !isSmartTransaction &&
-      !isBridgeTransaction;
     const renderUnsignedQRActions =
       transactionStatus === 'approved' && isQRHardwareAccount;
     const renderLedgerActions =
@@ -571,12 +563,6 @@ class TransactionElement extends PureComponent {
             </ListItem.Amounts>
           )}
         </ListItem.Content>
-        {renderNormalActions && (
-          <ListItem.Actions>
-            {this.renderSpeedUpButton()}
-            {this.renderCancelButton()}
-          </ListItem.Actions>
-        )}
         {renderUnsignedQRActions && (
           <ListItem.Actions>
             {this.renderQRSignButton()}
@@ -590,22 +576,6 @@ class TransactionElement extends PureComponent {
     );
   };
 
-  renderCancelButton = () => {
-    const { colors, typography } = this.context || mockTheme;
-    const styles = createStyles(colors, typography);
-
-    return (
-      <StyledButton
-        type={'cancel'}
-        containerStyle={styles.actionContainerStyle}
-        style={styles.actionStyle}
-        onPress={this.showCancelModal}
-      >
-        {strings('transaction.cancel')}
-      </StyledButton>
-    );
-  };
-
   parseGas = () => {
     const { tx } = this.props;
 
@@ -661,25 +631,6 @@ class TransactionElement extends PureComponent {
     this.mounted && this.props.cancelUnsignedQRTransaction(this.props.tx);
   };
 
-  renderSpeedUpButton = () => {
-    const { colors, typography } = this.context || mockTheme;
-    const styles = createStyles(colors, typography);
-
-    return (
-      <StyledButton
-        type={'normal'}
-        containerStyle={[
-          styles.actionContainerStyle,
-          styles.speedupActionContainerStyle,
-        ]}
-        style={styles.actionStyle}
-        onPress={this.showSpeedUpModal}
-      >
-        {strings('transaction.speedup')}
-      </StyledButton>
-    );
-  };
-
   renderQRSignButton = () => {
     const { colors, typography } = this.context || mockTheme;
     const styles = createStyles(colors, typography);