Skip to content

Commit 59dba15

Browse files
authored
fix: Confirm font size; use default 16 px (#14715)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** There are inconsistent font sizes used across various confirmation texts. This PR removes multiple font sizes set to 14 and 16 to allow uses of the default font-size, 16px. Note that Figma specifies font-size: 14px but these were also designed for both mobile and extension. Figma: https://www.figma.com/design/wcXUl6AH5KNFwKdAIv49kh/Confirmation-redesign-V5?node-id=4157-13541&t=Zf3Nw0lAeQeeyWNK-0 Disclaimer: There is a discussion on the design side to possibly update fonts and styles. We may readjust font styles following this. For now, we can merge this PR to implement consistencies. cc: @SayaGT ## **Related issues** Fixes: #14772 ## **Manual testing steps** Test various mobile redesigned confirmation pages ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ![CleanShot 2025-04-16 at 22 46 18](https://github.com/user-attachments/assets/690fc554-60a5-415d-b52a-a5b935efa5fa) ![CleanShot 2025-04-16 at 22 46 34](https://github.com/user-attachments/assets/1b152d4a-6c7e-466d-9897-6a781b3d21bf) ### **After** ![CleanShot 2025-04-16 at 23 39 44](https://github.com/user-attachments/assets/0d11c8ff-3f95-4858-a7fb-266fa42bcdd1) ![CleanShot 2025-04-16 at 23 40 01](https://github.com/user-attachments/assets/0d3844e2-eaeb-4884-bd10-ade57a0032bb) ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 57a9981 commit 59dba15

21 files changed

Lines changed: 5 additions & 28 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
4545

4646
- fix(bridge): keyboard not appearing when error banner is displayed ([#14862](https://github.com/MetaMask/metamask-mobile/pull/14862))
4747
- fix(bridge): fix not switching networks when selecting source token ([#14712](https://github.com/MetaMask/metamask-mobile/pull/14712))
48+
- fix: update confirmation font sizes ([#14715](https://github.com/MetaMask/metamask-mobile/pull/14715))
4849
- fix: updates a padding style specifically for Android devices ([#14725](https://github.com/MetaMask/metamask-mobile/pull/14725))
4950
- fix(bridge): enhance UI/UX with improved input handling and layout adjustments ([#14781](https://github.com/MetaMask/metamask-mobile/pull/14781))
5051
- fix(swaps): set default slippage when source or destination token is not stablecoin ([#14730](https://github.com/MetaMask/metamask-mobile/pull/14730))

app/components/Views/confirmations/components/UI/Tooltip/Tooltip.styles.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ const styleSheet = (params: { theme: Theme }) => {
5050
modalContentValue: {
5151
color: theme.colors.text.default,
5252
...fontStyles.normal,
53-
fontSize: 14,
5453
},
5554
});
5655
};

app/components/Views/confirmations/components/UI/expandable-section/expandable-section.styles.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ const styleSheet = (params: { theme: Theme, vars: { isCompact: boolean | undefin
3535
expandedContentTitle: {
3636
color: theme.colors.text.default,
3737
...fontStyles.bold,
38-
fontSize: isCompact ? 16 : 14,
3938
width: '90%',
4039
textAlign: 'center',
4140
},

app/components/Views/confirmations/components/UI/info-row/info-row.styles.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ const styleSheet = (params: { theme: Theme }) => {
2727
value: {
2828
color: theme.colors.text.default,
2929
...fontStyles.normal,
30-
fontSize: 14,
3130
},
3231
valueOnNewLineContainer: {
3332
paddingBottom: 8,

app/components/Views/confirmations/components/UI/info-row/info-value/display-url/display-url.styles.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ const styleSheet = (params: { theme: Theme }) => {
1515
value: {
1616
color: theme.colors.text.default,
1717
...fontStyles.normal,
18-
fontSize: 14,
1918
},
2019
warningContainer: {
2120
display: 'flex',

app/components/Views/confirmations/components/UI/info-row/info-value/network/__snapshots__/network.test.tsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ exports[`Network should match snapshot 1`] = `
4242
{
4343
"color": "#121314",
4444
"fontFamily": "CentraNo1-Book",
45-
"fontSize": 14,
45+
"fontSize": 16,
4646
"fontWeight": "400",
4747
"letterSpacing": 0,
4848
"lineHeight": 24,

app/components/Views/confirmations/components/UI/info-row/info-value/network/network.styles.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ const styleSheet = (params: { theme: Theme }) => {
1515
value: {
1616
color: theme.colors.text.default,
1717
...fontStyles.normal,
18-
fontSize: 14,
1918
marginLeft: 8,
2019
},
2120
});

app/components/Views/confirmations/components/UI/info-row/info-value/network/style.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ const createStyles = (colors: Colors) =>
1313
value: {
1414
color: colors.text.default,
1515
...fontStyles.normal,
16-
fontSize: 14,
1716
marginTop: 8,
1817
},
1918
warningContainer: {

app/components/Views/confirmations/components/UI/text-with-tooltip/text-with-tooltip.styles.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ const styleSheet = (params: { theme: Theme }) => {
1818
paddingVertical: 8,
1919
},
2020
text: {
21-
fontSize: 16,
2221
...fontStyles.normal,
2322
},
2423
tooltipHeader: {

app/components/Views/confirmations/components/info/personal-sign/message.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,11 @@ const styleSheet = (params: { theme: Theme }) => {
2424
messageExpanded: {
2525
color: theme.colors.text.default,
2626
...fontStyles.normal,
27-
fontSize: 14,
2827
fontWeight: '400',
2928
},
3029
siweTos: {
3130
color: theme.colors.text.default,
3231
...fontStyles.normal,
33-
fontSize: 14,
3432
fontWeight: '400',
3533
paddingHorizontal: 8,
3634
marginBottom: 8,

0 commit comments

Comments
 (0)