chore(rewards): completed ondo campaign ui changes

VGR-GIT · VGR-GIT · commit 5a70bbb54fd8 · 2026-04-24T16:06:36.000+02:00
diff --git a/app/components/UI/Rewards/Views/OndoCampaignDetailsView.test.tsx b/app/components/UI/Rewards/Views/OndoCampaignDetailsView.test.tsx
@@ -1505,6 +1505,62 @@ describe('OndoCampaignDetailsView', () => {
     });
   });
 
+  describe('positions section visibility', () => {
+    it('hides the positions section when campaign is complete, even if opted in with positions', () => {
+      const lastMonth = new Date();
+      lastMonth.setMonth(lastMonth.getMonth() - 1);
+      const yesterday = new Date();
+      yesterday.setDate(yesterday.getDate() - 1);
+
+      mockUseRewardCampaigns.mockReturnValue({
+        ...hookDefaults,
+        campaigns: [
+          createTestCampaign({
+            startDate: lastMonth.toISOString(),
+            endDate: yesterday.toISOString(),
+          }),
+        ],
+      });
+      mockUseGetCampaignParticipantStatus.mockReturnValue({
+        status: { optedIn: true, participantCount: 1 },
+        isLoading: false,
+        hasError: false,
+        refetch: jest.fn(),
+      });
+      mockUseGetOndoPortfolioPosition.mockReturnValue({
+        portfolio: { positions: [{}], summary: {}, computedAt: '' } as never,
+        isLoading: false,
+        hasError: false,
+        hasFetched: true,
+        refetch: jest.fn(),
+      });
+      const { queryByTestId } = render(<OndoCampaignDetailsView />);
+      expect(queryByTestId('ondo-campaign-portfolio')).toBeNull();
+    });
+
+    it('shows the positions section when campaign is active, opted in with positions', () => {
+      mockUseRewardCampaigns.mockReturnValue({
+        ...hookDefaults,
+        campaigns: [createTestCampaign()],
+      });
+      mockUseGetCampaignParticipantStatus.mockReturnValue({
+        status: { optedIn: true, participantCount: 1 },
+        isLoading: false,
+        hasError: false,
+        refetch: jest.fn(),
+      });
+      mockUseGetOndoPortfolioPosition.mockReturnValue({
+        portfolio: { positions: [{}], summary: {}, computedAt: '' } as never,
+        isLoading: false,
+        hasError: false,
+        hasFetched: true,
+        refetch: jest.fn(),
+      });
+      const { getByTestId } = render(<OndoCampaignDetailsView />);
+      expect(getByTestId('ondo-campaign-portfolio')).toBeDefined();
+    });
+  });
+
   describe('portfolio and leaderboard navigation', () => {
     const setupOptedInWithPositions = () => {
       mockUseRewardCampaigns.mockReturnValue({
diff --git a/app/components/UI/Rewards/Views/OndoCampaignDetailsView.tsx b/app/components/UI/Rewards/Views/OndoCampaignDetailsView.tsx
@@ -277,7 +277,8 @@ const OndoCampaignDetailsView: React.FC = () => {
         !hasPositions &&
         getCampaignStatus(campaign) === 'active',
       showStatsSummarySection: hasPositions,
-      showPortfolioSection: isOptedIn && hasPositions,
+      showPortfolioSection:
+        isOptedIn && hasPositions && getCampaignStatus(campaign) !== 'complete',
       showLeaderboardSection: true,
     };
   }, [campaign, isOptedIn, hasPositions]);
@@ -523,6 +524,9 @@ const OndoCampaignDetailsView: React.FC = () => {
                       currentUserReferralCode={referralCode}
                       userPosition={leaderboardUserPosition}
                       campaignId={effectiveCampaignId}
+                      isCampaignComplete={
+                        getCampaignStatus(campaign) === 'complete'
+                      }
                     />
                   </Box>
                 </>
diff --git a/app/components/UI/Rewards/Views/OndoCampaignStatsView.test.tsx b/app/components/UI/Rewards/Views/OndoCampaignStatsView.test.tsx
@@ -666,6 +666,54 @@ describe('OndoCampaignStatsView', () => {
     expect(getByText('$12,000.00')).toBeDefined();
   });
 
+  it('hides market value label when campaign is complete', () => {
+    mockGetCampaignStatus.mockReturnValue('complete');
+    mockRewardsState.campaigns = [createTestCampaign()];
+    mockUseGetOndoPortfolioPosition.mockReturnValue({
+      ...portfolioDefaults,
+      portfolio: {
+        positions: [],
+        summary: {
+          totalCurrentValue: '12000',
+          totalBookValue: '11000',
+          totalUsdDeposited: '11000',
+          netDeposit: '10500',
+          totalCashedOut: '0',
+          portfolioPnl: '1000',
+          portfolioPnlPercent: '0.09',
+        },
+        computedAt: '2024-01-01T00:00:00Z',
+      },
+    });
+    const { queryByText } = render(<OndoCampaignStatsView />);
+    expect(
+      queryByText('rewards.ondo_campaign_stats.label_market_value'),
+    ).toBeNull();
+  });
+
+  it('shows market value label when campaign is active', () => {
+    mockUseGetOndoPortfolioPosition.mockReturnValue({
+      ...portfolioDefaults,
+      portfolio: {
+        positions: [],
+        summary: {
+          totalCurrentValue: '12000',
+          totalBookValue: '11000',
+          totalUsdDeposited: '11000',
+          netDeposit: '10500',
+          totalCashedOut: '0',
+          portfolioPnl: '1000',
+          portfolioPnlPercent: '0.09',
+        },
+        computedAt: '2024-01-01T00:00:00Z',
+      },
+    });
+    const { getByText } = render(<OndoCampaignStatsView />);
+    expect(
+      getByText('rewards.ondo_campaign_stats.label_market_value'),
+    ).toBeDefined();
+  });
+
   it('shows pending tag when position is not qualified', () => {
     mockUseGetOndoLeaderboardPosition.mockReturnValue({
       ...positionDefaults,
@@ -856,6 +904,25 @@ describe('OndoCampaignStatsView', () => {
         queryByText('rewards.ondo_campaign_leaderboard.ineligible'),
       ).toBeNull();
     });
+
+    it('does not show pending tag when campaign is complete even if position is not qualified', () => {
+      mockGetCampaignStatus.mockReturnValue('complete');
+      mockRewardsState.campaigns = [createTestCampaign()];
+      mockUseGetCampaignParticipantStatus.mockReturnValue({
+        status: { optedIn: true, participantCount: 1 },
+        isLoading: false,
+        hasError: false,
+        refetch: jest.fn(),
+      });
+      mockUseGetOndoLeaderboardPosition.mockReturnValue({
+        ...positionDefaults,
+        position: makePendingPosition(),
+      });
+      const { queryByText } = render(<OndoCampaignStatsView />);
+      expect(
+        queryByText('rewards.ondo_campaign_leaderboard.pending'),
+      ).toBeNull();
+    });
   });
 
   it('uses routeCampaignName as fallback when campaign has no name', () => {
diff --git a/app/components/UI/Rewards/Views/OndoCampaignStatsView.tsx b/app/components/UI/Rewards/Views/OndoCampaignStatsView.tsx
@@ -230,9 +230,9 @@ const OndoCampaignStatsView: React.FC = () => {
               rank={rankValue}
               tier={tierValue}
               isLoading={leaderboardLoading}
-              isPending={isPending}
+              isPending={!isCampaignComplete && isPending}
               isQualified={isQualified}
-              isIneligible={isIneligible}
+              isIneligible={!isCampaignComplete && isIneligible}
             />
           </Box>
 
@@ -252,14 +252,16 @@ const OndoCampaignStatsView: React.FC = () => {
                 isLoading={portfolioLoading}
                 valueColor={returnColor}
               />
-              <StatCell
-                label={strings(
-                  'rewards.ondo_campaign_stats.label_market_value',
-                )}
-                value={marketValue}
-                isLoading={portfolioLoading}
-                valueColor={returnColor}
-              />
+              {!isCampaignComplete && (
+                <StatCell
+                  label={strings(
+                    'rewards.ondo_campaign_stats.label_market_value',
+                  )}
+                  value={marketValue}
+                  isLoading={portfolioLoading}
+                  valueColor={returnColor}
+                />
+              )}
             </Box>
 
             {/* Net inflow | Outflow (or Days held when no outflow) */}
diff --git a/app/components/UI/Rewards/Views/OndoLeaderboardView.test.tsx b/app/components/UI/Rewards/Views/OndoLeaderboardView.test.tsx
@@ -358,4 +358,61 @@ describe('OndoLeaderboardView', () => {
       expect.objectContaining({ defaultTier: 'MID' }),
     );
   });
+
+  describe('isCampaignComplete behavior', () => {
+    const completeCampaign = {
+      ...mockCampaign,
+      startDate: '2024-01-01T00:00:00Z',
+      endDate: '2024-01-02T00:00:00Z',
+    };
+
+    const pendingPosition = {
+      rank: 8,
+      projectedTier: 'STARTER',
+      qualified: false,
+      qualifiedDays: 3,
+      totalInTier: 100,
+      rateOfReturn: 0.05,
+      currentUsdValue: 5000,
+      totalUsdDeposited: 4000,
+      netDeposit: 3500,
+      neighbors: [],
+      computedAt: '2024-01-01T00:00:00Z',
+    };
+
+    it('does not show Pending tag when campaign is complete and position is not qualified', () => {
+      mockUseSelector.mockImplementation((selector: (s: unknown) => unknown) =>
+        selector({
+          rewards: { referralCode: null, campaigns: [completeCampaign] },
+        }),
+      );
+      mockUseGetOndoLeaderboardPosition.mockReturnValue({
+        ...positionDefaults,
+        position: pendingPosition,
+      });
+      const { queryByText } = render(<OndoLeaderboardView />);
+      expect(
+        queryByText('rewards.ondo_campaign_leaderboard.pending'),
+      ).toBeNull();
+    });
+
+    it('passes isCampaignComplete=true to OndoLeaderboard when campaign is complete', () => {
+      mockUseSelector.mockImplementation((selector: (s: unknown) => unknown) =>
+        selector({
+          rewards: { referralCode: null, campaigns: [completeCampaign] },
+        }),
+      );
+      render(<OndoLeaderboardView />);
+      expect(mockOndoLeaderboard).toHaveBeenCalledWith(
+        expect.objectContaining({ isCampaignComplete: true }),
+      );
+    });
+
+    it('passes isCampaignComplete=false to OndoLeaderboard when campaign is active', () => {
+      render(<OndoLeaderboardView />);
+      expect(mockOndoLeaderboard).toHaveBeenCalledWith(
+        expect.objectContaining({ isCampaignComplete: false }),
+      );
+    });
+  });
 });
diff --git a/app/components/UI/Rewards/Views/OndoLeaderboardView.tsx b/app/components/UI/Rewards/Views/OndoLeaderboardView.tsx
@@ -23,6 +23,7 @@ import { useGetCampaignParticipantStatus } from '../hooks/useGetCampaignParticip
 import { getCurrentPrize } from '../components/Campaigns/OndoPrizePool';
 import { formatPercentChange, formatUsd } from '../utils/formatUtils';
 import { isCampaignIneligible } from '../utils/ondoCampaignConstants';
+import { getCampaignStatus } from '../components/Campaigns/CampaignTile.utils';
 import { strings } from '../../../../../locales/i18n';
 import Routes from '../../../../constants/navigation/Routes';
 import {
@@ -73,6 +74,9 @@ const OndoLeaderboardView: React.FC = () => {
   const { deposits, isLoading: isDepositsLoading } =
     useGetOndoCampaignDeposits(campaignId);
 
+  const isCampaignComplete =
+    campaign != null && getCampaignStatus(campaign) === 'complete';
+
   const isPending = position != null && !position.qualified;
   const isQualified = position != null && position.qualified;
 
@@ -168,9 +172,9 @@ const OndoLeaderboardView: React.FC = () => {
                   rank={rankValue}
                   tier={tierValue}
                   isLoading={isPositionLoading}
-                  isPending={isPending}
+                  isPending={!isCampaignComplete && isPending}
                   isQualified={isQualified}
-                  isIneligible={isIneligible}
+                  isIneligible={!isCampaignComplete && isIneligible}
                   showReturn
                   returnValue={returnValue}
                   returnColor={returnColor}
@@ -197,6 +201,7 @@ const OndoLeaderboardView: React.FC = () => {
               currentUserReferralCode={referralCode}
               userPosition={leaderboardUserPosition}
               campaignId={campaignId}
+              isCampaignComplete={isCampaignComplete}
             />
           </Box>
         </ScrollView>
diff --git a/app/components/UI/Rewards/components/Campaigns/CampaignStatsSummary.test.tsx b/app/components/UI/Rewards/components/Campaigns/CampaignStatsSummary.test.tsx
@@ -621,6 +621,33 @@ describe('CampaignStatsSummary', () => {
 
   // ── Campaign complete state ───────────────────────────────────────
 
+  it('hides IneligibleTag from rank cell suffix when isCampaignComplete=true', () => {
+    const { queryByTestId } = render(
+      <CampaignStatsSummary {...baseProps} isIneligible isCampaignComplete />,
+    );
+    expect(
+      queryByTestId(CAMPAIGN_STATS_SUMMARY_TEST_IDS.INELIGIBLE_TAG),
+    ).toBeNull();
+  });
+
+  it('hides PendingTag from rank cell suffix when isCampaignComplete=true and position is pending', () => {
+    const pendingPosition: CampaignLeaderboardPositionDto = {
+      ...MOCK_POSITION,
+      qualified: false,
+      qualifiedDays: 3,
+    };
+    const { queryByTestId } = render(
+      <CampaignStatsSummary
+        {...baseProps}
+        leaderboardPosition={pendingPosition}
+        isCampaignComplete
+      />,
+    );
+    expect(
+      queryByTestId(CAMPAIGN_STATS_SUMMARY_TEST_IDS.PENDING_TAG),
+    ).toBeNull();
+  });
+
   it('hides qualified card when isCampaignComplete=true', () => {
     const { queryByText } = render(
       <CampaignStatsSummary
@@ -658,6 +685,24 @@ describe('CampaignStatsSummary', () => {
     expect(queryByText('Qualify for this rank')).toBeNull();
   });
 
+  it('hides market value cell when isCampaignComplete=true', () => {
+    const { queryByTestId } = render(
+      <CampaignStatsSummary {...baseProps} isCampaignComplete />,
+    );
+    expect(
+      queryByTestId(CAMPAIGN_STATS_SUMMARY_TEST_IDS.MARKET_VALUE),
+    ).toBeNull();
+  });
+
+  it('shows market value cell when isCampaignComplete=false', () => {
+    const { getByTestId } = render(
+      <CampaignStatsSummary {...baseProps} isCampaignComplete={false} />,
+    );
+    expect(
+      getByTestId(CAMPAIGN_STATS_SUMMARY_TEST_IDS.MARKET_VALUE),
+    ).toBeDefined();
+  });
+
   it('shows outcome banner when isCampaignComplete=true and outcome is provided', () => {
     const { getByTestId } = render(
       <CampaignStatsSummary
diff --git a/app/components/UI/Rewards/components/Campaigns/CampaignStatsSummary.tsx b/app/components/UI/Rewards/components/Campaigns/CampaignStatsSummary.tsx
@@ -193,11 +193,11 @@ const CampaignStatsSummary: React.FC<CampaignStatsSummaryProps> = ({
           isLoading={leaderboardLoading}
           testID={CAMPAIGN_STATS_SUMMARY_TEST_IDS.RANK}
           suffix={
-            isIneligible ? (
+            !isCampaignComplete && isIneligible ? (
               <IneligibleTag
                 testID={CAMPAIGN_STATS_SUMMARY_TEST_IDS.INELIGIBLE_TAG}
               />
-            ) : isPending ? (
+            ) : !isCampaignComplete && isPending ? (
               <PendingTag
                 testID={CAMPAIGN_STATS_SUMMARY_TEST_IDS.PENDING_TAG}
               />
@@ -228,13 +228,15 @@ const CampaignStatsSummary: React.FC<CampaignStatsSummaryProps> = ({
           valueColor={returnColor}
           testID={CAMPAIGN_STATS_SUMMARY_TEST_IDS.RETURN}
         />
-        <StatCell
-          label={strings('rewards.ondo_campaign_stats.label_market_value')}
-          value={marketValue}
-          isLoading={portfolioLoading}
-          valueColor={returnColor}
-          testID={CAMPAIGN_STATS_SUMMARY_TEST_IDS.MARKET_VALUE}
-        />
+        {!isCampaignComplete && (
+          <StatCell
+            label={strings('rewards.ondo_campaign_stats.label_market_value')}
+            value={marketValue}
+            isLoading={portfolioLoading}
+            valueColor={returnColor}
+            testID={CAMPAIGN_STATS_SUMMARY_TEST_IDS.MARKET_VALUE}
+          />
+        )}
       </Box>
 
       {/* Outcome banner (campaign ended) */}
diff --git a/app/components/UI/Rewards/components/Campaigns/OndoLeaderboard.test.tsx b/app/components/UI/Rewards/components/Campaigns/OndoLeaderboard.test.tsx
diff --git a/app/components/UI/Rewards/components/Campaigns/OndoLeaderboard.tsx b/app/components/UI/Rewards/components/Campaigns/OndoLeaderboard.tsx
